WordPress.org

Make WordPress Themes

#12025 closed theme (live)

THEME: My Life - 0.3

Reported by: greenshady Owned by: chipbennett
Priority: Keywords: theme-my-life
Cc: justin@…

Description

My Life - 0.3

A serene blogging theme that emphasizes your content with readable typography. It uses post formats; has three nav menu locations; and supports one-, two-, and three-column layouts.

Theme URL - http://themehybrid.com/themes/my-life
Author URL - http://justintadlock.com

SVN - http://themes.svn.wordpress.org/my-life/0.3
ZIP - http://wordpress.org/extend/themes/download/my-life.0.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/my-life/0.2&new_path=/my-life/0.3

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-my-life&order=id

https://themes.svn.wordpress.org/my-life/0.3/screenshot.png

Change History (2)

comment:1 chipbennett13 months ago

  • Owner set to chipbennett
  • Status changed from new to assigned

comment:2 chipbennett13 months ago

  • Resolution set to approved
  • Status changed from assigned to closed

Previous Ticket Required Issues

  • get_bloginfo( 'text_direction' ): not required to use is_rtl(). Note that the deprecation notice is commented out in core
  • CSS coding standards: not required; recommended only
  • TEMPLATEPATH: required to replace with get_template_directory(). Appears to be addressed.
  • STYLESHEETPATH: '''required''' to replace with get_stylesheet_directory()`. Appears to be addressed.
  • Image resize: the resized-in-editor image is a unit test data issue. Resizing images in the browser is done by the user, not by the Theme. So, I don't think there's an issue here

Required Issues

  • Some functions added to Hybrid core are not properly namespaced

Recommended

  • A change log, especially for Hybrid Core, would be a huge assistance

Review Summary

  • Previous version of Theme approved
  • Theme had required issues in previous ticket. All were addressed
  • Diff-review only
  • Mostly changes to Hybrid Core
  • Theme has required issues
  • Ticket being resolved as approved. Please address required issues in next Theme revision
Note: See TracTickets for help on using tickets.