WordPress.org

Make WordPress Themes

Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#12531 closed theme (not-approved)

THEME: Duotone - 2.2.2

Reported by: automattic Owned by: Frank Klein
Priority: previously reviewed Keywords: theme-duotone
Cc: themes@…, lancewillett, kobenland

Description

Duotone - 2.2.2

A brilliant photoblogging theme with a dynamic background color based on the colors in your photos. Includes three widget areas, custom menu support, and EXIF display for photos. Duotone is a much-improved successor to Monotone.

Theme URL - http://theme.wordpress.com/themes/duotone/
Author URL - http://automattic.com/

SVN - http://themes.svn.wordpress.org/duotone/2.2.2
ZIP - http://wordpress.org/extend/themes/download/duotone.2.2.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/duotone/2.2.1&new_path=/duotone/2.2.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-duotone&order=id

https://themes.svn.wordpress.org/duotone/2.2.2/screenshot.png

Change History (6)

comment:2 Frank Klein10 months ago

  • Owner set to Frank Klein
  • Status changed from new to reviewing

comment:3 Frank Klein10 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Issues from previous review #6095

  • FIXED: theme must be error-free: "Filename cannot be empty" error.
  • FIXED: htaccess.txt should be explained or removed.

Review

Required

Policy Requirements

  • Themes are required to provide end-user documentation of any design limitations or extraordinary installation/setup instructions. There should be an explanation of the handling of the blog layout (a forced one post display) as well as the widget handling (no more than three visible at once).

Code Quality

  • wp_head call should be right before the closing head tag. Cf. header.php, line 20
  • On the Markup Image Alignment post in the Theme Unit Test data, there is a PHP Notice: Undefined variable: the_best_s. It seems to me that this is due to the fact that all the pictures in the post have achromatic colors (so they have equal parts of R, G and B). This means that $delta on line 715 is 0, so on line 717 $s will turn out 0. As such the condition in line 819 doesn't apply, which in turn means that $the_best_s variable will never be defined, resulting in a notice on line 830.

Theme Unit Test

  • Markup: HTML Tags and Formatting - Small styling issues: quote in a quote (no indentation), tables (no stylings), abbreviation (no dotted underline or other), pre (overflows the content area)
  • Post Format Gallery - From the 5 columns to the 9 columns gallery, the image captions "stick" together or overflow into each other.
  • Template: Comments - Some key elements like for example header lack styling (HTML Tags and Formatting comment).

Theme Unit Test

  • Template: Comments - The previous comment and next comment links are placed awkwardly.
  • Drop-down menu - The third level of menu items is displayed over the second level.

comment:4 lancewillett10 months ago

  • Cc lancewillett kobenland added

CCing so we get notifications.

comment:5 kobenland10 months ago

Thanks for taking the time to review Duotone, Frank!
I'll take a look at these issues and resubmit shortly.

Konstantin

Last edited 10 months ago by kobenland (previous) (diff)

comment:6 kobenland10 months ago

Updated in #13279.

Note: See TracTickets for help on using tickets.