WordPress.org

Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12538 closed theme (not-approved)

THEME: Customizr - 2.0.4

Reported by: nikeo Owned by: shelob9
Priority: Keywords: theme-customizr
Cc: contact@…

Description

Customizr - 2.0.4

A fully responsive theme, easy to customize and built with HTML5 & CSS3 upon the Twitter Bootstrap framework.The clean design can be used for any type of website : corporate, portfolio, business, blog, etc. Choose a skin, upload your logo, set up your social network profiles and you are done! It also includes a handy responsive slider generator (with call to action text and button) that can be embedded in any pages or posts. The theme supports five widgetized areas (two in the sidebars, three in the footer), up to three columns, nine post formats with special styles. It also comes with seven elegant skins and three handy featured page blocks for the front page.

Theme URL - http://www.themesandco.com/customizr
Author URL - http://www.themesandco.com/

SVN - http://themes.svn.wordpress.org/customizr/2.0.4
ZIP - http://wordpress.org/extend/themes/download/customizr.2.0.4.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/customizr/2.0.3&new_path=/customizr/2.0.4

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-customizr&order=id

https://themes.svn.wordpress.org/customizr/2.0.4/screenshot.png

Attachments (1)

Screen shot 2013-05-16 at 5.47.24 PM.png (137.2 KB) - added by shelob9 5 years ago.
debug errors on 404.

Download all attachments as: .zip

Change History (15)

#1 @shelob9
5 years ago

  • Owner set to shelob9
  • Status changed from new to assigned

#2 follow-up: @shelob9
5 years ago

Previous Issues From Ticket #12498
All issues are resolved.

New Issue

  • 404 page returns debugger errors in footer:

"Notice: Trying to get property of non-object in ~/wp-includes/general-template.php on line 1380"
"Notice: Trying to get property of non-object in ~/wp-includes/post-template.php on line 29"

Conclusion
Theme is not approved for the reasons listed above, which I found while checking out the scheduled post issue from the previous ticket.

Once you have uploaded a new version please leave a link to it in this ticket and I will review it as soon as possible.

#3 @shelob9
5 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

#4 in reply to: ↑ 2 @nikeo
5 years ago

Replying to shelob9:

Thanks again for your great and fast reviewing work!

Previous Issues From Ticket #12498
All issues are resolved.

New Issue

  • 404 page returns debugger errors in footer:

"Notice: Trying to get property of non-object in ~/wp-includes/general-template.php on line 1380"
"Notice: Trying to get property of non-object in ~/wp-includes/post-template.php on line 29"

I couldn't reproduce the bug. Here's a screencast of the 404 page test with debugger active and showing no notice : http://www.screenr.com/wvI7. Did you do something else so that I can reproduce the problem?

Conclusion
Theme is not approved for the reasons listed above, which I found while checking out the scheduled post issue from the previous ticket.

Once you have uploaded a new version please leave a link to it in this ticket and I will review it as soon as possible.

@shelob9
5 years ago

debug errors on 404.

#5 follow-up: @shelob9
5 years ago

I just added a screenshot of the errors I am getting. Do you have WP_DEBUG and SAVEQUERIES set in wp-config?

#6 in reply to: ↑ 5 @nikeo
5 years ago

Thanks for the screenshot. Weird...

Replying to shelob9:

I just added a screenshot of the errors I am getting. Do you have WP_DEBUG and SAVEQUERIES set in wp-config?

wp_debug and savequeries are activated see image below :

http://themesandco.com/test/wp-config.jpg


I also took a screenshot of my activated plugins, see below :

http://themesandco.com/test/plugins.jpg


Are there any differences in our WP config/settings/versions (I am using WP 3.5.1) or installed plugins that could generate this error on your side? Thanks, I look forward for your answer.


Nicolas

Last edited 5 years ago by nikeo (previous) (diff)

#7 follow-up: @shelob9
5 years ago

I am running the latest version of 3.5 which is WordPress 3.5.2-alpha in my test environment. I have only theme check and developer plugins installed. I also have all of the plugins that the developer plugin adds activated besides pig latin. I reproduced the issue with all plugins inactive.

I was unable to reproduce the error in 3.5.1. Let me query the list for judgment.

#8 in reply to: ↑ 7 @nikeo
5 years ago

Replying to shelob9:

I am running the latest version of 3.5 which is WordPress 3.5.2-alpha in my test environment. I have only theme check and developer plugins installed. I also have all of the plugins that the developer plugin adds activated besides pig latin. I reproduced the issue with all plugins inactive.

I was unable to reproduce the error in 3.5.1. Let me query the list for judgment.

Can you wait a few minutes, I just noticed there was a litte php syntax error in a printf of the footer. It might be the reason of this issue. I am uploading v2.0.5 in the repository right now.

#9 follow-up: @shelob9
5 years ago

I already sent the message and I'm interested in knowing the answer. If fixing that syntax error solves the problem in 3.5.2-alpha I'll aprove the theme and you're theme will be better off.

#10 in reply to: ↑ 9 @nikeo
5 years ago

Replying to shelob9:

I already sent the message and I'm interested in knowing the answer. If fixing that syntax error solves the problem in 3.5.2-alpha I'll aprove the theme and you're theme will be better off.



OK.
Here is the link to the new version : http://themes.trac.wordpress.org/ticket/12541

#11 follow-up: @shelob9
5 years ago

Still getting the same errors in 2.0.5. I will wait till I get a response from the list before passing judgment. If you install the beta testing plugin from the developer plugin settings and set it to Point release nightlies, you will be able to go to 3.5.2 beta to see the errors I'm getting.

here is a Pastebin doc where I pasted the source of the debug errors, if you can make sense of them.

I should have an answer soon on whether or not these errors will prevent v2.0.5 from being approved.

#12 in reply to: ↑ 11 @nikeo
5 years ago

Replying to shelob9:

Still getting the same errors in 2.0.5. I will wait till I get a response from the list before passing judgment. If you install the beta testing plugin from the developer plugin settings and set it to Point release nightlies, you will be able to go to 3.5.2 beta to see the errors I'm getting.

here is a Pastebin doc where I pasted the source of the debug errors, if you can make sense of them.

I should have an answer soon on whether or not these errors will prevent v2.0.5 from being approved.

OK Thanks again for your time. I will install 3.5.2 and wait for the list answer.
Have a nice day (or night?). For me it will be night (very late here in France...). ;-)

#13 follow-up: @shelob9
5 years ago

No problem. I am going to approve 2.0.5 in a second. Thanks for bearing with me today. Maybe we avoided a future issue, maybe it was just a bug with the alpha. You should see if you can reproduce the issue in 3.6-beta. You definitely want to make sure you are covered for 3.6, which should be coming out soon.

BTW Awesome theme. I've been taking some highly educational looks around the code, its given me some cool ideas for my theme.

Have a good night! I'm in the eastern US so my night is just beginning.

#14 in reply to: ↑ 13 @nikeo
5 years ago

Replying to shelob9:

No problem. I am going to approve 2.0.5 in a second. Thanks for bearing with me today. Maybe we avoided a future issue, maybe it was just a bug with the alpha. You should see if you can reproduce the issue in 3.6-beta. You definitely want to make sure you are covered for 3.6, which should be coming out soon.

BTW Awesome theme. I've been taking some highly educational looks around the code, its given me some cool ideas for my theme.

Have a good night! I'm in the eastern US so my night is just beginning.

Thank you. Very happy to contribute to WP community with this theme.

Note: See TracTickets for help on using tickets.