WordPress.org

Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13330 closed theme (not-approved)

THEME: IBuddy - 1.0

Reported by: aymanalzarrad Owned by: ZGani
Priority: new theme Keywords: theme-ibuddy
Cc: aymanalzarrad@…

Description

Change History (4)

#1 @ZGani
5 years ago

  • Owner set to ZGani
  • Status changed from new to reviewing

#2 @ZGani
5 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Required:

  • Screenshot must be a true facsimile of the theme once activated with default settings.
  • Theme url if used must be to a site/page with content specific to the theme - a mere demo of the theme is not acceptable.
  • Themes must declare theme copyright
  • Themes must include the copyright of the work which they are derivative of - The code and file structure indicates that your theme is a derivative of the underscores (_s) theme
  • License url - you have linked to license.txt. This is fine but there is no license.txt in the theme folder.

header.php

  • Google fonts should not be hard coded in to the template - all styles and scripts must be enqueued via a function callback hooked to the wp_enqueue_styles()/wp_enqueue_scripts() action.
  • wp_head must be immediately above the closing </head> tag

functions.php

  • add_image_size( 'Post', 810, 210, true); Post 810x410 - this should be called from with the after_setup_theme action

Themes Unit Test data: Theme returned a satisfactory result on the standard WordPress content. I have not fully tested against BuddyPress yet, this will be done once the above required issues have been addressed fully and the revised version uploaded for the review to continue.

If you have any questions regarding this review please feel free to ask in the comments.

Zulf

#3 follow-up: @aymanalzarrad
5 years ago

Hi @Zulf, thank you for the review.

I've noticed that I missed the above requirements after I submitted the theme to be reviewed. Anyway, I would like to know where/how to upload the revised version?

Could you confirm the below:

Themes must include the copyright of the work which they are derivative of - The code and file structure indicates that your theme is a derivative of the underscores (_s) theme

The same copyright rule should be applied for Option framework and Google font the theme is using, right?

#4 in reply to: ↑ 3 @ZGani
5 years ago

Replying to aymanalzarrad:

Hi @Zulf, thank you for the review.

No problem and please accept my apologies for the late response.

I've noticed that I missed the above requirements after I submitted the theme to be reviewed. Anyway, I would like to know where/how to upload the revised version?

Could you confirm the below:

Themes must include the copyright of the work which they are derivative of - The code and file structure indicates that your theme is a derivative of the underscores (_s) theme

What this means is if you've used the underscores and any other parent theme as the base for your theme then this fact must be declare and the copyright, license and url of the original work included in the theme's documents.

The same copyright rule should be applied for Option framework and Google font the theme is using, right?

Yes - copyright for all of the elements (scripts, images, fonts) used to create the theme which were not created by you for this theme must have their copyright, license and url included as above.

I see that you have uploaded a new version - will take that up for review and we can continue communication on that ticket.

Regards,
Zulf.

Note: See TracTickets for help on using tickets.