WordPress.org

Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13546 closed theme (live)

THEME: Just Pink - 1.3.1

Reported by: tatianeps Owned by: jcastaneda
Priority: theme update Keywords: theme-just-pink child-theme parent-twentytwelve
Cc: blog@…

Change History (6)

#1 @tatianeps
5 years ago

I only changed Theme URI to http://wordpress.org/extend/themes/just-pink on style.css so that it matches the live theme page.

#2 @jcastaneda
5 years ago

  • Keywords changed from theme-just-pink, child-theme, parent-twentytwelve to theme-just-pink child-theme parent-twentytwelve
  • Owner set to jcastaneda
  • Status changed from new to reviewing

#3 @jcastaneda
5 years ago

  • Status changed from reviewing to approved
  • Previously approved theme
  • No prior required issues
  • Minor change made in style.css
  • No issues encountered
  • Review based on quick install

I did notice one thing that you may want to remove from the header.php file and that is the @Package: WordPress PHPDoc information. :)

PS. I'm not fully sure how Child themes handle translation but one thing to consider is the domain you are using: twentytwelve.

#4 @chipbennett
5 years ago

  • Resolution set to live
  • Status changed from approved to closed

#5 @tatianeps
5 years ago

@jcastaneda

I've really forgotten to remove @Package:WordPress from header.php. I'll remove it and leave it ready to upload with a future upgrade of the theme. Thank you!

The theme of my blog is also a Twenty Twelve child-theme. My blog is written in Brazilian Portuguese and so far it seems that the translations using the domain twentytwelve work pretty well. Currently I only use the words and expressions already on WordPress translation files. If I ever add something else, then I'll use a different domain for the translation.

#6 @jcastaneda
5 years ago

Okay, good to know. :) LIke I said: I'm not too familiar with how child themes handle that.

Note: See TracTickets for help on using tickets.