WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13740 closed theme (live)

THEME: Opus Primus - 1.2.1

Reported by: cais Owned by: grapplerulrich
Priority: theme update Keywords: theme-opus-primus
Cc: edward.caissie@…

Description

Opus Primus - 1.2

A WordPress Framework Theme ... the first work. It works first. Designed and developed to be extensible and easily modified, based in the principles of decisions not options. Opus Primus supports all of the current Post-Formats as well as automagically converting between one, two, and three column layouts. You have access to custom backgrounds as well as a flexible custom header, too. Feel free to visit the Opus Primus website for more details and information about the theme and how it is built. Also, in the near future, you will be able to find tutorials on how to modify and work with Opus Primus Child-Themes.

Theme URL - http://opusprimus.com/
Author URL - http://edwardcaissie.com/

SVN - http://themes.svn.wordpress.org/opus-primus/1.2
ZIP - http://wordpress.org/themes/download/opus-primus.1.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/opus-primus/1.1.1&new_path=/opus-primus/1.2

History:

Ticket Summary Status Resolution Owner
#11106 THEME: Opus Primus - 1.0 closed closed-newer-version-uploaded emiluzelac
#11325 THEME: Opus Primus - 1.0.1 closed closed-newer-version-uploaded emiluzelac
#11367 THEME: Opus Primus - 1.0.2 closed closed-newer-version-uploaded emiluzelac
#11386 THEME: Opus Primus - 1.0.3 closed closed-newer-version-uploaded emiluzelac
#11417 THEME: Opus Primus - 1.0.4 closed live emiluzelac
#11738 THEME: Opus Primus - 1.1 closed live emiluzelac
#11803 THEME: Opus Primus - 1.1.1 closed live nishasingh
#13740 THEME: Opus Primus - 1.2.1 closed live grapplerulrich

(this ticket)

#15017 THEME: Opus Primus - 1.2.2 closed live ZGani
#16874 THEME: Opus Primus - 1.2.3 closed live jcastaneda
#18889 THEME: Opus Primus - 1.2.4 closed live tskk
#19955 THEME: Opus Primus - 1.2.5 closed live jcastaneda
#21772 THEME: Opus Primus - 1.3 closed live emiluzelac
#23510 THEME: Opus Primus – 1.3.3 closed live emiluzelac
#23681 THEME: Opus Primus – 1.3.4 closed live jcastaneda
#25523 THEME: Opus Primus – 1.4 closed live jcastaneda
#30366 THEME: Opus Primus – 1.4.1 closed live jcastaneda


https://themes.svn.wordpress.org/opus-primus/1.2/screenshot.png

Change History (13)

#1 @cais
4 years ago

Opus Primus changelog.txt

Last revised August 2, 2013

Version 1.2

  • Released August 2013

Code

  • Added display of featured image centered at full size in single standard post format view
  • Added full featured_image method call to single view of post formats audio, chat, quote, and status
  • Added get_author_description method in Authors class
  • Added filtered comment_form_required_field_glyph method in Comments class
  • Added many new filters - see http://opusprimus.com/under-the-page/hooks-filters/ or hooks-filters.txt for a current list
  • Added sanity conditional check to eliminate potential duplicate body classes
  • Added is_single conditional test before enqueue of Comment Tabs script
  • Added post to post navigation in single view
  • Added conditional check if not post password required when displaying comments
  • Added conditional for showing the page byline details
  • Added show_page_byline default and set as false
  • Changed the_post_thumbnail to use parameters which are set in the call to OpusPrimusImage::featured_image
  • Changed post thumbnail on pages to full size image and align to the center
  • Changed comment fields into an unordered list
  • Changed meta-tags container from p to div (adjusted CSS as needed)
  • Changed opus_post_byline_details filter to opus_post_byline_phrase
  • Check for long post titles in breadcrumbs and trim as needed
  • Display comment count in meta details if comments exist and comments are closed
  • Fixed call to wrong post navigation function in single view
  • Merge opus-ignite.php into functions.php
  • Moved featured_image method call into is_single conditional in post-format loops
  • Removed featured_image method call from post-formats link and video loops
  • Removed global $opus_image_meta; replaced with call to exif_data method
  • Removed style.less related function and action calls
  • Removed restore_image_title

CSS

  • Added styles for comment form fields
  • Added more specific selector used with .post.format-link
  • Added more BNS Plugin Integration (BPI) adjustments
  • Added styles from compiled style.less file (file removed)
  • Added img elements for captioned images and wp-smiley images
  • Address both class and id usage for the sidebar search form
  • Adjusted widths of comment form elements
  • Adjusted CSS to better handle large images with captions in large full-width displays
  • Adjusted table elements from max-width: 100% to width: 100% and other minor changes
  • Minor tweaks and adjustments
  • Sorted out the adaptive layout for screens less than 480px wide

JavaScript

  • Added more specific selector used with .post.format-link when adding .link-symbol class
  • Added script to create class to display tables with striped rows
  • Removed LESS JavaScript library

Stanzas

  • PullQuotes - Added pullquotes-readme.txt file
  • PullQuotes - Added left-side placement with new to parameter
  • Taglines - Added taglines-readme.txt file
  • THA - Added tha-readme.txt file

Miscellaneous

  • Documentation Updates
  • Minor changes to text tense used in changelog.txt
  • Removed style.less file (compiled and merged into opus-primus.css file)
  • Removed license references related to LESS as all components were removed
  • Updated hooks-actions.txt
  • Updated hooks-filters.txt
  • Updated readme.txt FAQ - What is the difference between how the "Featured Image" is used on a post and how it is used on a page?
  • Updated readme.txt FAQ - What are Stanzas?
  • Updated readme.txt FAQ - What happened to the LESS components of the theme?
  • Updated outstanding @todo items with version (number added at end of line)

A lot of changes but mostly in the back-end with a few changes to the front-end. Mostly driving towards fixing issues and improving performance.

#2 @grapplerulrich
4 years ago

  • Owner set to grapplerulrich
  • Status changed from new to reviewing

#3 follow-ups: @grapplerulrich
4 years ago

THEME REVIEW RESULTS

As there do not seem to be any guidelines for the translation-ready tag I will use Emil's comment as the guideline.

Required

  • Copyright, Uploaded, Camera, Shutter Speed, Aperture, Caption, Focal Length, ISO Speed, Title are not internationalized. Link

Here are a few translation improvements that you can make:

  • I would recommend adding the variable to the translation so that the translator can have the name in the beginning of the translation if need be. Link 1 Link 2
    __( 'Author: %s', 'opusprimus' )
    __( 'Modified by:', 'opusprimus' )
    
  • The translator will get this string to translate 'apply_filters( 'opus_exif_dimensions_label', 'Dimensions' )'. You do not want that. You want the translator to only translate 'Dimensions'. This is with all of rest of the segments underneath. Link
  • Add the text domain to the header. Codex
  • Add the language folder and add a pot file.

Review Summary

Diff review against previously approved theme. Changes are as noted by theme author. No visual issues found. Diff-review and quick test. This ticket is being resolved as NOT-APPROVED due to the translation requirements. You can fix this and reupload the same version to be APPROVED.

#4 in reply to: ↑ 3 ; follow-up: @cais
4 years ago

Replying to grapplerulrich:

THEME REVIEW RESULTS

As there do not seem to be any guidelines for the translation-ready tag I will use Emil's comment as the guideline.

If there are no specific guidelines written you should not resolve to "not-approved" for an (partial) omission.

Required

  • Copyright, Uploaded, Camera, Shutter Speed, Aperture, Caption, Focal Length, ISO Speed, Title are not internationalized. Link

I will definitely look into correcting these as needed but also consider this is original release code that you are now over-riding an admin's review decision on.

Here are a few translation improvements that you can make:

  • I would recommend adding the variable to the translation so that the translator can have the name in the beginning of the translation if need be. Link 1 Link 2
    __( 'Author: %s', 'opusprimus' )
    __( 'Modified by:', 'opusprimus' )
    
  • The translator will get this string to translate 'apply_filters( 'opus_exif_dimensions_label', 'Dimensions' )'. You do not want that. You want the translator to only translate 'Dimensions'. This is with all of rest of the segments underneath. Link
  • Add the text domain to the header. Codex
  • Add the language folder and add a pot file.

Thank you for the recommendations, I will taken them under advisement. Also to note, being translation ready does not require a language folder if there is no .pot file, nor does it require a .pot file at all.

The test domain in the theme header is essentially bloat as it has no bearing in themes, plugins yes but not in themes as core currently stands.

Review Summary

Diff review against previously approved theme. Changes are as noted by theme author. No visual issues found. Diff-review and quick test. This ticket is being resolved as NOT-APPROVED due to the translation requirements. You can fix this and reupload the same version to be APPROVED.

#5 in reply to: ↑ 4 @grapplerulrich
4 years ago

Replying to cais:

If there are no specific guidelines written you should not resolve to "not-approved" for an (partial) omission.

I think it would be unfair to say that the theme is translation-ready if the translator is unable to translate all of the strings. If you fix this I will APPROVE it.

I will definitely look into correcting these as needed but also consider this is original release code that you are now over-riding an admin's review decision on.

Thank you for the recommendations, I will taken them under advisement. Also to note, being translation ready does not require a language folder if there is no .pot file, nor does it require a .pot file at all.

That is why it is under recommendation.

The test domain in the theme header is essentially bloat as it has no bearing in themes, plugins yes but not in themes as core currently stands.

This is not bloat. By adding it the translator is able to translate text in the file headers like description and page template names.

#6 @cais
4 years ago

I'll re-submit the theme less the translation-ready tag, mostly due to being a WPTRT administrator and expecting to be held to a higher standard. The other modifications are more important now than a tag that is not 100% accurate.

Also, writing as an administrator, I would be remiss in not adding that it is also common practice when reviewing a previously approved theme to allow one (or two) non-significant issues and resolving the theme as "approved" with the notation these issues are required to be corrected with the next release.

#7 @themetracbot
4 years ago

  • Summary changed from THEME: Opus Primus - 1.2 to THEME: Opus Primus - 1.2.1

Opus Primus - 1.2.1

A WordPress Framework Theme ... the first work. It works first. Designed and developed to be extensible and easily modified, based in the principles of decisions not options. Opus Primus supports all of the current Post-Formats as well as automagically converting between one, two, and three column layouts. You have access to custom backgrounds as well as a flexible custom header, too. Feel free to visit the Opus Primus website for more details and information about the theme and how it is built. Also, in the near future, you will be able to find tutorials on how to modify and work with Opus Primus Child-Themes.

Theme URL - http://opusprimus.com/
Author URL - http://edwardcaissie.com/

SVN - http://themes.svn.wordpress.org/opus-primus/1.2.1
ZIP - http://wordpress.org/themes/download/opus-primus.1.2.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/opus-primus/1.2&new_path=/opus-primus/1.2.1

History:

Ticket Summary Status Resolution Owner
#11106 THEME: Opus Primus - 1.0 closed closed-newer-version-uploaded emiluzelac
#11325 THEME: Opus Primus - 1.0.1 closed closed-newer-version-uploaded emiluzelac
#11367 THEME: Opus Primus - 1.0.2 closed closed-newer-version-uploaded emiluzelac
#11386 THEME: Opus Primus - 1.0.3 closed closed-newer-version-uploaded emiluzelac
#11417 THEME: Opus Primus - 1.0.4 closed live emiluzelac
#11738 THEME: Opus Primus - 1.1 closed live emiluzelac
#11803 THEME: Opus Primus - 1.1.1 closed live nishasingh
#13740 THEME: Opus Primus - 1.2.1 closed live grapplerulrich

(this ticket)

#15017 THEME: Opus Primus - 1.2.2 closed live ZGani
#16874 THEME: Opus Primus - 1.2.3 closed live jcastaneda
#18889 THEME: Opus Primus - 1.2.4 closed live tskk
#19955 THEME: Opus Primus - 1.2.5 closed live jcastaneda
#21772 THEME: Opus Primus - 1.3 closed live emiluzelac
#23510 THEME: Opus Primus – 1.3.3 closed live emiluzelac
#23681 THEME: Opus Primus – 1.3.4 closed live jcastaneda
#25523 THEME: Opus Primus – 1.4 closed live jcastaneda
#30366 THEME: Opus Primus – 1.4.1 closed live jcastaneda


https://themes.svn.wordpress.org/opus-primus/1.2.1/screenshot.png

#8 @cais
4 years ago

  • Removed translation-ready tag

#9 @grapplerulrich
4 years ago

Thanks

Review Summary

Diff review against previously approved theme. Changes are as noted by theme author. No visual issues found. Diff-review and quick test. This ticket is being resolved as APPROVED

#10 @grapplerulrich
4 years ago

  • Status changed from reviewing to approved

#11 @cais
4 years ago

  • Resolution set to live
  • Status changed from approved to closed

Thank you!

#12 in reply to: ↑ 3 @cais
4 years ago

Replying to grapplerulrich:
I've taken another look at these comments and have a few more thoughts on your recommendations below ...

Here are a few translation improvements that you can make:

  • I would recommend adding the variable to the translation so that the translator can have the name in the beginning of the translation if need be. Link 1 Link 2
    __( 'Author: %s', 'opusprimus' )
    __( 'Modified by:', 'opusprimus' )
    

In the case of the above references, your recommendation goes against the design and layout of the code and how it is applied. Please have another look at a single post that has been modified by a second author and you will have a better idea how this code is applied and why the "name" is not included. The "name" as you are referring to it is actually a potentially complete biography and contact details block for the referenced author.

  • The translator will get this string to translate 'apply_filters( 'opus_exif_dimensions_label', 'Dimensions' )'. You do not want that. You want the translator to only translate 'Dimensions'. This is with all of rest of the segments underneath. Link

I see what you are saying here ... it took a few reads through before the concept sank in but I have the code re-worked as this was an oversight on my part.

Thanks.

#13 @grapplerulrich
4 years ago

After having a closer look I see what you have done is fine for the auther code as you are using it as a title.

I am glad you see my second point. That is why it can be sometimes helpful if theme authors created a pot file.

Thanks

Note: See TracTickets for help on using tickets.