WordPress.org

Make WordPress Themes

Opened 9 months ago

Closed 8 months ago

#13860 closed theme (live)

THEME: zeeNoble - 1.0.1

Reported by: ThemeZee Owned by: ZGani
Priority: new theme Keywords: theme-zeenoble
Cc: netzberufler@…

Description

zeeNoble - 1.0

zeeNoble is a fully responsive WordPress theme that looks wonderful on any device. Theme Features include a frontpage template that supports widgets and also has a big content slideshow to attract visitors. Theme options let you choose from eight different color schemes, left or right sidebar layout and upload your own logo image. Of course there is support of all WordPress core features like custom menus, widgetized sidebars, custom background, custom headers and featured images. Check out a full demo on http://preview.themezee.com/zeenoble/

Theme URL - http://themezee.com/themes/zeenoble/
Author URL - http://themezee.com

SVN - http://themes.svn.wordpress.org/zeenoble/1.0
ZIP - http://wordpress.org/themes/download/zeenoble.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#13860 THEME: zeeNoble - 1.0.1 closed live ZGani

(this ticket)

#14051 THEME: zeeNoble - 1.0.2 closed live grapplerulrich
#14489 THEME: zeeNoble - 1.0.3 closed live emiluzelac
#16072 THEME: zeeNoble - 1.0.4 closed live Frumph


https://themes.svn.wordpress.org/zeenoble/1.0/screenshot.png

Attachments (1)

SelectElemetn.png (2.2 KB) - added by ZGani 9 months ago.
Select element overflows container

Download all attachments as: .zip

Change History (12)

comment:1 ZGani9 months ago

  • Owner set to ZGani
  • Status changed from new to reviewing

ZGani9 months ago

Select element overflows container

comment:2 ZGani9 months ago

Code Check.

Required:

  • Do not use query_posts and use the WP_Query filter for custom queries instead - 404.php.
  • Use esc_url(home_url('/')) in place of all instances of home_url() - searchform.php and header.php (check other instances too).
  • Themes must not provide backward compatibility for out-of-date WordPress versions (more than two prior major WordPress versions - currently, that means versions prior to WordPress 3.3), including using function_exists() conditional wrappers for current WordPress functions.

e.g. function_exists('register_sidebar').

Theme Unit Test.

All looks good except for...

  • Sidebar select element with long string overflows its container - see attachment.

Please address all the required issues raised above and upload a revised version for me to continue with the review

comment:3 themetracbot9 months ago

  • Summary changed from THEME: zeeNoble - 1.0 to THEME: zeeNoble - 1.0.1

zeeNoble - 1.0.1

zeeNoble is a fully responsive WordPress theme that looks wonderful on any device. Theme Features include a frontpage template that supports widgets and also has a big content slideshow to attract visitors. Theme options let you choose from eight different color schemes, left or right sidebar layout and upload your own logo image. Of course there is support of all WordPress core features like custom menus, widgetized sidebars, custom background, custom headers and featured images. Check out a full demo on http://preview.themezee.com/zeenoble/

Theme URL - http://themezee.com/themes/zeenoble/
Author URL - http://themezee.com

SVN - http://themes.svn.wordpress.org/zeenoble/1.0.1
ZIP - http://wordpress.org/themes/download/zeenoble.1.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/zeenoble/1.0&new_path=/zeenoble/1.0.1

History:

Ticket Summary Status Resolution Owner
#13860 THEME: zeeNoble - 1.0.1 closed live ZGani

(this ticket)

#14051 THEME: zeeNoble - 1.0.2 closed live grapplerulrich
#14489 THEME: zeeNoble - 1.0.3 closed live emiluzelac
#16072 THEME: zeeNoble - 1.0.4 closed live Frumph


https://themes.svn.wordpress.org/zeenoble/1.0.1/screenshot.png

comment:4 follow-up: ThemeZee9 months ago

Thanks very much for the fast review:

  • I have removed the query_posts function and used wp_get_recent_posts (a new WP_Query object seemed a little bit too overstated to just display a simple list of the latest posts)
  • I have wrapped the home_url() as well as all the_permalink and get_permalink functions with esc_url (hoping I haven't forgot anything)
  • I'm not quite sure what you meant with your third point, because I haven't found any function_exists('register_sidebar') code in my theme. Actually the theme uses an own function "themezee_register_sidebars" to register all sidebars - this function is pluggable to allow other developers to overwrite it within a child theme.
if ( ! function_exists( 'themezee_register_sidebars' ) ):
function themezee_register_sidebars() {
  • the sidebar overlow issue should be also gone

Thanks again for your time spent reviewing my theme.

comment:5 in reply to: ↑ 4 ZGani9 months ago

Replying to ThemeZee:

Thanks very much for the fast review:

  • I have removed the query_posts function and used wp_get_recent_posts (a new WP_Query object seemed a little bit too overstated to just display a simple list of the latest posts)
  • I have wrapped the home_url() as well as all the_permalink and get_permalink functions with esc_url (hoping I haven't forgot anything)
  • I'm not quite sure what you meant with your third point, because I haven't found any function_exists('register_sidebar') code in my theme. Actually the theme uses an own function "themezee_register_sidebars" to register all sidebars - this function is pluggable to allow other developers to overwrite it within a child theme.
if ( ! function_exists( 'themezee_register_sidebars' ) ):
function themezee_register_sidebars() {

That is the function I'm refering to - with the current requirements it should not be wrapped in the if fucntion_exists wrapper.

  • the sidebar overlow issue should be also gone

Thanks again for your time spent reviewing my theme.

comment:6 follow-up: ThemeZee9 months ago

As I understand the requirements, themes must not provide backward compatibility in the form of checking if default WordPress CORE functions (like register_sidebar) exist. But in this case it's no current WordPress function, it's an own function of my theme and the only reason for the function_exists wrapper is to allow developers to override the function in a child theme.

The most functions in the functions.php of the theme are wrapped with function_exists() calls to ensure child theme compatibility. In my opinion this should not violate the "forbidden backward compatibility for out-of-date WordPress versions" guideline.

comment:7 in reply to: ↑ 6 ; follow-up: ZGani9 months ago

Replying to ThemeZee:

As I understand the requirements, themes must not provide backward compatibility in the form of checking if default WordPress CORE functions (like register_sidebar) exist. But in this case it's no current WordPress function, it's an own function of my theme and the only reason for the function_exists wrapper is to allow developers to override the function in a child theme.

Sound argument and I agree on that

The most functions in the functions.php of the theme are wrapped with function_exists() calls to ensure child theme compatibility. In my opinion this should not violate the "forbidden backward compatibility for out-of-date WordPress versions" guideline.

I've see themes turned down i.e not approved on that technicality so I pointed it out. Will continue with the review and an Admin will do the final check and if they are happy with it then its all good if not then they'll just re-open the ticket for the amendment to be done.

comment:8 ThemeZee9 months ago

Okay, that sounds like a very good solution ;) Thank you for proceeding with the theme review.

comment:9 ZGani9 months ago

  • Status changed from reviewing to approved

All issues have been resolved.

comment:10 in reply to: ↑ 7 chipbennett8 months ago

Replying to ZGani:

Replying to ThemeZee:

As I understand the requirements, themes must not provide backward compatibility in the form of checking if default WordPress CORE functions (like register_sidebar) exist. But in this case it's no current WordPress function, it's an own function of my theme and the only reason for the function_exists wrapper is to allow developers to override the function in a child theme.

Sound argument and I agree on that

Just to clarify: there's nothing inherently wrong with function_exists(). It depends on how it is used. :)

Checking for pluggable functions is not the same as checking for backward compatibility. The Guidelines are silent on pluggable functions; they are perfectly fine to use in Themes.

comment:11 chipbennett8 months ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.