WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#14356 closed theme (live)

THEME: 2013 Blue - 1.0.8

Reported by: Joen Owned by: ZGani
Priority: new theme Keywords: theme-2013-blue child-theme parent-twentythirteen
Cc: joen@…

Change History (9)

#1 @Joen
4 years ago

Please note I received previous feedback on this ticket: http://themes.trac.wordpress.org/ticket/14335 which I have addressed here.

#2 @ZGani
4 years ago

  • Owner set to ZGani
  • Status changed from new to reviewing

#3 @ZGani
4 years ago

Just a couple of issues need addressing before approval.

Required:

  • Themes must declare copyright in the following format:
    Themename WordPress theme, Copyright (C) 2013 YOUR NAME or YOUR COMPANY NAME
    Themename WordPress theme is licensed under the GPL.
    
  • Please use a unique and theme relevant prefix for all custom functions - ex: function twentythirteen_greenblue_custom_header_setup() should be function 2013blue_greenblue_custom_header_setup()

Recommended:

  • Although the required copyright declaration can be added to the head of style.css I'd recommend using a readme.txt file to make the notation as well as add a changelog to it.
  • Adding extra functionality will make the theme more appealing to the masses :)

Zulf

#4 @Joen
4 years ago

Thanks for the feedback! I'll get to this asap and resubmit.

#5 follow-up: @Joen
4 years ago

Hi Zulf,

Here's version 1.0.8 of 2013 Blue: http://cl.ly/2x0M3S140F3r

I believe I have addressed all your concerns:

  • The copyright has been added to style.css.
  • I have changed the function prefixes to theme_2013blue_ — I believe I can't start a function name with a number.

My goal with this theme is to provide an alternate color option for Twenty Thirteen, and to give away a base theme that others can take and modify into other colors as well. It is *very much* a child theme, in that it doesn't change anything but the colors of Twenty Thirteen. It even links the base Twenty Thirteen stylesheet. As such, the features of the parent theme remain intact.

If this update satisfies the requirements, I hope that if I make similar changes to the three other color options I have ready, those reviews should be less of a burden on your time? Anything else I can do to help you? Thanks for the review Zulf!

#6 in reply to: ↑ 5 @ZGani
4 years ago

  • Keywords changed from theme-2013-blue, child-theme, parent-twentythirteen to theme-2013-blue child-theme, parent-twentythirteen

Replying to Joen:

Hi Zulf,

Here's version 1.0.8 of 2013 Blue: http://cl.ly/2x0M3S140F3r

You'll have to upload the revised version here: http://wordpress.org/themes/upload/ - be sure to bump up the version though

I believe I have addressed all your concerns:

  • The copyright has been added to style.css.
  • I have changed the function prefixes to theme_2013blue_ — I believe I can't start a function name with a number.

    That looks fine.

My goal with this theme is to provide an alternate color option for Twenty Thirteen, and to give away a base theme that others can take and modify into other colors as well. It is *very much* a child theme, in that it doesn't change anything but the colors of Twenty Thirteen. It even links the base Twenty Thirteen stylesheet. As such, the features of the parent theme remain intact.

As long as the child theme adds/includes a significant change to the parent theme then it is acceptable.

If this update satisfies the requirements, I hope that if I make similar changes to the three other color options I have ready, those reviews should be less of a burden on your time? Anything else I can do to help you?

I'll run through the review once more when you have re-uploaded the theme and all being well we should have an approval on this one. But do bare in mind that the Theme Review Admins have the final say once they give the theme a once over for quality assurance.

Once this is live we can proceed with other in the hope of achieving similar results with minimal requirements to change and resubmissions :)

Thanks for the review Zulf!

You are most welcome and thanks for contributing to the community.

#8 @ZGani
4 years ago

  • Keywords changed from theme-2013-blue child-theme, parent-twentythirteen to theme-2013-blue child-theme parent-twentythirteen
  • Status changed from reviewing to approved

All raised issues have been resolved.

#9 @emiluzelac
4 years ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.