WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 6 months ago

#14515 closed theme (live)

THEME: Irex Lite - 1.0.5

Reported by: tikendramaitry Owned by: alex27
Priority: new theme Keywords: theme-irex-lite
Cc: tikendramaitry@…

Description

Irex Lite - 1.0.0

Irex Lite is a simple, minimal, responsive, easy to use, one click install, beautiful and Elegent WordPress Theme with Easy Custom Admin Options Created by SketchThemes.com. Using Irex Lite theme options any one can easily customize this theme according to their need. You can use your own Logo, logo alt text, custom favicon, you can add social links, rss feed to homepage, you can use own copyright text etc. And all this information can be entered using Irex Lite Theme Options Panel. You have to just set the content from the Irex Lite Themes Options Panel and it'll be up ready to use..

Theme URL - http://www.sketchthemes.com/themes/irex-full-width-wordpress-theme/
Author URL - http://www.sketchthemes.com/

SVN - http://themes.svn.wordpress.org/irex-lite/1.0.0
ZIP - http://wordpress.org/themes/download/irex-lite.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/irex-lite/1.0.0/screenshot.png

Change History (23)

comment:1 alex277 months ago

  • Owner set to alex27
  • Status changed from new to reviewing

comment:2 follow-up: alex277 months ago

Hello! I found a couple of issues with your theme:

  • page title - you should provide means to display site title (and description optionally) as/instead of website logo. It's fairly unlikely that users will want to use theme name and generic slogan as logo, and not everyone has logo image.
  • ordered and unordered lists must have styling (appropriate bullets or numbers),
  • there should be a way to disable social icons. What if someone doens't use one of them? Icons are displayed even if social media url is empty.
  • error "Failed to load resource: the server responded with a status of 404 (Not Found)" for file irex-lite/js/jflickrfeed.min.js
  • error "Failed to load resource: the server responded with a status of 404 (Not Found)" for file irex-lite/css/hover.css
  • super long post title overflows container (look at the post Case Edge: Post with super duper long title from Theme Unit Test Data)
  • all functions and global variables must use theme specific prefix (please go through sketch-functions.php and ALL other files!)
  • I was not able to display slider, even though I created slides in theme options. Are there additional steps to complete to display slider?

Please fix those issues first and reupload. I'll leave this ticket open for another two days or so.

comment:3 themetracbot7 months ago

  • Summary changed from THEME: Irex Lite - 1.0.0 to THEME: Irex Lite - 1.0.1

Irex Lite - 1.0.1

Irex Lite is a simple, minimal, responsive, easy to use, one click install, beautiful and Elegent WordPress Theme with Easy Custom Admin Options Created by SketchThemes.com. Using Irex Lite theme options any one can easily customize this theme according to their need. You can use your own Logo, logo alt text, custom favicon, you can add social links, rss feed to homepage, you can use own copyright text etc. And all this information can be entered using Irex Lite Theme Options Panel. You have to just set the content from the Irex Lite Themes Options Panel and it'll be up ready to use..

Theme URL - http://www.sketchthemes.com/themes/irex-full-width-wordpress-theme/
Author URL - http://www.sketchthemes.com/

SVN - http://themes.svn.wordpress.org/irex-lite/1.0.1
ZIP - http://wordpress.org/themes/download/irex-lite.1.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/irex-lite/1.0.0&new_path=/irex-lite/1.0.1

History:


https://themes.svn.wordpress.org/irex-lite/1.0.1/screenshot.png

comment:4 in reply to: ↑ 2 tikendramaitry7 months ago

Replying to alex27:
Hi Alex,

Thanks for taking your precious time for reviewing my theme.
I have addressed all the issues you have mentioned in your review.
Uploaded new version of theme, please let me know if you see/have any further issues/queries in it.

Best,
Tikendra

Hello! I found a couple of issues with your theme:

  • page title - you should provide means to display site title (and description optionally) as/instead of website logo. It's fairly unlikely that users will want to use theme name and generic slogan as logo, and not everyone has logo image.

    Fixed

  • ordered and unordered lists must have styling (appropriate bullets or numbers),

    Fixed

  • there should be a way to disable social icons. What if someone doens't use one of them? Icons are displayed even if social media url is empty.

    Fixed

  • error "Failed to load resource: the server responded with a status of 404 (Not Found)" for file irex-lite/js/jflickrfeed.min.js

    Removed this file

  • error "Failed to load resource: the server responded with a status of 404 (Not Found)" for file irex-lite/css/hover.css

    Removed this file

  • super long post title overflows container (look at the post Case Edge: Post with super duper long title from Theme Unit Test Data)

    Fixed

  • all functions and global variables must use theme specific prefix (please go through sketch-functions.php and ALL other files!)

    Fixed

  • I was not able to display slider, even though I created slides in theme options. Are there additional steps to complete to display slider?

    Please set front page from WP reading settings for displaying slider(as this is implemented on front-page.php).

Please fix those issues first and reupload. I'll leave this ticket open for another two days or so.

comment:5 follow-up: alex277 months ago

Sorry about the delay! There are some outstanding issues though:

  • all functions and global variables must use theme specific prefix. I found this function is_pagetemplate_active round_num, skebggallery_backend_scripts etc., and you have two global variables: $shortname and $themename without prefix. Please check all your files, there is more!
  • all styles and scripts should be enqueued with wp_enqueue_scripts (see fonts sketch-enqueue.php)

comment:6 follow-up: alex277 months ago

One more thing. All items listed below must be called from a function callback hooked to the after_setup_theme action:

register_nav_menu
load_theme_textdomain
add_theme_support
set_post_thumbnail_size
add_image_size

comment:7 themetracbot7 months ago

  • Summary changed from THEME: Irex Lite - 1.0.1 to THEME: Irex Lite - 1.0.2

Irex Lite - 1.0.2

Irex Lite is a simple, minimal, responsive, easy to use, one click install, beautiful and Elegent WordPress Theme with Easy Custom Admin Options Created by SketchThemes.com. Using Irex Lite theme options any one can easily customize this theme according to their need. You can use your own Logo, logo alt text, custom favicon, you can add social links, rss feed to homepage, you can use own copyright text etc. And all this information can be entered using Irex Lite Theme Options Panel. You have to just set the content from the Irex Lite Themes Options Panel and it'll be up ready to use..

Theme URL - http://www.sketchthemes.com/themes/irex-full-width-wordpress-theme/
Author URL - http://www.sketchthemes.com/

SVN - http://themes.svn.wordpress.org/irex-lite/1.0.2
ZIP - http://wordpress.org/themes/download/irex-lite.1.0.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/irex-lite/1.0.1&new_path=/irex-lite/1.0.2

History:


https://themes.svn.wordpress.org/irex-lite/1.0.2/screenshot.png

comment:8 in reply to: ↑ 5 tikendramaitry7 months ago

Replying to alex27:

Sorry about the delay! There are some outstanding issues though:

  • all functions and global variables must use theme specific prefix. I found this function is_pagetemplate_active round_num, skebggallery_backend_scripts etc., and you have two global variables: $shortname and $themename without prefix. Please check all your files, there is more!

    Fixed this

  • all styles and scripts should be enqueued with wp_enqueue_scripts (see fonts sketch-enqueue.php)

    Fixed this

comment:9 in reply to: ↑ 6 tikendramaitry7 months ago

Replying to alex27:

Hi Alex,
Thanks for taking your precious time in reviewing my theme.
I have gone through and addressed the issues/queries you have reported.
But please go through the below issues you have reported once again carefully as these all are already done correctly(the way your have mentioned) in previous uploaded version.

One more thing. All items listed below must be called from a function callback hooked to the after_setup_theme action:

register_nav_menu
load_theme_textdomain
add_theme_support
set_post_thumbnail_size
add_image_size

For your reference:

Flie function.php line no. 51
register_nav_menu

Flie function.php line no. 66
load_theme_textdomain 

Flie SketchBoard\functions\sketch-theme-support.php line no. 27
add_theme_support

Flie SketchBoard\functions\sketch-theme-support.php line no. 31
set_post_thumbnail_size

Flie SketchBoard\functions\sketch-theme-support.php line no. 29
add_image_size

Once again thank you for your precious time.
Please let me know if you still have any query/confusion/question, I would love to answer them. :)

Best,
Tikendra

comment:10 follow-up: alex277 months ago

You misunderstood. I know you have all these functions. The problem is, those are scattered among a couple of separate functions. Instead those should be put into one setup function hooked into after_setup_theme action. Please see the default Twenty Thirteen theme as example and see twentythirteen_setup() function. This is how it should be.

comment:11 in reply to: ↑ 10 tikendramaitry7 months ago

Replying to alex27:

You misunderstood. I know you have all these functions. The problem is, those are scattered among a couple of separate functions. Instead those should be put into one setup function hooked into after_setup_theme action. Please see the default Twenty Thirteen theme as example and see twentythirteen_setup() function. This is how it should be.

Hi Alex,

Got you this time. Is there something else to fix.
If it need some more fixes please let me know.
So that I can fix them up and upload final version of theme.

Best,
Tiknedra

comment:12 follow-up: alex277 months ago

I still can see a lot of functions prefixed with skebggallery. Is this some kind of library?

comment:13 in reply to: ↑ 12 tikendramaitry7 months ago

Replying to alex27:

I still can see a lot of functions prefixed with skebggallery. Is this some kind of library?

Yes that is a separate library. And its not possible to change prefix of that library. I have used that in my already approved theme http://wordpress.org/themes/bizstudio-lite also.

comment:14 themetracbot7 months ago

  • Summary changed from THEME: Irex Lite - 1.0.2 to THEME: Irex Lite - 1.0.3

Irex Lite - 1.0.3

Irex Lite is a simple, minimal, responsive, easy to use, one click install, beautiful and Elegent WordPress Theme with Easy Custom Admin Options Created by SketchThemes.com. Using Irex Lite theme options any one can easily customize this theme according to their need. You can use your own Logo, logo alt text, custom favicon, you can add social links, rss feed to homepage, you can use own copyright text etc. And all this information can be entered using Irex Lite Theme Options Panel. You have to just set the content from the Irex Lite Themes Options Panel and it'll be up ready to use..

Theme URL - http://www.sketchthemes.com/themes/irex-full-width-wordpress-theme/
Author URL - http://www.sketchthemes.com/

SVN - http://themes.svn.wordpress.org/irex-lite/1.0.3
ZIP - http://wordpress.org/themes/download/irex-lite.1.0.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/irex-lite/1.0.2&new_path=/irex-lite/1.0.3

History:


https://themes.svn.wordpress.org/irex-lite/1.0.3/screenshot.png

comment:15 alex277 months ago

In theme options you have default "Logo ALT Text" set to 'sketch themes' - this should be empty or default to website name. This is the last thing I found. After that I cam mark this theme as approved.

comment:16 themetracbot7 months ago

  • Summary changed from THEME: Irex Lite - 1.0.3 to THEME: Irex Lite - 1.0.4

Irex Lite - 1.0.4

Irex Lite is a simple, minimal, responsive, easy to use, one click install, beautiful and Elegent WordPress Theme with Easy Custom Admin Options Created by SketchThemes.com. Using Irex Lite theme options any one can easily customize this theme according to their need. You can use your own Logo, logo alt text, custom favicon, you can add social links, rss feed to homepage, you can use own copyright text etc. And all this information can be entered using Irex Lite Theme Options Panel. You have to just set the content from the Irex Lite Themes Options Panel and it'll be up ready to use..

Theme URL - http://www.sketchthemes.com/themes/irex-full-width-wordpress-theme/
Author URL - http://www.sketchthemes.com/

SVN - http://themes.svn.wordpress.org/irex-lite/1.0.4
ZIP - http://wordpress.org/themes/download/irex-lite.1.0.4.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/irex-lite/1.0.3&new_path=/irex-lite/1.0.4

History:


https://themes.svn.wordpress.org/irex-lite/1.0.4/screenshot.png

comment:17 themetracbot7 months ago

  • Summary changed from THEME: Irex Lite - 1.0.4 to THEME: Irex Lite - 1.0.5

Irex Lite - 1.0.5

Irex is a responsive business & portfolio theme which offers a powerful Options Set to customize it to your own needs. Irex can be used for personal as well as corporate websites. It is simple and beautiful with numerous theme options like two different layout option(full width and with sidebar), 3 widget areas, custom follow us and contact widget, Logo, logo alt text, custom favicon, social links, rss feed button, custom copyright text and many more. It is compatible with various popular plugins like All in One SEO Pack, WP Super Cache, Contact Form 7 etc. Irex is one click install and translation ready as well.

Theme URL - http://www.sketchthemes.com/themes/irex-full-width-wordpress-theme/
Author URL - http://www.sketchthemes.com/

SVN - http://themes.svn.wordpress.org/irex-lite/1.0.5
ZIP - http://wordpress.org/themes/download/irex-lite.1.0.5.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/irex-lite/1.0.4&new_path=/irex-lite/1.0.5

History:


https://themes.svn.wordpress.org/irex-lite/1.0.5/screenshot.png

comment:18 alex277 months ago

  • Status changed from reviewing to approved

Ok, all previous issues have been fixed, marking the theme as approved.

comment:19 follow-up: chipbennett6 months ago

  • Status changed from approved to reopened

Per this page, your commercial Themes sold under the standard license cannot be used on unlimited domains. Please clarify, as this is a non-GPL-compatible use restriction.

Also, please clarify the differences between the free and commercial versions of the Theme.

comment:20 chipbennett6 months ago

  • Status changed from reopened to reviewing

comment:21 in reply to: ↑ 19 tikendramaitry6 months ago

Replying to chipbennett:

Hi Chip,

Thanks for double cross check. :)

Per this page, your commercial Themes sold under the standard license cannot be used on unlimited domains. Please clarify, as this is a non-GPL-compatible use restriction.

Corrected my mistake. corrected page.

Also, please clarify the differences between the free and commercial versions of the Theme.

Here is the differences between the free and commercial versions of the Theme theme comparison page.

Please let me know if there is something else which need my concern.

Best,
Tikendra

comment:22 alex276 months ago

  • Status changed from reviewing to approved

I think this is sufficient, with explicit explanation in terms of service.

comment:23 emiluzelac6 months ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.