WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 6 months ago

Last modified 5 months ago

#14648 closed theme (live)

THEME: Avedon - 1.09

Reported by: haeckdesign Owned by: ZGani
Priority: previously reviewed Keywords: theme-avedon
Cc: inbox@…

Description

Avedon - 1.06

A simple bootstrap based Wordpress theme, minimally coded, w/ plenty of bells and whistles.

Theme URL - http://code.google.com/p/avedon/
Author URL - http://haeckdesign.com/

SVN - http://themes.svn.wordpress.org/avedon/1.06
ZIP - http://wordpress.org/themes/download/avedon.1.06.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/avedon/1.05&new_path=/avedon/1.06

History:

Ticket Summary Status Resolution Owner
#13906 THEME: Avedon Theme - 1.0 closed not-approved ZGani
#13919 THEME: Avedon - 1.05 closed not-approved shelob9
#14648 THEME: Avedon - 1.09 closed live ZGani

(this ticket)

#15515 THEME: Avedon - 1.12 closed not-approved nielse63
#15820 THEME: Avedon - 1.14 closed live tskk
#16325 THEME: Avedon - 1.15 closed live tskk
#16740 THEME: Avedon - 1.16 closed live robin90
#16881 THEME: Avedon - 1.17 closed live tskk


https://themes.svn.wordpress.org/avedon/1.06/screenshot.png

Attachments (1)

YouTubeEmbedHeight.png (75.1 KB) - added by ZGani 7 months ago.
YouTube embed code is not rendered correctly

Download all attachments as: .zip

Change History (24)

comment:1 follow-up: ZGani7 months ago

  • Owner set to ZGani
  • Status changed from new to reviewing

comment:2 ZGani7 months ago

Previously unresolved issues have been resolved with a few exceptions. Following needs addresing before the theme can be approved.

Required:

  • Please include the unminified versions of all javascripts and stylesheets file used in the theme - these are required for verification and reference purposes. In addition the end use is free to edit the files as they see fit to meet their needs - your readme file seems to place a restriction on this as well as the support they can expect.
  • Menu system does not support dropdown/levels - please make a note of this limitation in the theme's documents.
  • Favicons if facilitated must be off by default and user configurable - you have not provided a way for the user to configure this.
  • Please remove the @package WordPress from theme's files - this is reserved for resources bundled with WordPress.
  • Remove the rss2_url call in header.php
  • You do not need to register resources bundled with the theme, simply enqueue them.
  • Please make a notation in the readme that the work is a derivative or part thereof and include the license/copyright of the original work - I see code from Rachel Baker's BootstrapWP in functions.php.
  • Explicitly state the license, copyright and source of the fonts avedon - even if it was created by you.

EDIT:

  • YouTube embed code is not rendered correctly as per guidelines - see attachment.
Last edited 7 months ago by ZGani (previous) (diff)

ZGani7 months ago

YouTube embed code is not rendered correctly

comment:3 ZGani7 months ago

Hello haeckdesign,

Any ideas when I can expect a revised version or should I close the ticket as not approved till you can resubmit the theme?

comment:4 haeckdesign7 months ago

Out of town this weekend - I'll have it in within the next 24.

comment:5 themetracbot7 months ago

  • Summary changed from THEME: Avedon - 1.06 to THEME: Avedon - 1.07

Avedon - 1.07

A simple bootstrap based Wordpress theme, minimally coded, w/ plenty of bells and whistles.

Theme URL - http://code.google.com/p/avedon/
Author URL - http://haeckdesign.com/

SVN - http://themes.svn.wordpress.org/avedon/1.07
ZIP - http://wordpress.org/themes/download/avedon.1.07.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/avedon/1.06&new_path=/avedon/1.07

History:

Ticket Summary Status Resolution Owner
#13906 THEME: Avedon Theme - 1.0 closed not-approved ZGani
#13919 THEME: Avedon - 1.05 closed not-approved shelob9
#14648 THEME: Avedon - 1.09 closed live ZGani

(this ticket)

#15515 THEME: Avedon - 1.12 closed not-approved nielse63
#15820 THEME: Avedon - 1.14 closed live tskk
#16325 THEME: Avedon - 1.15 closed live tskk
#16740 THEME: Avedon - 1.16 closed live robin90
#16881 THEME: Avedon - 1.17 closed live tskk


https://themes.svn.wordpress.org/avedon/1.07/screenshot.png

comment:6 haeckdesign7 months ago

I included notes from the fixes in case it helps...

Please include the unminified versions of all javascripts: Included Unminified js and decompressed the css. Was trying to draw a distinction between functional / project specific support - Reworded it (and removed the uncompressed css/js note).
Menu system does not support dropdown/levels: Removed "mini-bootstrap" option (since it may have caused conflict) and included note on Theme Options page.
Favicons if facilitated must be off by default and user configurable: Guessing that means including a image/editor and ico converter… So, I've removed it.
Remove the @package: Done
Remove the rss2_url: Done
Enqueue scripts / don't register: Done
Credit BootstrapWP: Done
Explicitly state the license, copyright and source of the fonts: Done (also recompiled icons to make sure I credited all icons included)
YouTube embed code: Adjusted in CSS

I also moved the full license info into the license.txt file. I included the minimal stuff in readme.txt, then mentioned that full license info is in the license.txt file. If that isn't proper / suggested just let me know and I'll adjust as needed.

Hopefully that covers what you've noted on the functionality side. I'm currently going through and cleaning up the css a bit, but everything seems to be testing properly. Thank you for your help.

Last edited 7 months ago by haeckdesign (previous) (diff)

comment:7 ZGani7 months ago

All looks good with a couple of exceptions.

You've noted the license for Font Awesome as "CC BY 3.0 - http://creativecommons.org/licenses/by/3.0/" - This is not the correct license. The correct license is SIL OFL/MIT. See bottom of: http://fortawesome.github.io/Font-Awesome/, the CC By 3 is for the site documentation and not for the fonts or the code.

For the IconMoon set I can not locate the license details on the site and you have noted it as being licensed under CC BY 3.0 - http://creativecommons.org/licenses/by/3.0/ - this license is not GPL compatible.

comment:8 themetracbot7 months ago

  • Summary changed from THEME: Avedon - 1.07 to THEME: Avedon - 1.08

Avedon - 1.08

A simple bootstrap based Wordpress theme, minimally coded, w/ plenty of bells and whistles.

Theme URL - http://code.google.com/p/avedon/
Author URL - http://haeckdesign.com/

SVN - http://themes.svn.wordpress.org/avedon/1.08
ZIP - http://wordpress.org/themes/download/avedon.1.08.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/avedon/1.07&new_path=/avedon/1.08

History:

Ticket Summary Status Resolution Owner
#13906 THEME: Avedon Theme - 1.0 closed not-approved ZGani
#13919 THEME: Avedon - 1.05 closed not-approved shelob9
#14648 THEME: Avedon - 1.09 closed live ZGani

(this ticket)

#15515 THEME: Avedon - 1.12 closed not-approved nielse63
#15820 THEME: Avedon - 1.14 closed live tskk
#16325 THEME: Avedon - 1.15 closed live tskk
#16740 THEME: Avedon - 1.16 closed live robin90
#16881 THEME: Avedon - 1.17 closed live tskk


https://themes.svn.wordpress.org/avedon/1.08/screenshot.png

comment:9 haeckdesign7 months ago

I recompiled the fonts only using the "Font Awesome" icons and the social icons (which I uploaded myself). I noted both (since you mentioned that all had to be explicitly stated). If I need to give those icons their own webpage just let me know. Thanks again.

comment:10 ZGani7 months ago

  • Status changed from reviewing to approved

There's no need for the icons' own webpage unless you wish to make the publicly available separate from the theme.

You are still noting the Font Awesome license as CC By 3 where else the actual license is SIL OFL/MIT.

Icon Set:	Font Awesome - http://fortawesome.github.com/Font-Awesome/
License:	CC BY 3.0 - http://creativecommons.org/licenses/by/3.0/
Copyright:	Dave Gandy - https://twitter.com/davegandy

The Admins are aware of the correct license so we should be good to go but be sure to change it in the next revision in order to avoid misunderstandings and confusing end users.

comment:11 haeckdesign6 months ago

Apologies - Just updated it now. Thanks again for your help.

comment:12 chipbennett6 months ago

  • Status changed from approved to reopened

The Admins certainly are aware of the FontAwesome license, but end users very well may not be. Let's fix that one up, and then we can push the Theme live.

Also, recommended but not required: since minified versions of CSS are still human-readable, it is not required to distribute them; but please consider not locking the non-minified versions behind the commercial paywall.

comment:13 chipbennett6 months ago

  • Status changed from reopened to reviewing

comment:14 haeckdesign6 months ago

Understood - I'll get that license info adjusted, do a check on the css (I found a couple icon names that needed to be updated), and I'll get that uploaded this evening. Thank you for your help.

comment:15 themetracbot6 months ago

  • Summary changed from THEME: Avedon - 1.08 to THEME: Avedon - 1.09

Avedon - 1.09

A simple bootstrap based Wordpress theme, minimally coded, w/ plenty of bells and whistles.

Theme URL - http://code.google.com/p/avedon/
Author URL - http://haeckdesign.com/

SVN - http://themes.svn.wordpress.org/avedon/1.09
ZIP - http://wordpress.org/themes/download/avedon.1.09.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/avedon/1.08&new_path=/avedon/1.09

History:

Ticket Summary Status Resolution Owner
#13906 THEME: Avedon Theme - 1.0 closed not-approved ZGani
#13919 THEME: Avedon - 1.05 closed not-approved shelob9
#14648 THEME: Avedon - 1.09 closed live ZGani

(this ticket)

#15515 THEME: Avedon - 1.12 closed not-approved nielse63
#15820 THEME: Avedon - 1.14 closed live tskk
#16325 THEME: Avedon - 1.15 closed live tskk
#16740 THEME: Avedon - 1.16 closed live robin90
#16881 THEME: Avedon - 1.17 closed live tskk


https://themes.svn.wordpress.org/avedon/1.09/screenshot.png

comment:16 ZGani6 months ago

  • Status changed from reviewing to approved

FontAwesome license issue has been resolved - no other outstanding issues.

comment:17 Otto426 months ago

  • Resolution set to live
  • Status changed from approved to closed

comment:18 in reply to: ↑ 1 haeckdesign6 months ago

Replying to ZGani:

I had one quick question - I've updated the theme to Bootstrap3 and before I uploaded it I just wanted to verify that the screenshot I'm including is appropriate. Is the rule that it has to be a representation of the stock theme and nothing else or that it must be the theme and that alone? The reason I ask is that the previous picture is the plainest version possible, but it'd be nice to include the background image since that's a feature of the theme.

Thanks in advance and apologies if that's a dumb question, I'm just trying to make sure I'm making improvements deliberately and following all the rules.

comment:19 Otto426 months ago

The guideline for screenshots is here:
http://make.wordpress.org/themes/guidelines/guidelines-theme-check/

It reads:
"Should be a “reasonable facsimile” of the Theme after it is initially activated with default options"

The intent of this is that the theme screenshot should be representative of the theme and how it is intended to look. Mainly, the purpose here is to disallow use of the screenshot for marketing purposes, or to show things that are not the themes themselves (logos, branding, etc).

No, it doesn't have to be a absolute stock install, because the point of themes is to add design to the site, and a screenshot should showcase that design in the best possible way while still being something that is representative of the theme and what it will look like when a user installs it on their site.

There is some discussion on this that may clarify matters here:
http://make.wordpress.org/themes/2013/01/17/clarification-of-screenshot-guidelines/

comment:20 haeckdesign6 months ago

Couldn't have asked for a better answer - Thank you.

comment:21 haeckdesign5 months ago

Quick question - Should I continue uploading revisions as before or is there a better method?

comment:22 Otto425 months ago

There's only one way to upload themes, and doing so will create a ticket here and it will go through review as per normal. Updates tend to be much quicker though, since only the changes need to be examined.

comment:23 haeckdesign5 months ago

Understood - Thank you.

Note: See TracTickets for help on using tickets.