WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 6 months ago

#14655 closed theme (live)

THEME: Adelle - 13.10

Reported by: bluchic Owned by: ZGani
Priority: previously reviewed Keywords: theme-adelle
Cc: hello@…

Description

Attachments (1)

ThickboxLoadsEntirePage.png (208.3 KB) - added by ZGani 7 months ago.
Thick should load only the image

Download all attachments as: .zip

Change History (11)

comment:1 themetracbot7 months ago

  • Summary changed from THEME: Adelle - 13.09 to THEME: Adelle - 13.09.03

comment:2 themetracbot7 months ago

  • Summary changed from THEME: Adelle - 13.09.03 to THEME: Adelle - 13.09.5

comment:3 ZGani7 months ago

  • Owner set to ZGani
  • Status changed from new to reviewing

ZGani7 months ago

Thick should load only the image

comment:4 follow-up: ZGani7 months ago

  • Themes must not rely on external source (SVN) for required resources - All of the following items must be included and enqueued from with in the theme. These should be enqueued correctly and not hard coded in the head document.
    <!--[if lt IE 7]><script src="http://ie7-js.googlecode.com/svn/version/2.1(beta4)/IE7.js"></script><![endif]-->
    <!--[if lt IE 8]><script src="http://ie7-js.googlecode.com/svn/version/2.1(beta4)/IE8.js"></script><![endif]-->
    <!--[if lt IE 9]><script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script><![endif]-->
    <!--[if lt IE 9]><script src="http://css3-mediaqueries-js.googlecode.com/svn/trunk/css3-mediaqueries.js"></script><![endif]-->
    
  • Google fonts should be registered first before enqueueing.
  • adelle_theme_scripts() should be hooked to wp_enqueue_scripts() instead of wp_footer - this is the proper way of enqueueing scripts. Adding true to the array will automatically enqueue it in the footer.
  • Please remove if function exists wrapper from the following...
    add_image_size( 'post_thumb', 300, 200, true );
    add_theme_support( 'custom-background', array('default-color' => 'ffffff',) );
    if ( !function_exists('dynamic_sidebar')
    
  • Thickbox still does not function the way it should - it loads the entire page instead of the image. See attachment.

The above issues need fixing before the theme can be approved for inclusion in the repository.

comment:5 themetracbot7 months ago

  • Summary changed from THEME: Adelle - 13.09.5 to THEME: Adelle - 13.09.8

comment:6 in reply to: ↑ 4 bluchic7 months ago

Thank you very much for the guide! Update has been uploaded.

comment:7 ZGani7 months ago

Just a couple of issues remain from above feedback.

You still have if function exist wrapper on the following...
functions.php

add_theme_support( 'custom-background', array('default-color' => 'ffffff',) );

sidebar.php - use if is_active ('dynamic_sidebar') instead of

if ( !function_exists('dynamic_sidebar')

In addition, favicons if implemented must off by default and be user configurable - please amend this or remove the implementation altogether.

comment:8 themetracbot7 months ago

  • Summary changed from THEME: Adelle - 13.09.8 to THEME: Adelle - 13.10

comment:9 ZGani7 months ago

  • Status changed from reviewing to approved

All required issues have been resolved.

comment:10 chipbennett6 months ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.