WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#14720 closed theme (live)

THEME: Museum Core - 2.0.1

Reported by: jazzs3quence Owned by: alex27
Priority: theme update Keywords: theme-museum-core
Cc: chris@…

Description

Museum Core - 2.0

A simple WordPress theme/framework with support for post formats, thumbnails, background, header, menus and more...

Theme URL - http://www.museumthemes.com
Author URL - http://www.arcanepalette.com

SVN - http://themes.svn.wordpress.org/museum-core/2.0
ZIP - http://wordpress.org/themes/download/museum-core.2.0.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/museum-core/1.1.3.4&new_path=/museum-core/2.0

History:

Ticket Summary Status Resolution Owner
#6954 THEME: Museum Core - 1.0 closed not-approved chipbennett
#6979 THEME: Museum Core - 1.0.1 closed closed-newer-version-uploaded chipbennett
#6980 THEME: Museum Core - 1.0.2 closed not-approved Fingli
#7099 THEME: Museum Core - 1.0.3 closed not-approved kobenland
#7160 THEME: Museum Core - 1.0.4 closed not-approved garinungkadol
#7238 THEME: Museum Core - 1.0.5 closed closed-newer-version-uploaded sixhours
#7309 THEME: Museum Core - 1.0.6 closed live sixhours
#7452 THEME: Museum Core - 1.0.7 closed closed-newer-version-uploaded chipbennett
#7456 THEME: Museum Core - 1.0.7.1 closed live chipbennett
#7457 THEME: Museum Core - 1.0.7.2 closed live chipbennett
#7462 THEME: Museum Core - 1.0.8 closed closed-newer-version-uploaded kobenland
#7463 THEME: Museum Core - 1.0.8 closed closed-newer-version-uploaded kobenland
#7464 THEME: Museum Core - 1.0.8 closed live kobenland
#7559 THEME: Museum Core - 1.0.9 closed live sixhours
#7778 THEME: Museum Core - 1.1 closed live emiluzelac
#7852 THEME: Museum Core - 1.1.1 closed live kobenland
#7925 THEME: Museum Core - 1.1.2 closed live kobenland
#10635 THEME: Museum Core - 1.1.3 closed closed-newer-version-uploaded nishasingh
#10658 THEME: Museum Core - 1.1.3.1 closed closed-newer-version-uploaded nishasingh
#10678 THEME: Museum Core - 1.1.3.2 closed live nishasingh
#10831 THEME: Museum Core - 1.1.3.3 closed closed-newer-version-uploaded nishasingh
#10838 THEME: Museum Core - 1.1.3.4 closed live nishasingh
#14720 THEME: Museum Core - 2.0.1 closed live alex27

(this ticket)

#15083 THEME: Museum Core - 2.0.2 closed live tskk
#15611 THEME: Museum Core - 2.0.3 closed live emiluzelac
#17689 THEME: Museum Core - 2.1 closed live catchthemes
#19055 THEME: Museum Core - 2.1.1 closed live jcastaneda
#22618 THEME: Museum Core - 2.1.2 closed live karmatosed
#29031 THEME: Museum Core – 2.1.3 closed live Otto42
#29200 THEME: Museum Core – 2.1.4 closed live Otto42
#40630 THEME: Museum Core – 2.1.5 closed live themetracbot


https://themes.svn.wordpress.org/museum-core/2.0/screenshot.png

Change History (6)

#1 @alex27
4 years ago

  • Owner set to alex27
  • Status changed from new to reviewing

#2 @alex27
4 years ago

Hello! Since this is a major update a made thorough review, here's what I found:

  • Remove function_exists() conditional wrappers from calls to all functions added prior to WordPress 3.4 ( dynamic_sidebar )
  • wp_head() call has to be directly before closing </header>, same goes for wp_footer() and </body>
  • I found a global varaible without theme prefix $_post_format_chat_ids, and a lot of unprefixed public variables scattered through the files.
    Themes are required to use theme-slug ( or a reasonably unique slug) as a prefix for anything
    in the public namespace, including all custom function names, classes, hooks, public/global
    variables, database entries (Theme options, post custom metadata, etc.)
    
  • fix unescaped home_url() calls

#3 @jazzs3quence
4 years ago

Thanks for being thorough. Uploading updated version.

#4 @themetracbot
4 years ago

  • Summary changed from THEME: Museum Core - 2.0 to THEME: Museum Core - 2.0.1

Museum Core - 2.0.1

A simple WordPress theme/framework with support for post formats, thumbnails, background, header, menus and more...

Theme URL - http://www.museumthemes.com
Author URL - http://www.arcanepalette.com

SVN - http://themes.svn.wordpress.org/museum-core/2.0.1
ZIP - http://wordpress.org/themes/download/museum-core.2.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/museum-core/2.0&new_path=/museum-core/2.0.1

History:

Ticket Summary Status Resolution Owner
#6954 THEME: Museum Core - 1.0 closed not-approved chipbennett
#6979 THEME: Museum Core - 1.0.1 closed closed-newer-version-uploaded chipbennett
#6980 THEME: Museum Core - 1.0.2 closed not-approved Fingli
#7099 THEME: Museum Core - 1.0.3 closed not-approved kobenland
#7160 THEME: Museum Core - 1.0.4 closed not-approved garinungkadol
#7238 THEME: Museum Core - 1.0.5 closed closed-newer-version-uploaded sixhours
#7309 THEME: Museum Core - 1.0.6 closed live sixhours
#7452 THEME: Museum Core - 1.0.7 closed closed-newer-version-uploaded chipbennett
#7456 THEME: Museum Core - 1.0.7.1 closed live chipbennett
#7457 THEME: Museum Core - 1.0.7.2 closed live chipbennett
#7462 THEME: Museum Core - 1.0.8 closed closed-newer-version-uploaded kobenland
#7463 THEME: Museum Core - 1.0.8 closed closed-newer-version-uploaded kobenland
#7464 THEME: Museum Core - 1.0.8 closed live kobenland
#7559 THEME: Museum Core - 1.0.9 closed live sixhours
#7778 THEME: Museum Core - 1.1 closed live emiluzelac
#7852 THEME: Museum Core - 1.1.1 closed live kobenland
#7925 THEME: Museum Core - 1.1.2 closed live kobenland
#10635 THEME: Museum Core - 1.1.3 closed closed-newer-version-uploaded nishasingh
#10658 THEME: Museum Core - 1.1.3.1 closed closed-newer-version-uploaded nishasingh
#10678 THEME: Museum Core - 1.1.3.2 closed live nishasingh
#10831 THEME: Museum Core - 1.1.3.3 closed closed-newer-version-uploaded nishasingh
#10838 THEME: Museum Core - 1.1.3.4 closed live nishasingh
#14720 THEME: Museum Core - 2.0.1 closed live alex27

(this ticket)

#15083 THEME: Museum Core - 2.0.2 closed live tskk
#15611 THEME: Museum Core - 2.0.3 closed live emiluzelac
#17689 THEME: Museum Core - 2.1 closed live catchthemes
#19055 THEME: Museum Core - 2.1.1 closed live jcastaneda
#22618 THEME: Museum Core - 2.1.2 closed live karmatosed
#29031 THEME: Museum Core – 2.1.3 closed live Otto42
#29200 THEME: Museum Core – 2.1.4 closed live Otto42
#40630 THEME: Museum Core – 2.1.5 closed live themetracbot


https://themes.svn.wordpress.org/museum-core/2.0.1/screenshot.png

#5 @alex27
4 years ago

  • Status changed from reviewing to approved

All issues have been fixed. Marking theme as approved.

#6 @chipbennett
4 years ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.