WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 6 months ago

#14845 closed theme (closed-newer-version-uploaded)

THEME: OmegaTheme - 1.0

Reported by: stephenharris Owned by: alex27
Priority: new theme Keywords: theme-omegatheme
Cc: stephenh1988@…

Description

OmegaTheme - 1.0

Omega Theme is a lightweight and responsive theme, with a fluid grid system that adapts your website to mobile devices and the desktop or any

Theme URL - http://wp-event-organiser.com/extensions/omega-theme/
Author URL - http://stephenharris.info

SVN - http://themes.svn.wordpress.org/omegatheme/1.0
ZIP - http://wordpress.org/themes/download/omegatheme.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#14845 THEME: OmegaTheme - 1.0 closed closed-newer-version-uploaded alex27

(this ticket)

#14977 THEME: OmegaTheme - 1.0.1 closed not-approved alex27


https://themes.svn.wordpress.org/omegatheme/1.0/screenshot.png

Attachments (2)

omegatheme_clearingfloats.jpg (23.7 KB) - added by alex27 6 months ago.
omega.zip (198.7 KB) - added by stephenharris 6 months ago.

Download all attachments as: .zip

Change History (15)

comment:1 alex276 months ago

  • Owner set to alex27
  • Status changed from new to reviewing

comment:2 alex276 months ago

Hello!

I found a couple of issues with your theme:

CODE

  • All add_theme_support, add_image_size, add_nav_menu, register_nav_menus and load_theme_textdomain should be setup and registered within a theme specific setup function tied to the after_setup_theme action.
  • All sidebars/widgets should be registered via widgets_init callback.
  • Please remove <meta name="description" from header.php
  • Please remove <?php bloginfo('name'); ?> from <title> element. To modify document title output, use wp_title filter.
  • Do not load scripts from CDN. To use html5.js script you need to package it with the theme.
  • Fix unescaped home_url() calls
  • By default your theme should display website name, as defined by te user, not your theme logo.

LAYOUT

  • super long post title overflows container (look at the post Case Edge: Post with super duper long title from Theme Unit Test Data)
  • theme fails clearing floats test (see screenshot)

Please fix mentioned issues and upload new version. I'll leave this ticket open for another 2-3 days.

comment:3 alex276 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Last edited 6 months ago by alex27 (previous) (diff)

stephenharris6 months ago

comment:4 stephenharris6 months ago

Hi Alex,

Thank you! I've fixed the issues you've highlighted above (apologies regarding the layout issues - I could have sworn that I had gone through all the test posts!).

I've attached the amended version.

Many thanks.

comment:5 chipbennett6 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

comment:6 chipbennett6 months ago

  • Status changed from reopened to reviewing

comment:7 chipbennett6 months ago

Please try to keep tickets open to allow for developers to submit fixes and continue the review - unless the issues are so egregious that review continuation would be unreasonable.

comment:8 alex276 months ago

I usually do that, must have closed wrong ticket.
Sorry!

comment:9 alex276 months ago

You must upload new version using theme uploader. I cannot review otherwise.

comment:10 stephenharris6 months ago

Thanks Alex, re-uploaded :).

comment:11 alex276 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

comment:12 chipbennett6 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

comment:13 chipbennett6 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reopened to closed

Let's use "closed-newer-version-uploaded" rather than "not-approved", for review continuation. :)

Note: See TracTickets for help on using tickets.