WordPress.org

Make WordPress Themes

#14885 closed theme (live)

THEME: Tesla - 1.04

Reported by: TeslaThemes Owned by: rohitink
Priority: previously reviewed Keywords: theme-tesla
Cc: hi@…, chipbennett

Description

Tesla - 1.02

Awesome theme for a Wordpress cretive website

Theme URL - http://teslathemes.com/doc/tesla/
Author URL - http://teslathemes.com/

SVN - http://themes.svn.wordpress.org/tesla/1.02
ZIP - http://wordpress.org/themes/download/tesla.1.02.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/tesla/1.01&new_path=/tesla/1.02

History:

Ticket Summary Status Resolution Owner
#12900 THEME: Tesla - 1.00 closed not-approved PankajAgarwal
#14278 THEME: Tesla - 1.01 closed not-approved ZGani
#14885 THEME: Tesla - 1.04 closed live rohitink

(this ticket)

#15624 THEME: Tesla - 1.07 closed live life.object
#19455 THEME: Tesla - 1.08 closed live imon Hasan


https://themes.svn.wordpress.org/tesla/1.02/screenshot.png

Change History (8)

comment:1 @rohitink19 months ago

  • Owner set to rohitink
  • Status changed from new to reviewing

comment:2 @rohitink19 months ago

  1. Your ThemeURI is not valid. It links to some general documentaiton, and is not related to the theme you submitted. You can leave it blank too.
  1. Analytics in Theme Options is not allowed. Its Plugin Territory.
  1. Excessive white space between the site title and content region.
  1. Very long words in sidebar overflow their container.
  1. Custom Nav menus upto 10 level deep, overflow the sidebar region.
  1. Nested Menus in Footer do now show up as intended. They are displayed flat. Some padding must be provided to distinguish between menu depths.
  1. You are using Bootstrap. Which means, your theme has to be under the GPL v3. Remove GPL v2 and add the v3 license.
  1. Create a readme.txt file, and state license for all the bundled resources with your theme. You can look into the readme.txt of one of my themes to see how its done.
  1. Escape all the social links in the header.php.
  1. The following PHP errors, are preventing further review of the theme.

PHP Errors:

Strict Standards: Declaration of Tesla_List_Pages_Walker::start_el() should be compatible with Walker::start_el(&$output, $object, $depth = 0, $args = Array, $current_object_id = 0) in ../wp-content/themes/tesla/functions.php on line 1440

Strict Standards: Declaration of Tesla_Nav_Menu_Select_Walker::start_el() should be compatible with Walker::start_el(&$output, $object, $depth = 0, $args = Array, $current_object_id = 0) in ../wp-content/themes/tesla/functions.php on line 1466

Strict Standards: Declaration of Tesla_Nav_Menu_Select_Walker::end_el() should be compatible with Walker::end_el(&$output, $object, $depth = 0, $args = Array) in ../Theme Reviews/wp-content/themes/tesla/functions.php on line 1466

Strict Standards: Declaration of Tesla_List_Pages_Select_Walker::start_el() should be compatible with Walker::start_el(&$output, $object, $depth = 0, $args = Array, $current_object_id = 0) in ../wp-content/themes/tesla/functions.php on line 1494

Strict Standards: Declaration of Tesla_List_Pages_Select_Walker::end_el() should be compatible with Walker::end_el(&$output, $object, $depth = 0, $args = Array) in /../wp-content/themes/tesla/functions.php on line 1494

Please address all the above issues before re-submitting the theme. if you need any help, ask for it.

comment:3 @themetracbot19 months ago

  • Summary changed from THEME: Tesla - 1.02 to THEME: Tesla - 1.03

Tesla - 1.03

Awesome theme for a Wordpress cretive website

Theme URL -
Author URL - http://teslathemes.com/

SVN - http://themes.svn.wordpress.org/tesla/1.03
ZIP - http://wordpress.org/themes/download/tesla.1.03.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/tesla/1.02&new_path=/tesla/1.03

History:

Ticket Summary Status Resolution Owner
#12900 THEME: Tesla - 1.00 closed not-approved PankajAgarwal
#14278 THEME: Tesla - 1.01 closed not-approved ZGani
#14885 THEME: Tesla - 1.04 closed live rohitink

(this ticket)

#15624 THEME: Tesla - 1.07 closed live life.object
#19455 THEME: Tesla - 1.08 closed live imon Hasan


https://themes.svn.wordpress.org/tesla/1.03/screenshot.png

comment:4 @rohitink19 months ago

PHP Errors still be generated:

  1. Test your theme with WP_DEBUG enabled.
Strict Standards: Declaration of Tesla_List_Pages_Walker::start_el() should be compatible with Walker::start_el(&$output, $object, $depth = 0, $args = Array, $current_object_id = 0) in ../wp-content/themes/tesla/functions.php on line 1325
  1. Still a Lot of blank white space between content and header region.

All other issues have been solved.

comment:5 @themetracbot19 months ago

  • Summary changed from THEME: Tesla - 1.03 to THEME: Tesla - 1.04

Tesla - 1.04

Awesome theme for a Wordpress cretive website

Theme URL -
Author URL - http://teslathemes.com/

SVN - http://themes.svn.wordpress.org/tesla/1.04
ZIP - http://wordpress.org/themes/download/tesla.1.04.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/tesla/1.03&new_path=/tesla/1.04

History:

Ticket Summary Status Resolution Owner
#12900 THEME: Tesla - 1.00 closed not-approved PankajAgarwal
#14278 THEME: Tesla - 1.01 closed not-approved ZGani
#14885 THEME: Tesla - 1.04 closed live rohitink

(this ticket)

#15624 THEME: Tesla - 1.07 closed live life.object
#19455 THEME: Tesla - 1.08 closed live imon Hasan


https://themes.svn.wordpress.org/tesla/1.04/screenshot.png

comment:6 @rohitink19 months ago

  • Status changed from reviewing to approved

All issues with this theme have been resolved. Marking as approved.

comment:7 @emiluzelac19 months ago

  • Cc chipbennett added

I don't think that we can make license restrictions like http://teslathemes.com/doc/tesla/

Licensing Terms: Please be advised, in order to use the theme in a legal manner, you need to purchase a separate license for each domain you are going to use the theme on.

A single license is limited to a single domain/application.

comment:8 @emiluzelac19 months ago

  • Resolution set to live
  • Status changed from approved to closed

Thanks for changing the license and for the future references please note the ticket that license was changed.

Note: See TracTickets for help on using tickets.