WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 6 months ago

#15073 closed theme (live)

THEME: Writr - 1.0.5

Reported by: automattic Owned by: ZGani
Priority: new theme Keywords: theme-writr
Cc: themes@…, chipbennett, lancewillett

Description

Change History (10)

comment:1 ZGani6 months ago

  • Owner set to ZGani
  • Status changed from new to reviewing

comment:2 ZGani6 months ago

  • Cc chipbennett added

Code is perfect.

Theme Unit test is good.

I just have one concern on the Multisite theme updater and how will that work in conjunction with WordPress.org updates?

As far as I know and understand, WordPress.org is a hosting setup - themes are hosted and updated via WordPress.org but with this theme it seems as though on a multisite the update will happen from WordPress.com if the included plugin is installed and activated, is that correct?

As there's nothing to test with this setup yet, will these updates (if approved) be restricted to the super admin or are they open to the individual blog admins?

@Chip, when theme is installed on a multisite it offer the installation of the WordPress.com theme updater plugin - is this something that is allowed?

comment:3 chipbennett6 months ago

  • Cc lancewillett added

Well, this is novel!

@lancewillett, can you provide any insight here?

SOP for WPORG-hosted Themes is that they must be updated via WPORG. Was this added intentionally, or maybe left in accidentally?

comment:4 follow-up: lancewillett6 months ago

Yes, that was very much NOT intentional. Will get it sorted on our end and submit a new version soon. Thanks for the heads-up.

comment:5 in reply to: ↑ 4 ZGani6 months ago

Replying to lancewillett:

Yes, that was very much NOT intentional. Will get it sorted on our end and submit a new version soon. Thanks for the heads-up.

Cool.
Can I also ask you to include the theme's copyright declaration in the revised version please. With those two items cleared we should be good to go for Approval :)

Thanks,
Zulf.

comment:6 themetracbot6 months ago

  • Summary changed from THEME: Writr - 1.0.1 to THEME: Writr - 1.0.4

comment:7 ZGani6 months ago

Plugin issue on multisite has been resolved - love the option for the extra width.

Required:

  • Themes must declare copyright - the declaration must be along the lines of or similar:
    Themename WordPress theme, Copyright (C) 2013 YOUR NAME or YOUR COMPANY NAME
    

Theme is ready for approval on re-submission with the correct copyright in place.

comment:8 themetracbot6 months ago

  • Summary changed from THEME: Writr - 1.0.4 to THEME: Writr - 1.0.5

comment:9 ZGani6 months ago

  • Status changed from reviewing to approved

All issues have been resolved.

comment:10 chipbennett6 months ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.