WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 5 months ago

#15258 closed theme (live)

THEME: B3 - 1.2.3

Reported by: andreyk Owned by: ZGani
Priority: new theme Keywords: theme-b3
Cc: andrey@…, chip@…

Description

B3 - 1.0

Responsive customizable theme based on Bootstrap 3 framework. Three widget areas, changeable colors and page look, export/import settings, translation ready.

Theme URL - http://andrey.ws/b3-theme
Author URL - http://andrey.ws/

SVN - http://themes.svn.wordpress.org/b3/1.0
ZIP - http://wordpress.org/themes/download/b3.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#15258 THEME: B3 - 1.2.3 closed live ZGani

(this ticket)

#15569 THEME: B3 - 1.2.4 closed live tskk
#16156 THEME: B3 - 1.2.5 closed live rohitink
#17186 THEME: B3 - 1.2.7 closed live catchthemes
#17535 THEME: B3 - 1.2.8 closed live tskk


https://themes.svn.wordpress.org/b3/1.0/screenshot.png

Attachments (1)

IncorrectHeightYTVideo.png (82.9 KB) - added by ZGani 5 months ago.
YouTube height needs fixing

Download all attachments as: .zip

Change History (27)

comment:1 themetracbot5 months ago

  • Summary changed from THEME: B3 - 1.0 to THEME: B3 - 1.1

B3 - 1.1

Responsive customizable theme based on Bootstrap 3 framework. Three widget areas, changeable colors and page look, export/import settings, translation ready.

Theme URL - http://andrey.ws/b3-theme
Author URL - http://andrey.ws/

SVN - http://themes.svn.wordpress.org/b3/1.1
ZIP - http://wordpress.org/themes/download/b3.1.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/b3/1.0&new_path=/b3/1.1

History:

Ticket Summary Status Resolution Owner
#15258 THEME: B3 - 1.2.3 closed live ZGani

(this ticket)

#15569 THEME: B3 - 1.2.4 closed live tskk
#16156 THEME: B3 - 1.2.5 closed live rohitink
#17186 THEME: B3 - 1.2.7 closed live catchthemes
#17535 THEME: B3 - 1.2.8 closed live tskk


https://themes.svn.wordpress.org/b3/1.1/screenshot.png

comment:2 ZGani5 months ago

  • Owner set to ZGani
  • Status changed from new to reviewing

comment:3 themetracbot5 months ago

  • Summary changed from THEME: B3 - 1.1 to THEME: B3 - 1.1.1

B3 - 1.1.1

Responsive customizable theme based on Bootstrap 3 framework. Three widget areas, changeable colors and page look, export/import settings, translation ready.

Theme URL - http://andrey.ws/b3-theme
Author URL - http://andrey.ws/

SVN - http://themes.svn.wordpress.org/b3/1.1.1
ZIP - http://wordpress.org/themes/download/b3.1.1.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/b3/1.1&new_path=/b3/1.1.1

History:

Ticket Summary Status Resolution Owner
#15258 THEME: B3 - 1.2.3 closed live ZGani

(this ticket)

#15569 THEME: B3 - 1.2.4 closed live tskk
#16156 THEME: B3 - 1.2.5 closed live rohitink
#17186 THEME: B3 - 1.2.7 closed live catchthemes
#17535 THEME: B3 - 1.2.8 closed live tskk


https://themes.svn.wordpress.org/b3/1.1.1/screenshot.png

comment:4 andreyk5 months ago

In version 1.1.1 - Missing default theme settings installation fixed.

comment:5 themetracbot5 months ago

  • Summary changed from THEME: B3 - 1.1.1 to THEME: B3 - 1.1.2

B3 - 1.1.2

Responsive customizable theme based on Bootstrap 3 framework. Three widget areas, changeable colors and page look, export/import settings, translation ready.

Theme URL - http://andrey.ws/b3-theme
Author URL - http://andrey.ws/

SVN - http://themes.svn.wordpress.org/b3/1.1.2
ZIP - http://wordpress.org/themes/download/b3.1.1.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/b3/1.1.1&new_path=/b3/1.1.2

History:

Ticket Summary Status Resolution Owner
#15258 THEME: B3 - 1.2.3 closed live ZGani

(this ticket)

#15569 THEME: B3 - 1.2.4 closed live tskk
#16156 THEME: B3 - 1.2.5 closed live rohitink
#17186 THEME: B3 - 1.2.7 closed live catchthemes
#17535 THEME: B3 - 1.2.8 closed live tskk


https://themes.svn.wordpress.org/b3/1.1.2/screenshot.png

comment:6 andreyk5 months ago

Version 1.1.2: Fixed: reset/upload javascript problem on theme options page.

comment:7 ZGani5 months ago

General.

Required:

  • Please declare theme copyright
  • Themes are required to explicitly declare copyright/license of bundled resources (if not already declared elsewhere) - Declare license and copyright for the images bundled with the theme even if they were created by you.

Code Check.

Required:

  • header.php: Please enqueue the following correctly via a function callback hooked to the proper action
    <script src="<?php echo B3_URI; ?>/js/respond.min.js"></script>
    <script src="<?php echo B3_URI; ?>/js/html5shiv.js"></script>
    
  • header.php: Please remove the following items from the document head and use the correct processes for their inclusion
    <link href="http://netdna.bootstrapcdn.com/respond-proxy.html" id="respond-proxy" rel="respond-proxy" />
    <link href="<?php echo B3_URI; ?>/images/respond.proxy.gif" id="respond-redirect" rel="respond-redirect" />
    <script src="<?php echo B3_URI; ?>/js/respond.proxy.js"></script>
    
  • In addition to the above, themes are required to be self contained and must not include externally hosted resources - what is the purpose of respond-proxy.html?
  • header.php: wp_head(); should be placed immediately above the closing </head> HTML tag.
  • footer.php: Only one footer credit link is allowed.
  • functions.php: b3_ is too short and generic to be a unique prefix - all global and custom functions are required to be prefixed with a unique prefix.
  • functions.php: Custom Post Types are plugin territory - please remove the b3_slide CPT from the theme.
  • functions.php: As mentioned above, themes are required to be self contained and all resources bundled/enqueued from with the theme using the appropriate actions/filters. The Bootstrap resources need to be enqueued from within the theme.

Note that this is not a full review and therefore other issues may well arise in the next review - please use the following resources to check, test and fix any issues before resubmitting the theme for further consideration.

Resources to be used for testing...
Theme Test Unit Data
Theme Review Guidelines
Monster Widget plugin
Debug Bar plugin
Log Deprecated Notices
Theme Check Plugin
Debogger Plugin
Theme Development Guidelines
Next Post Link
Previous Post Link
Next Image Link
Previous Image Link

Keeping ticket open for you to address all of the above issues and upload a revised version for me to continue with the review. If you have any questions please feel free to ask in the comments below.

comment:8 themetracbot5 months ago

  • Summary changed from THEME: B3 - 1.1.2 to THEME: B3 - 1.2

B3 - 1.2

Responsive customizable theme based on Bootstrap 3 framework. Three widget areas, changeable colors and page look, export/import settings, translation ready.

Theme URL - http://andrey.ws/b3theme-theme
Author URL - http://andrey.ws/

SVN - http://themes.svn.wordpress.org/b3/1.2
ZIP - http://wordpress.org/themes/download/b3.1.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/b3/1.1.2&new_path=/b3/1.2

History:

Ticket Summary Status Resolution Owner
#15258 THEME: B3 - 1.2.3 closed live ZGani

(this ticket)

#15569 THEME: B3 - 1.2.4 closed live tskk
#16156 THEME: B3 - 1.2.5 closed live rohitink
#17186 THEME: B3 - 1.2.7 closed live catchthemes
#17535 THEME: B3 - 1.2.8 closed live tskk


https://themes.svn.wordpress.org/b3/1.2/screenshot.png

comment:9 andreyk5 months ago

Theme and images copyright is declared.

As wp_enqueue_script doesn't support IE conditional enqueue, respond.min.js and html5shiv.js scripts moved into wp_head action.

CDN option and links removed, and respond.proxy removed too as it is for IE support in CDN case.

Footer - last credit link removed.

Theme functions prefix and textdomain changed.

Custom post type removed; slides settings are on the theme options page now.

comment:10 ZGani5 months ago

Theme still has issues that need addressing before approval.

Required:

  • Bootstrap is released under the Apache License v2.0 which is not compatible with GPL v2 - your theme must therefore be released under the GPL v3 for which Apache is compatible with.

Post Installation

  • Themes must not generate any PHP/Script Errors, Warnings, Notices and/or Deprecated Calls - the following Notice was generated on the front end upon theme activation. This is due to the_widget('WP_Widget_Links', array(), $args); call located in sidebar-bottom.php
    NOTICE: wp-includes/widgets.php:1124 - Undefined index: WP_Widget_Links
    

Theme Unit Test Recommendations

  • Nav Menu in sidebar over flow its container causing a bottom scroll bar - please use the Monster widget to test and fix this issue.
  • WordPress.tv Video embed overflows its container - please use the current Theme Test Unit Data to check for this
  • YouTube video is scrunched up i.e. heigh configuration is not correct - see attached and refer to the data mentioned above.
  • Post with long title overflows its container

The required issues must be addressed before theme can be approved. Theme unit data test although recommended it is highly advisable to address these for better end user experience.

Please these issues and upload a revised version so that I can conclude this review - if you have any questions please feel free to ask in the comments

ZGani5 months ago

YouTube height needs fixing

comment:11 themetracbot5 months ago

  • Summary changed from THEME: B3 - 1.2 to THEME: B3 - 1.2.1

B3 - 1.2.1

Responsive customizable theme based on Bootstrap 3 framework. Three widget areas, changeable colors and page look, export/import settings, translation ready.

Theme URL - http://andrey.ws/b3theme-theme
Author URL - http://andrey.ws/

SVN - http://themes.svn.wordpress.org/b3/1.2.1
ZIP - http://wordpress.org/themes/download/b3.1.2.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/b3/1.2&new_path=/b3/1.2.1

History:

Ticket Summary Status Resolution Owner
#15258 THEME: B3 - 1.2.3 closed live ZGani

(this ticket)

#15569 THEME: B3 - 1.2.4 closed live tskk
#16156 THEME: B3 - 1.2.5 closed live rohitink
#17186 THEME: B3 - 1.2.7 closed live catchthemes
#17535 THEME: B3 - 1.2.8 closed live tskk


https://themes.svn.wordpress.org/b3/1.2.1/screenshot.png

comment:12 andreyk5 months ago

License changed to GPL v3.

Default links widget in bottom area - replaced by tag cloud widget.

Wide video width & height - fixed.

Long post title overflow - fixed.

Monster Nav Menu overflow - fixed.

comment:13 themetracbot5 months ago

  • Summary changed from THEME: B3 - 1.2.1 to THEME: B3 - 1.2.2

B3 - 1.2.2

Responsive customizable theme based on Bootstrap 3 framework. Three widget areas, changeable colors and page look, export/import settings, translation ready.

Theme URL - http://andrey.ws/b3theme-theme
Author URL - http://andrey.ws/

SVN - http://themes.svn.wordpress.org/b3/1.2.2
ZIP - http://wordpress.org/themes/download/b3.1.2.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/b3/1.2.1&new_path=/b3/1.2.2

History:

Ticket Summary Status Resolution Owner
#15258 THEME: B3 - 1.2.3 closed live ZGani

(this ticket)

#15569 THEME: B3 - 1.2.4 closed live tskk
#16156 THEME: B3 - 1.2.5 closed live rohitink
#17186 THEME: B3 - 1.2.7 closed live catchthemes
#17535 THEME: B3 - 1.2.8 closed live tskk


https://themes.svn.wordpress.org/b3/1.2.2/screenshot.png

comment:14 andreyk5 months ago

v1.2.2 - Fixing long title overflow (it's too rough in 1.2.1).

comment:15 ZGani5 months ago

  • Status changed from reviewing to approved

All previously raised issues have been resolved.

comment:16 greenshady5 months ago

This theme is setting default options to the database in functions.php by merely being loaded. I can't remember if this is a required/recommended thing now. It's something the theme should definitely not be doing. ZGani, do you know? If not, I'll see if we can get Chip to weigh in.

Also, a quick recommendation note for the theme author:

b3theme_custom_background_args is not really necessary. Child themes can simply overwrite the custom background arguments via a call to add_theme_support( 'custom-background' ).

comment:17 follow-up: ZGani5 months ago

I'm not sure but do agree that it's something the theme should not be doing - on that note I would say its a required but I think we should get Chip weigh in. Will help keep my notes straight too so I know what to look out for.

comment:18 greenshady5 months ago

  • Cc chip@… added

comment:19 in reply to: ↑ 17 chipbennett5 months ago

Replying to ZGani:

I'm not sure but do agree that it's something the theme should not be doing - on that note I would say its a required but I think we should get Chip weigh in. Will help keep my notes straight too so I know what to look out for.

Currently still permitted, though not recommended. The upcoming Guidelines revisions proposal will introduce a "sane defaults" requirement.

comment:20 greenshady5 months ago

  • Status changed from approved to reopened

comment:21 greenshady5 months ago

  • Status changed from reopened to reviewing

comment:22 greenshady5 months ago

Required

I found one major issue that needs to be addressed before this theme can go live. Currently, this theme loads its admin styles/scripts on the Appearance screen and all themes.php sub-menu screens. It should only be loading these on the B3 Theme Settings page.

This is an easy fix. This code in functions.php:

function b3theme_admin_enqueue_scripts() {
	global $pagenow;
	if ('themes.php' == $pagenow) {

Should be:

function b3theme_admin_enqueue_scripts( $hook_suffix ) {

	if ( 'appearance_page_b3theme_settings' === $hook_suffix ) {

When this is corrected, the theme is ready to go live.

  • Add a languages/b3theme.pot file for translators to use.
  • Translate text in demo-slides.php.
  • Drop the b3theme_custom_background_args and b3theme_custom_header_args hooks since these can already be overwritten via core WordPress methods.
  • Don't set default options when the theme loads. Options should only be added to the database when the user sets them. This will be a requirement in the future.

comment:23 themetracbot5 months ago

  • Summary changed from THEME: B3 - 1.2.2 to THEME: B3 - 1.2.3

B3 - 1.2.3

Responsive customizable theme based on Bootstrap 3 framework. Three widget areas, changeable colors and page look, export/import settings, translation ready.

Theme URL - http://andrey.ws/b3theme-theme
Author URL - http://andrey.ws/

SVN - http://themes.svn.wordpress.org/b3/1.2.3
ZIP - http://wordpress.org/themes/download/b3.1.2.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/b3/1.2.2&new_path=/b3/1.2.3

History:

Ticket Summary Status Resolution Owner
#15258 THEME: B3 - 1.2.3 closed live ZGani

(this ticket)

#15569 THEME: B3 - 1.2.4 closed live tskk
#16156 THEME: B3 - 1.2.5 closed live rohitink
#17186 THEME: B3 - 1.2.7 closed live catchthemes
#17535 THEME: B3 - 1.2.8 closed live tskk


https://themes.svn.wordpress.org/b3/1.2.3/screenshot.png

comment:24 andreyk5 months ago

Changes in 1.2.3:

  • b3theme_admin_enqueue_scripts - uses appearance_page_b3theme_settings hook_suffix now
  • Removed: auto-insert default theme settings
  • Removed: b3theme_custom_background_args, b3theme_custom_header_args hooks; also inc/custom-header.php has been refined
  • Added: b3theme.pot
  • Added: Menu Bar on/off option
  • Small css fix to get large resized images height proper in ie8

comment:25 ZGani5 months ago

  • Status changed from reviewing to approved

Previously required issues have been addressed.

Installed and tested with no apparent issues.

Resolving as approved.

comment:26 Otto425 months ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.