WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#15264 closed theme (not-approved)

THEME: CWP-YouIT - 1.0.4

Reported by: codeinwp Owned by: basantakumar
Priority: previously reviewed Keywords: theme-cwp-youit needs-unit-tests
Cc: support@…

Description

CWP-YouIT - 1.0.4

YouIT is a wordpress theme created for gaming or IT news websites which wants a modern look.

Theme URL - http://themes.codeinwp.com/themes/youit-gaming-theme/
Author URL - http://www.codeinwp.com

SVN - http://themes.svn.wordpress.org/cwp-youit/1.0.4
ZIP - http://wordpress.org/themes/download/cwp-youit.1.0.4.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/cwp-youit/1.0.3&new_path=/cwp-youit/1.0.4

History:

Ticket Summary Status Resolution Owner
#13862 THEME: CWP-YouIT - 1.0.2 closed not-approved gpriday
#15199 THEME: CWP-YouIT - 1.0.3 closed not-approved sudeep611
#15264 THEME: CWP-YouIT - 1.0.4 closed not-approved basantakumar

(this ticket)

#17395 THEME: CWP-YouIT - 1.0.9 closed not-approved pagelines


https://themes.svn.wordpress.org/cwp-youit/1.0.4/screenshot.png

Attachments (2)

Clearing Floats Theme Test.png (52.5 KB) - added by basantakumar 5 months ago.
Markup Text Alignment Theme Test.png (13.7 KB) - added by basantakumar 5 months ago.

Download all attachments as: .zip

Change History (13)

comment:1 codeinwp5 months ago

All reported issues should be fixed now.

comment:2 esmi5 months ago

  • Owner set to basantakumar
  • Status changed from new to reviewing

comment:3 basantakumar5 months ago

-Theme fails in Clearing Floats test. (check the attached screenshot)
-Post next and back link having CSS issue. Overlaying the border. (check screenshot)
-Post with long heading having issue. please check.
-Theme used Bootstrap css. Please provide version license for twitterBootstrap.
-unused Bootsrap CSS is there in the css folder. Please remove unused files.

  • No file header is present in any file. Please provide file header (refer to any default theme)

Please fix the above issue. It will be good for approval.

The theme is not mobile responsive. Please try to make it a responsive layout.

comment:4 greenshady5 months ago

-Theme fails in Clearing Floats test. (check the attached screenshot)
-Post next and back link having CSS issue. Overlaying the border. (check screenshot)
-Post with long heading having issue. please check.

Note that these are recommended items to fix from the theme unit test data. They are not explicitly covered as required under the theme review guidelines. You should fix them though to have a better theme.

-No file header is present in any file. Please provide file header (refer to any default theme)

File headers (except for style.css) are definitely not required.

comment:5 codeinwp5 months ago

Thanks @basantakumar for review and @greenshady for your comments, I agree with suggestions and I also plan to do it responsive, but not for this version, so if everything is ok, I would like to have it released, get feedback, improve and repeat :)

comment:6 basantakumar5 months ago

  • Keywords needs-unit-tests added
  • Status changed from reviewing to approved

comment:7 greenshady5 months ago

  • Status changed from approved to reopened

comment:8 basantakumar5 months ago

  • Status changed from reopened to reviewing

comment:9 greenshady5 months ago

I found a number of issues with this theme through my audit. Therefore, I have re-opened this ticket. This is in no way a complete review. I still think this theme might need a more thorough check before it can be approved. Below are issues that I found with a quick scan through the files.

Required issues to be corrected

  • Theme doesn't show the correct blog posts on the home page. The index.php file shouldn't be used for custom queries. This should be handled via a custom page template.
  • Make sure all variables used in attributes are escaped in your search form in header.php.
  • The checked() function should be used for setting CHECKED in a checkbox. See: http://codex.wordpress.org/Function_Reference/checked
  • Only checking isset() in cwp_theme_options_validate() (see inc/theme-options.php) is not an acceptable method of sanitizing/validating data. Each theme option should be sanitized/validated based on the type of data it is. Anything that might allow HTML should also check the unfiltered_html capability. See this page for more info: http://codex.wordpress.org/Data_Validation
  • The link wrapping the logo in the footer is missing the URL within the href attribute.

Recommended issues to be corrected

  • The search form in the header should, ideally, be placed into a searchform.php template or a filter on get_search_form (recommended).
  • This theme has a ton of stylistic issues. While only a recommendation, you really should test your theme with the Theme Unit Test Data. The theme fails many of the tests: http://codex.wordpress.org/Theme_Unit_Test

comment:10 basantakumar4 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

comment:11 basantakumar4 months ago

No response from the author on the issues.

Note: See TracTickets for help on using tickets.