WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 4 months ago

#15273 closed theme (live)

THEME: Exility-light - 1.0.7

Reported by: molefed Owned by: ZGani
Priority: new theme Keywords: theme-exility-light
Cc: molefed@…, chipbennett

Description

Exility-light - 1.0.0

Exility-light is an elegant responsive WordPress theme. Features: built-in slider, 2 Columns, 2 Sidebars, custom menu, post thumbnails, page navigation, widget ready.

Theme URL - http://wpmole.com/exility-light
Author URL - http://wpmole.com

SVN - http://themes.svn.wordpress.org/exility-light/1.0.0
ZIP - http://wordpress.org/themes/download/exility-light.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/exility-light/1.0.0/screenshot.png

Change History (25)

comment:1 ZGani5 months ago

  • Owner set to ZGani
  • Status changed from new to reviewing

comment:2 ZGani5 months ago

General.

Required:

  • A blanket license declaration like the one below (extracted from readme.txt) is not sufficient - license and copyright for all resources used in the construction of theme must explicitly be declared
    Unless otherwise specified, all the theme files, scripts and images
    are licensed under GNU General Public License Version 3 or later.
    

I also see some very familiar code from at least WP StrapSlider but no attribution has been made? - please attribute any work on which your theme or any par thereof is a derivative of.

Code Check.

Required:

  • Please remove all inline styles from the following files - all styles must enqueued correctly via a stylesheet
    index.php
    single.php
    search.php
    page.php
    archive.php
    404.php
    
  • functions.php: register_nav_menus should be called from a function callback hooked to the after_setup_theme action
  • functions.php: exility_js_head_load() should be hooked to wp_enqueue_scripts and not the template_redirect action.
  • index.php: Please do not use query_posts for custom queries - use WP_Query instead and reset the query with wp_reset_postdata() instead of wp_reset_query()

Theme Unit Test Recommendations.

  • Pages with comments closed must not show any comment closed message like the one below from your theme
    Sorry, the comment form is closed at this time.
    
  • Post with no title must somehow link to the single post view page.

Please address these issues and upload a revised version so that I can continue with the review and hopefully get your theme approved. If you have any questions on any of the raised issues please feel free to ask in the comments.

Zulf

comment:3 ZGani5 months ago

@molefed

Any update on how soon I can expect the revised version with the fixes?

Please note that the removal of inline styles is a recommended issue.

comment:4 themetracbot5 months ago

  • Summary changed from THEME: Exility-light - 1.0.0 to THEME: Exility-light - 1.0.1

Exility-light - 1.0.1

Exility-light is an elegant responsive WordPress theme. Features: built-in slider, 2 Columns, 2 Sidebars, custom menu, post thumbnails, page navigation, widget ready.

Theme URL - http://wpmole.com/exility-light
Author URL - http://wpmole.com

SVN - http://themes.svn.wordpress.org/exility-light/1.0.1
ZIP - http://wordpress.org/themes/download/exility-light.1.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/exility-light/1.0.0&new_path=/exility-light/1.0.1

History:


https://themes.svn.wordpress.org/exility-light/1.0.1/screenshot.png

comment:5 ZGani5 months ago

  • Status changed from reviewing to approved

Previously raised issues have been resolved.

comment:6 greenshady5 months ago

  • Status changed from approved to reopened

comment:7 greenshady5 months ago

  • Status changed from reopened to reviewing

I'm reopening this because the theme has too many required issues that should be addressed before approval.

Required issues

Admin CSS

Your theme is currently loading its theme settings CSS on all pages of the admin. It should only load this on the theme setting page.

In search.php, don't use $_GET['s']; directly. Use the_search_query() or get_search_query().

Front end escaping

Use the_title_attribute() rather than the_title() when outputting the post title as a link attribute.

For example, this code:

<h2><a href="<?php the_permalink() ?>" rel="bookmark" title="Permanent Link to <?php the_title(); ?>"><?php if (trim(get_the_title()) != '') { the_title(); } else  _e('No title', 'exility'); ?></a></h2>

Should be:

<h2><a href="<?php the_permalink() ?>" rel="bookmark" title="Permanent Link to <?php the_title_attribute(); ?>"><?php if (trim(get_the_title()) != '') { the_title(); } else  _e('No title', 'exility'); ?></a></h2>

Admin escaping

On line 88 of settings/exility-options.php, you need to change sanitize_text_field() to esc_url(). That's the correct function to use.

Admin functions

Your submit button on your options screen should be replaced with the submit_button() function. http://codex.wordpress.org/Function_Reference/submit_button

Internationalization

Your theme needs to either be internationalized fully or not at all. Currently, about half the text strings are internationalized while others are not.

Theme may optionally incorporate translation/internationalization; however, if incorporated, translation/internationalization must support WordPress core functionality. http://make.wordpress.org/themes/guidelines/guidelines-code-quality/

Default options

This will soon be a requirement, so I recommend fixing it now. Please don't set default options when your theme is loaded (see settings/exility-options.php).

Favicon

I recommend hooking the favicon functionality into wp_head instead of having it within header.php.

Unused action

You should remove this code from functions.php since it just runs an action that doesn't do anything on wp_head:

function exility_wp_head() {
?>
<?php
}
add_action('wp_head', 'exility_wp_head');

comment:8 themetracbot5 months ago

  • Summary changed from THEME: Exility-light - 1.0.1 to THEME: Exility-light - 1.0.2

Exility-light - 1.0.2

Exility-light is an elegant responsive WordPress theme. Features: built-in slider, 2 Columns, 2 Sidebars, custom menu, post thumbnails, page navigation, widget ready.

Theme URL - http://wpmole.com/exility-light
Author URL - http://wpmole.com

SVN - http://themes.svn.wordpress.org/exility-light/1.0.2
ZIP - http://wordpress.org/themes/download/exility-light.1.0.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/exility-light/1.0.1&new_path=/exility-light/1.0.2

History:


https://themes.svn.wordpress.org/exility-light/1.0.2/screenshot.png

comment:9 ZGani5 months ago

There are still a few issues that need resolving

  • search.php: The following code is incorrect and needs changing
    <h2><a href="<?php the_permalink() ?>" rel="bookmark" title="Permanent Link to <?php the_title_attribute(); ?>"><?php if (trim(get_the_title()) != '') { the_title_attribute(); } else  _e('No title', 'exility'); ?></a></h2> 
    
  • Should be
    <h2><a href="<?php the_permalink() ?>" rel="bookmark" title="Permanent Link to <?php the_title_attribute(); ?>"><?php if (trim(get_the_title()) != '') { the_title(); } else  _e('No title', 'exility'); ?></a></h2> 
    
  • single.php: the_title() call was fine and did not need changing - you only need change where its actually a title=" " attribute.
  • The links on the options page should be set to open in a new window - currently clicking the Facebook button and author site link open in the same window taking the user away from their Admin section.

It is noted that the Recommended issues have not been addressed and you are advised to revisit and give them full consideration - especially the soon to be Required issue as note below

This will soon be a requirement, so I recommend fixing it now. Please don't set default options when your theme is loaded (see `settings/exility-options.php`).

Please address these issues and upload a revised version so that I can continue with the review.

comment:10 themetracbot4 months ago

  • Summary changed from THEME: Exility-light - 1.0.2 to THEME: Exility-light - 1.0.3

Exility-light - 1.0.3

Exility-light is an elegant responsive WordPress theme. Features: built-in slider, 2 Columns, 2 Sidebars, custom menu, post thumbnails, page navigation, widget ready.

Theme URL - http://wpmole.com/exility-light
Author URL - http://wpmole.com

SVN - http://themes.svn.wordpress.org/exility-light/1.0.3
ZIP - http://wordpress.org/themes/download/exility-light.1.0.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/exility-light/1.0.2&new_path=/exility-light/1.0.3

History:


https://themes.svn.wordpress.org/exility-light/1.0.3/screenshot.png

comment:11 ZGani4 months ago

  • Status changed from reviewing to approved

All of the required issues have been resolved.

comment:13 molefed4 months ago

I will replace the slider and send the new version.

comment:14 chipbennett4 months ago

  • Status changed from approved to reopened

comment:15 chipbennett4 months ago

  • Status changed from reopened to reviewing

comment:16 themetracbot4 months ago

  • Summary changed from THEME: Exility-light - 1.0.3 to THEME: Exility-light - 1.0.4

Exility-light - 1.0.4

Exility-light is an elegant responsive WordPress theme. Features: built-in slider, 2 Columns, 2 Sidebars, custom menu, post thumbnails, page navigation, widget ready.

Theme URL - http://wpmole.com/exility-light
Author URL - http://wpmole.com

SVN - http://themes.svn.wordpress.org/exility-light/1.0.4
ZIP - http://wordpress.org/themes/download/exility-light.1.0.4.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/exility-light/1.0.3&new_path=/exility-light/1.0.4

History:


https://themes.svn.wordpress.org/exility-light/1.0.4/screenshot.png

comment:17 ZGani4 months ago

Themes "must" not deregister and are "Required" to use core bundled resources - WordPress ships with the latest version of jquery and this is the version that should be used. The following is not allowed

function my_scripts_method() { 
    wp_deregister_script( 'jquery' ); 
    wp_register_script( 'jquery', 'http://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js'); 
    wp_enqueue_script( 'jquery' ); 
}

jquery is referenced in array of the script.js enqueue and that is sufficient for WordPress to enqueue the core bundled version automatically.

Please remove the above external enqueue code for approval.

comment:18 themetracbot4 months ago

  • Summary changed from THEME: Exility-light - 1.0.4 to THEME: Exility-light - 1.0.5

Exility-light - 1.0.5

Exility-light is an elegant responsive WordPress theme. Features: built-in slider, 2 Columns, 2 Sidebars, custom menu, post thumbnails, page navigation, widget ready.

Theme URL - http://wpmole.com/exility-light
Author URL - http://wpmole.com

SVN - http://themes.svn.wordpress.org/exility-light/1.0.5
ZIP - http://wordpress.org/themes/download/exility-light.1.0.5.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/exility-light/1.0.4&new_path=/exility-light/1.0.5

History:


https://themes.svn.wordpress.org/exility-light/1.0.5/screenshot.png

comment:19 ZGani4 months ago

  • Cc chipbennett added

I believe for the script.js what @chipbennet meant was it should be wrapped in a non conflict wrapper like below

( function( $ ) {

// your scripts here

} )( jQuery );

I can only see the first portion as having the wrapper around it and not the rest of the scripts.

Would that be correct @chipbennett

comment:20 themetracbot4 months ago

  • Summary changed from THEME: Exility-light - 1.0.5 to THEME: Exility-light - 1.0.6

Exility-light - 1.0.6

Exility-light is an elegant responsive WordPress theme. Features: built-in slider, 2 Columns, 2 Sidebars, custom menu, post thumbnails, page navigation, widget ready.

Theme URL - http://wpmole.com/exility-light
Author URL - http://wpmole.com

SVN - http://themes.svn.wordpress.org/exility-light/1.0.6
ZIP - http://wordpress.org/themes/download/exility-light.1.0.6.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/exility-light/1.0.5&new_path=/exility-light/1.0.6

History:


https://themes.svn.wordpress.org/exility-light/1.0.6/screenshot.png

comment:21 follow-up: molefed4 months ago

The slider does not work in this way. I have an alternate method.

comment:22 in reply to: ↑ 21 ZGani4 months ago

You do not need to have all of those separate enqueue sections - the enqueue needs to be cleaned up a little so it looks like the follwoing...in your enqueues you are using get_stylesheet_directory_uri() in several places when it should be get_template_directory_uri()

function exility_script_loader() {      
    global $wp_styles;

    wp_enqueue_script('exility_custom', get_template_directory_uri().'/libs/jquery.us.js', array('jquery'));
    wp_enqueue_script('exility_time', get_template_directory_uri().'/libs/jquery.timeout.js', array('jquery')); 
    wp_enqueue_script( 'jquery_masonry', get_template_directory_uri().'/libs/jquery.masonry.min.js', array('jquery') );

    wp_enqueue_script('scripts', get_template_directory_uri().'/js/scripts.js', array('jquery') );      
        
    if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) {
        wp_enqueue_script( 'comment-reply' );
    }
    
    wp_enqueue_style( 'exility_style', get_template_directory_uri() . '/style.css');
        
    // Load style.css from child theme
    if (is_child_theme()) {
      wp_enqueue_style('exility_child', get_stylesheet_uri(), false, '1.0', null);
    }
 
    wp_register_style('googleFonts', 'http://fonts.googleapis.com/css?family=Noto+Sans&subset=latin,cyrillic');
    wp_enqueue_style( 'googleFonts');   
}
add_action('wp_enqueue_scripts', 'exility_script_loader');

Everything seems to work fine with current configuration but I'm still not sure about the script.js - once the above enqueue issues are resolved I'll approve the theme and let the Admin decide if the script is correct or not.

comment:23 themetracbot4 months ago

  • Summary changed from THEME: Exility-light - 1.0.6 to THEME: Exility-light - 1.0.7

Exility-light - 1.0.7

Exility-light is an elegant responsive WordPress theme. Features: built-in slider, 2 Columns, 2 Sidebars, custom menu, post thumbnails, page navigation, widget ready.

Theme URL - http://wpmole.com/exility-light
Author URL - http://wpmole.com

SVN - http://themes.svn.wordpress.org/exility-light/1.0.7
ZIP - http://wordpress.org/themes/download/exility-light.1.0.7.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/exility-light/1.0.6&new_path=/exility-light/1.0.7

History:


https://themes.svn.wordpress.org/exility-light/1.0.7/screenshot.png

comment:24 ZGani4 months ago

  • Status changed from reviewing to approved

Changes as per request.

Installed and tested and everything works as it should.

Unsure about script.js therefore Admin advice required.

@Admin, if a fix is required, fix now or fix in next revision?.

Approving on the basis that the required issue with jquery has been resolved.

comment:25 chipbennett4 months ago

  • Resolution set to live
  • Status changed from approved to closed

Looks good; scripts.js now properly accounts for no-conflict configuration.

Note: See TracTickets for help on using tickets.