WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#15298 closed theme (live)

THEME: Storefront Paper - 1.0.5

Reported by: rocketfarmer Owned by: alex27
Priority: previously reviewed Keywords: theme-storefront-paper
Cc: matt@…

Description

Storefront Paper - 1.0.2

A minimal design with maximum features. Built with _s theme by Automattic by Storefront Themes.

Theme URL - http://storefrontthemes.com/paper
Author URL - http://storefrontthemes.com

SVN - http://themes.svn.wordpress.org/storefront-paper/1.0.2
ZIP - http://wordpress.org/themes/download/storefront-paper.1.0.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/storefront-paper/1.0.1&new_path=/storefront-paper/1.0.2

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27

(this ticket)

#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein


https://themes.svn.wordpress.org/storefront-paper/1.0.2/screenshot.png

Change History (15)

#1 @alex27
4 years ago

  • Owner set to alex27
  • Status changed from new to reviewing

#2 @alex27
4 years ago

Hello!

Here's my review:

REQUIRED

CODE

  • You need to properly escape home_url() function, like so: esc_url( home_url() ).
  • You don't need separate script for theme updates. Themes hosted in WordPress repository receive automatic update notice when new version is available. Please remove custom updates mechanism.
  • All functions, class names, public and global variables are properly prefixed with your theme slug. Please go over all function files!
  • Your updated version of [audio] shortcode doesn't work (audio won't play).

OTHER

  • Commercial Theme shops that wish to be associated with WPORG, including hosting Themes in the Theme directory, need to distribute 100% GPL Themes. What is the license for themes sold on your website (http://storefrontthemes.com/)? Also both your Theme and Author URI pages have some spammy link for viagra at the very bottom.
  • Super long post title overflows container (look at the post Case Edge: Post with super duper long title from Theme Unit Test Data)

CONCLUSION

Please fix above issues and upload new version of your theme, I'll leave this ticket open for another 2-3 days. Feel free to ask if you have any questions.

#3 @themetracbot
4 years ago

  • Summary changed from THEME: Storefront Paper - 1.0.2 to THEME: Storefront Paper - 1.0.3

Storefront Paper - 1.0.3

A minimal design with maximum features. Built with _s theme by Automattic by Storefront Themes.

Theme URL - http://storefrontthemes.com/paper
Author URL - http://storefrontthemes.com

SVN - http://themes.svn.wordpress.org/storefront-paper/1.0.3
ZIP - http://wordpress.org/themes/download/storefront-paper.1.0.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/storefront-paper/1.0.2&new_path=/storefront-paper/1.0.3

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27

(this ticket)

#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein


https://themes.svn.wordpress.org/storefront-paper/1.0.3/screenshot.png

#4 @themetracbot
4 years ago

  • Summary changed from THEME: Storefront Paper - 1.0.3 to THEME: Storefront Paper - 1.0.4

Storefront Paper - 1.0.4

A minimal design with just enough features. Built with _s theme by Automattic by Storefront Themes.

Theme URL - http://storefrontthemes.com/paper
Author URL - http://storefrontthemes.com

SVN - http://themes.svn.wordpress.org/storefront-paper/1.0.4
ZIP - http://wordpress.org/themes/download/storefront-paper.1.0.4.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/storefront-paper/1.0.3&new_path=/storefront-paper/1.0.4

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27

(this ticket)

#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein


https://themes.svn.wordpress.org/storefront-paper/1.0.4/screenshot.png

#5 @rocketfarmer
4 years ago

Hi there...thanks so much for helping me with this and for all you do. I made the corrections you specified. In terms of my website, thanks for the heads up. Just got an email about that from Google so I updated all my plugins and stuff and cleaned up the header file where that code was. Our products are completely, 100% GPL. We mention that at http://storefrontthemes.com/features/.

Also, I plan on making more themes from now for the repository and this account is to meet the requirements for both Storefront Themes as well as Skematik (http://skematiktheme.com).

#6 @alex27
4 years ago

Hello!

  • Still unprefixed functions found in template-customizer.php. Please remember that all functions, class names, public and global variables need to be properly prefixed with your theme slug.
  • functions.php - place require() calls outside paper_setup() function.
  • header.php - you need to escape dynamic data output with esc_attr() (I'm talking here about custom logo output here. You need to escape src attribute).
  • Footer section in customizer is empty. Either remove it or add some settings :)

#7 @themetracbot
4 years ago

  • Summary changed from THEME: Storefront Paper - 1.0.4 to THEME: Storefront Paper - 1.0.5

Storefront Paper - 1.0.5

A minimal design with just enough features. Built with _s theme by Automattic by Storefront Themes.

Theme URL - http://storefrontthemes.com/paper
Author URL - http://storefrontthemes.com

SVN - http://themes.svn.wordpress.org/storefront-paper/1.0.5
ZIP - http://wordpress.org/themes/download/storefront-paper.1.0.5.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/storefront-paper/1.0.4&new_path=/storefront-paper/1.0.5

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27

(this ticket)

#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein


https://themes.svn.wordpress.org/storefront-paper/1.0.5/screenshot.png

#8 @rocketfarmer
4 years ago

Hey there, I was wondering, now that I fixed those last few things...I have prefixed everything in the theme with 'paper' but my theme slug I think is 'storefront-paper' for the folder name. Is that going to be a problem?

#9 @alex27
4 years ago

  • Status changed from reviewing to approved

Hello!

Prefix has to be unique, it doesn't have to be exact theme slug as far as I know. In your case switching it to something more specific would actually be a good idea. By the way you still have one unprefixed class in template-customizer.php. But I'm gonna let it pass, just be sure to fix in next update.

Since there are no other issues, I'm marking this theme as approved.

#10 @alex27
4 years ago

Also, you're adding 'Customize' to menu under Appearance. You should remove it, WordPress adds this menu automatically, so in case of your theme it's doubled.

#11 @rocketfarmer
4 years ago

Cool. I just fixed all that and re-uploaded. It created a new trac ticket though, #15410. How long does it normally take to go live on WordPress.org? Also, how I let the commercial theme guys know that my free theme is now up on WordPress.org?

#12 @alex27
4 years ago

It usually takes up to 7 days for a theme to go live.
Please explain what do you mean by "how I let the commercial theme guys know that my free theme is now up on WordPress.org"? What commercial theme guys?

#13 @rocketfarmer
4 years ago

Sorry, all I mean is that both of my sites (storefrontthemes.com and skematiktheme.com) are currently listed under commercial themes in WordPress.org. I wanted to satisfy the current commercial themes requirements by having at least one theme listed in the public theme directory at WordPress.org. Just want to make sure that I pass along the word that this theme is my response to that requirement and will have another to follow shortly.

#14 @alex27
4 years ago

Oh, ok :) But in that case I won't be able to help you, I don't know who's in charge of that section.

#15 @Otto42
4 years ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.