WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 3 months ago

#15365 closed theme (not-approved)

THEME: Travel in Italy - 1.0.5

Reported by: hospitalityweb Owned by: pagelines
Priority: previously reviewed Keywords: theme-travel-in-italy
Cc:

Description

Travel in Italy - 1.0.3

A travel WordPress theme, with an Italian style flavour. Valid HTML 5 and CSS 3, widget supported (right column and footer). Featured and showcase posts with sliders. 300x250 ad banner widget-ready. The theme is perfect for travel and photographic blogs.

Theme URL -
Author URL - http://www.hospitalityweb.it/

SVN - http://themes.svn.wordpress.org/travel-in-italy/1.0.3
ZIP - http://wordpress.org/themes/download/travel-in-italy.1.0.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/travel-in-italy/1.0.2&new_path=/travel-in-italy/1.0.3

History:

Ticket Summary Status Resolution Owner
#15147 THEME: Travel in Italy - 1.0 closed not-approved emiluzelac
#15173 THEME: Travel in Italy - 1.0.1 closed not-approved britner
#15267 THEME: Travel in Italy - 1.0.2 closed not-approved bravokeyl
#15365 THEME: Travel in Italy - 1.0.5 closed not-approved pagelines

(this ticket)

#16075 THEME: Travel in Italy - 1.0.7 closed live pagelines


https://themes.svn.wordpress.org/travel-in-italy/1.0.3/screenshot.png

Attachments (3)

header.PNG (53.9 KB) - added by bravokeyl 5 months ago.
travelinitaly.1.0.3.zip (432.9 KB) - added by hospitalityweb 5 months ago.
warning.PNG (19.8 KB) - added by bravokeyl 5 months ago.

Download all attachments as: .zip

Change History (40)

comment:1 esmi5 months ago

  • Owner set to bravokeyl
  • Status changed from new to reviewing

comment:2 bravokeyl5 months ago

Fixes from previous review:
1)Footer layout for more than three widgets corrected.
2)Large images overflow is fixed using {overflow:hidden;}

I suggest you to check
http://codex.wordpress.org/CSS
Best way(i think) is to use those styles.for instance

.alignnone {

width: 100%;}

Last edited 5 months ago by bravokeyl (previous) (diff)

comment:3 bravokeyl5 months ago

Also consider if users don't crop header image.It takes whole branding div as you are using that image as background image it overlaps..

bravokeyl5 months ago

comment:4 bravokeyl5 months ago

Please check above issues and resubmit.

comment:5 hospitalityweb5 months ago

I made ​​the corrections mentioned.
Attached here you will find the modified theme.
Thanks!

comment:6 bravokeyl5 months ago

Upload the theme

Last edited 5 months ago by bravokeyl (previous) (diff)

comment:7 themetracbot5 months ago

  • Summary changed from THEME: Travel in Italy - 1.0.3 to THEME: Travel in Italy - 1.0.4

Travel in Italy - 1.0.4

A travel WordPress theme, with an Italian style flavour. Valid HTML 5 and CSS 3, widget supported (right column and footer). Featured and showcase posts with sliders. 300x250 ad banner widget-ready. The theme is perfect for travel and photographic blogs.

Theme URL -
Author URL - http://www.hospitalityweb.it/

SVN - http://themes.svn.wordpress.org/travel-in-italy/1.0.4
ZIP - http://wordpress.org/themes/download/travel-in-italy.1.0.4.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/travel-in-italy/1.0.3&new_path=/travel-in-italy/1.0.4

History:

Ticket Summary Status Resolution Owner
#15147 THEME: Travel in Italy - 1.0 closed not-approved emiluzelac
#15173 THEME: Travel in Italy - 1.0.1 closed not-approved britner
#15267 THEME: Travel in Italy - 1.0.2 closed not-approved bravokeyl
#15365 THEME: Travel in Italy - 1.0.5 closed not-approved pagelines

(this ticket)

#16075 THEME: Travel in Italy - 1.0.7 closed live pagelines


https://themes.svn.wordpress.org/travel-in-italy/1.0.4/screenshot.png

comment:8 bravokeyl5 months ago

No need of max-height for header image (my suggestion).
set height to auto
Looks all fine.Going for final review

Last edited 5 months ago by bravokeyl (previous) (diff)

comment:9 bravokeyl5 months ago

Everything is corrected. if you want to make changes do it now..
I will be marking this as approved within few hours.

Last edited 5 months ago by bravokeyl (previous) (diff)

comment:10 bravokeyl5 months ago

  • Status changed from reviewing to approved

Copyright
Themes are required to declare copyright and license information as specified by the applicable license, e.g.:

Twenty Eleven WordPress Theme, Copyright 2011 WordPress.org
Twenty Eleven is distributed under the terms of the GNU GPL

http://make.wordpress.org/themes/guidelines/guidelines-license-theme-name-credit-links-up-sell-themes/

Note: There is a implementation custom login screen (plugin territory)

Last edited 5 months ago by bravokeyl (previous) (diff)

comment:11 bravokeyl5 months ago

  • Cc chipbennet added; info@… removed

I don't have an option to set as not approved ,or to reopen but as i found the above issue so consider that before making it live.

comment:12 greenshady5 months ago

@bravokeyl

The theme declares its copyright in style.css. Is there another license/copyright issue that you're referring to?

comment:13 bravokeyl5 months ago

No.Only copyright declaration.Like this.

Twenty Eleven WordPress Theme, Copyright 2011 WordPress.org
Twenty Eleven is distributed under the terms of the GNU GPL

comment:14 hospitalityweb5 months ago

I don't understand the problem...
Should I put the copyright notice in the style.css file and resubmit the theme?

comment:15 hospitalityweb5 months ago

I have problem uploading the new version of the theme...
Trying to upload the file I get the following error:
"Only zip files are supported. We've had reports that Firefox will sometimes report zip files as generic binary files (which we don't allow). Try uploading your zip file with a different browser, such as Safari, Chrome, Opera, or Internet Explorer."
Of course I'm uploading a zip file...
I tried with Firefox and Chrome

comment:16 greenshady5 months ago

  • Status changed from approved to reopened

As far as I'm concerned, the copyright and license statement is done correctly.

However, I'm reopening this ticket because there are a number of other issues that will need to be addressed before it can be approved. I'll list those shortly.

comment:17 greenshady5 months ago

  • Status changed from reopened to reviewing

comment:18 greenshady5 months ago

Required issues

Licensing

Now that I've had a chance to look at the theme code, I think what @bravokeyl may be referring to is that large portions of this theme's code are from the Twenty Eleven theme or another Twenty* theme. For any theme's code that you used, you'd need to add the copyright and credit to your theme's readme.txt.

See: http://make.wordpress.org/themes/guidelines/guidelines-license-theme-name-credit-links-up-sell-themes/

Theme Namespacing

See: http://make.wordpress.org/themes/guidelines/guidelines-code-quality/

All theme functions and classes should be prefixed with the theme slug or similar. I've seen travelinitaly_, hweb_, and my_ all used as prefixes. These should all be travelinitaly_. The custom post metadata should also be prefixed the same.

See both the functions.php file and /widgets folder for issues.

Basically, anything that's public (not within a function or class) should be properly namespaced.

Data validation and escaping

The widget in ads_widget.php has validation/santization and escaping issues.

In the update() method, you need to make sure all data is properly validated and/or sanitized. In the widget() and form() methods, you need to make sure to escape all attributes.

See: http://codex.wordpress.org/Data_Validation

Your footer text works but is not coded very well. It'd pretty much be impossible to properly translate it except in languages that have the exact same structure as English. Here's what I recommend:

<?php printf(
	__( '%1$s is powered by %2$s - Theme designed by %$3s', 'travelinitaly' ),
	'<a href="' . home_url() . '">' . get_bloginfo( 'name' ) . '</a>',
	'<a href="http://wordpress.org">' . __( 'WordPress', 'travelinitaly' ) . '</a>',
	'<a href="http://www.hospitalityweb.it">' . __( 'Hospitality Web', 'travelinitaly' ) . '</a>'
); ?>

comment:19 bravokeyl5 months ago

Please make the above changes

comment:20 themetracbot5 months ago

  • Summary changed from THEME: Travel in Italy - 1.0.4 to THEME: Travel in Italy - 1.0.5

Travel in Italy - 1.0.5

A travel WordPress theme, with an Italian style flavour. Valid HTML 5 and CSS 3, widget supported (right column and footer). Featured and showcase posts with sliders. 300x250 ad banner widget-ready. The theme is perfect for travel and photographic blogs.

Theme URL -
Author URL - http://www.hospitalityweb.it/

SVN - http://themes.svn.wordpress.org/travel-in-italy/1.0.5
ZIP - http://wordpress.org/themes/download/travel-in-italy.1.0.5.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/travel-in-italy/1.0.4&new_path=/travel-in-italy/1.0.5

History:

Ticket Summary Status Resolution Owner
#15147 THEME: Travel in Italy - 1.0 closed not-approved emiluzelac
#15173 THEME: Travel in Italy - 1.0.1 closed not-approved britner
#15267 THEME: Travel in Italy - 1.0.2 closed not-approved bravokeyl
#15365 THEME: Travel in Italy - 1.0.5 closed not-approved pagelines

(this ticket)

#16075 THEME: Travel in Italy - 1.0.7 closed live pagelines


https://themes.svn.wordpress.org/travel-in-italy/1.0.5/screenshot.png

bravokeyl5 months ago

comment:21 follow-up: bravokeyl5 months ago

  • Cc chipbennet removed

Check the image attached..

comment:22 esmi5 months ago

  • Owner changed from bravokeyl to pagelines

comment:23 follow-up: pagelines5 months ago

Travel in Italy

Issues

Page Image Alignment large image issue - fixed with .alignone { width: 100%; }
No way to edit posts or pages via the front end i.e. missing edit link.

comment:24 pagelines5 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

comment:25 greenshady5 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

comment:26 greenshady5 months ago

  • Status changed from reopened to reviewing

comment:27 in reply to: ↑ 23 greenshady5 months ago

Did the theme author address the issues I raised above in the most recent update?

Replying to pagelines:

Page Image Alignment large image issue - fixed with .alignone { width: 100%; }
No way to edit posts or pages via the front end i.e. missing edit link.

Note that neither of these are required issues for acceptance into the repository. They are recommended for making your theme better. Although, I'm not entirely sure what the image issue is though.

comment:28 in reply to: ↑ 21 ; follow-up: greenshady5 months ago

Replying to bravokeyl:

Check the image attached..

That's actually a mistake I made in the recommended code above (though it should've been checked by the theme author). Here's the corrected version:

<?php printf(
	__( '%1$s is powered by %2$s - Theme designed by %3$s', 'travelinitaly' ),
	'<a href="' . home_url() . '">' . get_bloginfo( 'name' ) . '</a>',
	'<a href="http://wordpress.org">' . __( 'WordPress', 'travelinitaly' ) . '</a>',
	'<a href="http://www.hospitalityweb.it">' . __( 'Hospitality Web', 'travelinitaly' ) . '</a>'
); ?>

comment:29 in reply to: ↑ 28 pagelines5 months ago

Replying to greenshady:

Replying to bravokeyl:

Check the image attached..

That's actually a mistake I made in the recommended code above (though it should've been checked by the theme author). Here's the corrected version:

<?php printf(
	__( '%1$s is powered by %2$s - Theme designed by %3$s', 'travelinitaly' ),
	'<a href="' . home_url() . '">' . get_bloginfo( 'name' ) . '</a>',
	'<a href="http://wordpress.org">' . __( 'WordPress', 'travelinitaly' ) . '</a>',
	'<a href="http://www.hospitalityweb.it">' . __( 'Hospitality Web', 'travelinitaly' ) . '</a>'
); ?>

The image issue was apparent on one of the theme unit test pages, the image was being cut off but the CSS provided above will fix it.

In regards to the issues @greenshady posted, the theme author fixed them but the broken footer code still needs to be fixed.

@Theme author: Please fix the footer code before the theme is approved.

comment:30 pagelines5 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

comment:31 greenshady5 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

comment:32 greenshady5 months ago

  • Status changed from reopened to reviewing

@pagelines - Can you please not close the ticket and keep it open for the theme author to upload a new version? If you don't want continue the review, I can assign it to myself.

comment:33 chipbennett4 months ago

@hospitalityweb will you be submitting an update?

comment:34 hospitalityweb3 months ago

Sorry for the long wait. I just uploaded the updated theme in which I have corrected the errors reported.

comment:35 pagelines3 months ago

@hospitalityweb - Where is the new uploaded version ?

comment:36 hospitalityweb3 months ago

I have submitted the updated theme one day ago and the system has opened a new ticket number #16075... the new ticket is still in the state "new"

comment:37 pagelines3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Set to not-approved due to other ticket - https://themes.trac.wordpress.org/ticket/16075

Note: See TracTickets for help on using tickets.