WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#15858 closed theme (live)

THEME: rtPanel - 4.1.1

Reported by: rtcamp Owned by: ZGani
Priority: theme update Keywords: theme-rtpanel
Cc: admin@…

Description

rtPanel - 4.0

WordPress theme framework with Custom Menu, Header and Background along with Logo, Favicon, Featured Image, Google Custom Search Integration and more options. Now includes a Foundation 5 framework, Grunt Task Runner, Bower package manager, SAAS based CSS preprocessor and translation support. This theme comes with free technical support by team of 30+ full-time developers.

Theme URL - http://rtcamp.com/rtpanel/
Author URL - http://rtcamp.com/

SVN - http://themes.svn.wordpress.org/rtpanel/4.0
ZIP - http://wordpress.org/themes/download/rtpanel.4.0.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/rtpanel/3.2&new_path=/rtpanel/4.0

History:

Ticket Summary Status Resolution Owner
#4715 THEME: rtPanel - 2.0 closed closed-newer-version-uploaded emiluzelac
#4724 THEME: rtPanel - 2.0.1 closed closed-newer-version-uploaded emiluzelac
#4725 THEME: rtPanel - 2.0.2 closed not-approved garinungkadol
#4953 THEME: rtPanel - 2.0.3 closed closed-newer-version-uploaded saymar90
#5104 THEME: rtPanel - 2.0.4 closed closed-newer-version-uploaded garinungkadol
#5148 THEME: rtPanel - 2.0.5 closed closed-newer-version-uploaded garinungkadol
#5149 THEME: rtPanel - 2.0.6 closed live garinungkadol
#5911 THEME: rtPanel - 2.0.7 closed closed-newer-version-uploaded greenshady
#5996 THEME: rtPanel - 2.0.8 closed live greenshady
#8172 THEME: rtPanel - 2.1 closed live SeizedPropaganda
#8212 THEME: rtPanel - 2.1.1 closed live chipbennett
#9063 THEME: rtPanel - 2.2 closed closed-newer-version-uploaded emiluzelac
#9065 THEME: rtPanel - 2.2.1 closed live emiluzelac
#9091 THEME: rtPanel - 2.2.2 closed live nishasingh
#9218 THEME: rtPanel - 2.2.3 closed live applextrent
#12005 THEME: rtPanel - 3.0 closed live chipbennett
#12449 THEME: rtPanel - 3.1 closed live jcastaneda
#12616 THEME: rtPanel - 3.2 closed live emiluzelac
#15858 THEME: rtPanel - 4.1.1 closed live ZGani

(this ticket)

#16092 THEME: rtPanel - 4.1.3 closed live sandy786
#16342 THEME: rtPanel - 4.1.5 closed live faishal
#23348 THEME: rtPanel - 4.1.6 closed live jcastaneda


https://themes.svn.wordpress.org/rtpanel/4.0/screenshot.png

Change History (12)

#1 @themetracbot
4 years ago

  • Summary changed from THEME: rtPanel - 4.0 to THEME: rtPanel - 4.0.1

rtPanel - 4.0.1

WordPress theme framework with Custom Menu, Header and Background along with Logo, Favicon, Featured Image, Google Custom Search Integration and more options. Now includes a Foundation 5 framework, Grunt Task Runner, Bower package manager, SAAS based CSS preprocessor and translation support. This theme comes with free technical support by team of 30+ full-time developers.

Theme URL - http://rtcamp.com/rtpanel/
Author URL - http://rtcamp.com/

SVN - http://themes.svn.wordpress.org/rtpanel/4.0.1
ZIP - http://wordpress.org/themes/download/rtpanel.4.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/rtpanel/4.0&new_path=/rtpanel/4.0.1

History:

Ticket Summary Status Resolution Owner
#4715 THEME: rtPanel - 2.0 closed closed-newer-version-uploaded emiluzelac
#4724 THEME: rtPanel - 2.0.1 closed closed-newer-version-uploaded emiluzelac
#4725 THEME: rtPanel - 2.0.2 closed not-approved garinungkadol
#4953 THEME: rtPanel - 2.0.3 closed closed-newer-version-uploaded saymar90
#5104 THEME: rtPanel - 2.0.4 closed closed-newer-version-uploaded garinungkadol
#5148 THEME: rtPanel - 2.0.5 closed closed-newer-version-uploaded garinungkadol
#5149 THEME: rtPanel - 2.0.6 closed live garinungkadol
#5911 THEME: rtPanel - 2.0.7 closed closed-newer-version-uploaded greenshady
#5996 THEME: rtPanel - 2.0.8 closed live greenshady
#8172 THEME: rtPanel - 2.1 closed live SeizedPropaganda
#8212 THEME: rtPanel - 2.1.1 closed live chipbennett
#9063 THEME: rtPanel - 2.2 closed closed-newer-version-uploaded emiluzelac
#9065 THEME: rtPanel - 2.2.1 closed live emiluzelac
#9091 THEME: rtPanel - 2.2.2 closed live nishasingh
#9218 THEME: rtPanel - 2.2.3 closed live applextrent
#12005 THEME: rtPanel - 3.0 closed live chipbennett
#12449 THEME: rtPanel - 3.1 closed live jcastaneda
#12616 THEME: rtPanel - 3.2 closed live emiluzelac
#15858 THEME: rtPanel - 4.1.1 closed live ZGani

(this ticket)

#16092 THEME: rtPanel - 4.1.3 closed live sandy786
#16342 THEME: rtPanel - 4.1.5 closed live faishal
#23348 THEME: rtPanel - 4.1.6 closed live jcastaneda


https://themes.svn.wordpress.org/rtpanel/4.0.1/screenshot.png

#2 @ZGani
4 years ago

  • Owner set to ZGani
  • Status changed from new to reviewing

#3 @ZGani
4 years ago

A couple of issues need resolving before theme can be approved.

  • package.json does not seem to be part of the theme or is it?
  • header.php: wp_head(); must be placed immediately above the closing </head> html tag.
  • footer.php: wp_footer(); must be placed immediately above the closing </body> html tag.

Installed and tested with no apparent visual issues so with the above issues resolved we should be good for approval provided the revised version does not raise new issues.

EDIT: Sorry just noticed that the favicon is enabled by default - the requirement is that favicon if implemented must be user configurable and disabled by default. Please amend this.

In addition the default supplied logo must be generic in nature i.e. it must not be a company or theme specific branded.

Last edited 4 years ago by ZGani (previous) (diff)

#4 @themetracbot
4 years ago

  • Summary changed from THEME: rtPanel - 4.0.1 to THEME: rtPanel - 4.1

rtPanel - 4.1

WordPress theme framework with Custom Menu, Header and Background along with Logo, Favicon, Featured Image, Google Custom Search Integration and more options. Now includes a Foundation 5 framework, Grunt Task Runner, Bower package manager, SAAS based CSS preprocessor and translation support. This theme comes with free technical support by team of 30+ full-time developers.

Theme URL - http://rtcamp.com/rtpanel/
Author URL - http://rtcamp.com/

SVN - http://themes.svn.wordpress.org/rtpanel/4.1
ZIP - http://wordpress.org/themes/download/rtpanel.4.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/rtpanel/4.0.1&new_path=/rtpanel/4.1

History:

Ticket Summary Status Resolution Owner
#4715 THEME: rtPanel - 2.0 closed closed-newer-version-uploaded emiluzelac
#4724 THEME: rtPanel - 2.0.1 closed closed-newer-version-uploaded emiluzelac
#4725 THEME: rtPanel - 2.0.2 closed not-approved garinungkadol
#4953 THEME: rtPanel - 2.0.3 closed closed-newer-version-uploaded saymar90
#5104 THEME: rtPanel - 2.0.4 closed closed-newer-version-uploaded garinungkadol
#5148 THEME: rtPanel - 2.0.5 closed closed-newer-version-uploaded garinungkadol
#5149 THEME: rtPanel - 2.0.6 closed live garinungkadol
#5911 THEME: rtPanel - 2.0.7 closed closed-newer-version-uploaded greenshady
#5996 THEME: rtPanel - 2.0.8 closed live greenshady
#8172 THEME: rtPanel - 2.1 closed live SeizedPropaganda
#8212 THEME: rtPanel - 2.1.1 closed live chipbennett
#9063 THEME: rtPanel - 2.2 closed closed-newer-version-uploaded emiluzelac
#9065 THEME: rtPanel - 2.2.1 closed live emiluzelac
#9091 THEME: rtPanel - 2.2.2 closed live nishasingh
#9218 THEME: rtPanel - 2.2.3 closed live applextrent
#12005 THEME: rtPanel - 3.0 closed live chipbennett
#12449 THEME: rtPanel - 3.1 closed live jcastaneda
#12616 THEME: rtPanel - 3.2 closed live emiluzelac
#15858 THEME: rtPanel - 4.1.1 closed live ZGani

(this ticket)

#16092 THEME: rtPanel - 4.1.3 closed live sandy786
#16342 THEME: rtPanel - 4.1.5 closed live faishal
#23348 THEME: rtPanel - 4.1.6 closed live jcastaneda


https://themes.svn.wordpress.org/rtpanel/4.1/screenshot.png

#5 @rtcamp
4 years ago

Hello ZGani,

First of all thanks for pointing out the issues, below are my responses with respect to your feedback:

  1. package.json is part of the build tool (grunt), and hence not the part of the theme.
  2. In header.php, wp_head() is now placed immediately above the closing </head> HTML tag.
  3. In footer.php, wp_footer() is now placed immediately above the closing </body> HTML tag.
  4. Favicon is disabled now by default and option is present where user can upload custom favicon to the site.
  5. As shown in attached screenshot, we already provided an option to upload a custom logo. The current logo present is of our theme's logo, just for demo sake.

I have uploaded the theme for review. Kindly let me know if you have any further feedback.

P.S. this comment is with reference to your comment at http://themes.trac.wordpress.org/ticket/15858#comment:3

Thanks,
rtCamp

https://rtcamp.com/wp-content/uploads/2014/01/rtPanel_Logo_Favicon_Options.png

#6 @ZGani
4 years ago

Just got the following Fatal Error upon activation and viewing the front end.

Fatal error: Can't use function return value in write context in /home/sites/wpliveserver.com/public_html/wp-content/themes/rtpanel/header.php on line 17

In addition, <title></title> must only contain wp_title( '|', true, 'right' ); with all other parameters included via the wp_title filter in a function callback.

As for the logo - the option is fine but the logo bundled with theme must be generic in nature like "Logo". Branded logos are not acceptable.

#7 @themetracbot
4 years ago

  • Summary changed from THEME: rtPanel - 4.1 to THEME: rtPanel - 4.1.1

rtPanel - 4.1.1

WordPress theme framework with Custom Menu, Header and Background along with Logo, Favicon, Featured Image, Google Custom Search Integration and more options. Now includes a Foundation 5 framework, Grunt Task Runner, Bower package manager, SAAS based CSS preprocessor and translation support. This theme comes with free technical support by team of 30+ full-time developers.

Theme URL - http://rtcamp.com/rtpanel/
Author URL - http://rtcamp.com/

SVN - http://themes.svn.wordpress.org/rtpanel/4.1.1
ZIP - http://wordpress.org/themes/download/rtpanel.4.1.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/rtpanel/4.1&new_path=/rtpanel/4.1.1

History:

Ticket Summary Status Resolution Owner
#4715 THEME: rtPanel - 2.0 closed closed-newer-version-uploaded emiluzelac
#4724 THEME: rtPanel - 2.0.1 closed closed-newer-version-uploaded emiluzelac
#4725 THEME: rtPanel - 2.0.2 closed not-approved garinungkadol
#4953 THEME: rtPanel - 2.0.3 closed closed-newer-version-uploaded saymar90
#5104 THEME: rtPanel - 2.0.4 closed closed-newer-version-uploaded garinungkadol
#5148 THEME: rtPanel - 2.0.5 closed closed-newer-version-uploaded garinungkadol
#5149 THEME: rtPanel - 2.0.6 closed live garinungkadol
#5911 THEME: rtPanel - 2.0.7 closed closed-newer-version-uploaded greenshady
#5996 THEME: rtPanel - 2.0.8 closed live greenshady
#8172 THEME: rtPanel - 2.1 closed live SeizedPropaganda
#8212 THEME: rtPanel - 2.1.1 closed live chipbennett
#9063 THEME: rtPanel - 2.2 closed closed-newer-version-uploaded emiluzelac
#9065 THEME: rtPanel - 2.2.1 closed live emiluzelac
#9091 THEME: rtPanel - 2.2.2 closed live nishasingh
#9218 THEME: rtPanel - 2.2.3 closed live applextrent
#12005 THEME: rtPanel - 3.0 closed live chipbennett
#12449 THEME: rtPanel - 3.1 closed live jcastaneda
#12616 THEME: rtPanel - 3.2 closed live emiluzelac
#15858 THEME: rtPanel - 4.1.1 closed live ZGani

(this ticket)

#16092 THEME: rtPanel - 4.1.3 closed live sandy786
#16342 THEME: rtPanel - 4.1.5 closed live faishal
#23348 THEME: rtPanel - 4.1.6 closed live jcastaneda


https://themes.svn.wordpress.org/rtpanel/4.1.1/screenshot.png

#8 @rtcamp
4 years ago

Hello ZGani,

We have fixed all the issues mentioned in your last comment. Also cross checked fatal error its not showing on our end.

  1. Now title tag contains wp_title( '|', true, 'right' ); function only.
  2. We have removed theme logo image and used sample logo as you mentioned.

Kindly let me know if you have any further feedback.

Thanks,
rtCamp

#9 @ZGani
4 years ago

  • Status changed from reviewing to approved

The raised required issues have been resolved.

There a few more issues that I missed so will advise for these to be fixed in the next revision.

  • Escape all instances of home_url() correctly - found in header.php and rtp-search.php
  • Favicons if implemented must user configurable and off by default - the emphasis here is on "Off by default".

#10 @rtcamp
4 years ago

Hello ZGani,

Thanks for approving rtPanel theme.

We have fixed the issue with home_url(), about the second issue we already updated the setting in the latest commit.

Favicon is off by default in rtPanel can you check back and update if you are still facing the same issue as I couldn't replicate the issue here.

Thanks,
rtCamp

#11 @ZGani
4 years ago

You are welcome.

On the favicon issue: It must have been a previous install setting that was picked up as I've install the theme on a fresh site and can confirm that the favicon is off by default.

The other issue's fix can be included in the next revision.

#12 @chipbennett
4 years ago

  • Resolution set to live
  • Status changed from approved to closed

Currently approved Theme - batch-processed as live

Note: See TracTickets for help on using tickets.