WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#15891 closed theme (not-approved)

THEME: Yeti-5 - 0.2.2

Reported by: alex.justesen Owned by: faishal
Priority: new theme Keywords: theme-yeti-5
Cc: alex@…

Description

Yeti-5 - 0.2.1

Created with Foundation 5 by Zurb http://foundation.zurb.com. Currently uses Foundation v5.0.2

Theme URL - http://www.alexjustesen.com/yeti-5
Author URL - http://www.alexjustesen.com

SVN - http://themes.svn.wordpress.org/yeti-5/0.2.1
ZIP - http://wordpress.org/themes/download/yeti-5.0.2.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#15891 THEME: Yeti-5 - 0.2.2 closed not-approved faishal

(this ticket)

#16101 THEME: Yeti-5 - 0.3.1 closed not-approved harimaliya


https://themes.svn.wordpress.org/yeti-5/0.2.1/screenshot.png

Change History (8)

#1 @themetracbot
4 years ago

  • Summary changed from THEME: Yeti-5 - 0.2.1 to THEME: Yeti-5 - 0.2.2

#2 @emiluzelac
4 years ago

  • Owner set to faishal
  • Status changed from new to reviewing

Trainee assigned Please review against this guidelines

Thanks!

#3 @faishal
4 years ago

Following warnings coming on fresh WordPress 3.8 in debug logs

NOTICE: wp-content/themes/yeti-5/inc/menu-options.php:51 - Trying to get property of non-object
NOTICE: wp-content/themes/yeti-5/inc/menu-options.php:53 - Trying to get property of non-object
NOTICE: wp-content/themes/yeti-5/inc/menu-options.php:55 - Trying to get property of non-object
NOTICE: wp-content/themes/yeti-5/inc/menu-options.php:56 - Trying to get property of non-object
NOTICE: wp-content/themes/yeti-5/inc/menu-options.php:112 - Trying to get property of non-object
NOTICE: wp-content/themes/yeti-5/inc/menu-options.php:114 - Trying to get property of non-object
NOTICE: wp-content/themes/yeti-5/inc/menu-options.php:116 - Trying to get property of non-object
NOTICE: wp-content/themes/yeti-5/inc/menu-options.php:117 - Trying to get property of non-object

#4 @faishal
4 years ago

Missing js file foundation.dropdown.js

Failed to load resource: the server responded with a status of 404 (Not Found)  http://localhost/wp-content/themes/yeti-5/js/foundation.dropdown.js

#5 @faishal
4 years ago

Themes must provide a unique slug for all custom function names in yeti-5/inc/theme-options.php:

 Line : function_name
----------------------------------------
     9: function theme_options_init(){
    16: function theme_options_add_page() {
    23: function theme_options_do_page() {
   146: function theme_options_validate( $input ) {

#6 @faishal
4 years ago

Following other issues are found during theme code review

  • meta charset is hardcoded
  • multiple text domain (yeti-5 & yeti-5_theme)
  • use wp_enqueue_style()/wp_enqueue_script() to include stylesheets and scripts
  • jquery is in wordpress core-bundled scripts use that instead of enqueue themes.

#7 @faishal
4 years ago

  • Menu is broken (because primary menu is not set)
  • Post content issues
    1. Sticky post is not distinctly recognizable
    2. image alignment in post content is not proper.
      1. text wrapping is not proper
      2. Text is creeping on the image.their should be some spaces to the right site of the image if image is left align and on left site of the image if image is right align
      3. Right and Center align images in post content are not align accordingly.
      4. Missing text wrapping around them small size images.
      5. Massively large images are overflowing content area
    3. On post archive page It should be display user-defined post excerpt in place of the post content if Excerpt is defined
    4. Post comment is not proper formatted

#8 @faishal
4 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Invalid readme.txt content please update it using Plugin readme.txt markdown.

Note: See TracTickets for help on using tickets.