WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#15913 closed theme (live)

THEME: WPCrest - 1.7

Reported by: naifamoodi Owned by: vibhorp
Priority: previously reviewed Keywords: theme-wpcrest
Cc: prince_of_nights@…

Attachments (3)

Firefox_Screenshot_2014-01-19T18-10-56.257Z.png (9.9 KB) - added by vibhorp 4 years ago.
Widget
Firefox_Screenshot_2014-01-19T18-19-00.362Z.png (15.1 KB) - added by vibhorp 4 years ago.
Recent Comments
Firefox_Screenshot_2014-01-15T17-42-43.915Z.png (88.0 KB) - added by vibhorp 4 years ago.
Post Titles

Download all attachments as: .zip

Change History (24)

#1 @themetracbot
4 years ago

  • Summary changed from THEME: WPCrest - 1.1 to THEME: WPCrest - 1.2

#2 @themetracbot
4 years ago

  • Summary changed from THEME: WPCrest - 1.2 to THEME: WPCrest - 1.3

#3 @esmi
4 years ago

  • Owner set to ‘vibhorp
  • Status changed from new to reviewing

#4 @esmi
4 years ago

  • Owner changed from ‘vibhorp to vibhorp

#5 @vibhorp
4 years ago

Theme Check RECOMMENDED some features you may use them with in the theme.

Remove Hard Coded Link in footer.php .

Found Some Style specific issues for HTML tags like Superscript Tag,Subscript Tag,Table . Check all styles specific posts of Theme Unit Test Data.

I'd suggest ,to use dependency of jquery once in the functions.php

Super Dooper Long Text breaks the Title of the Post in Blog page.

Use prefix or theme-slug for functions name used in functions.php .

Removed Unused file(pagenavi-css) from theme's package.

#6 follow-up: @naifamoodi
4 years ago

Hi there. Thanks for reviewing the theme! I have a few questions and I'd be glad if you answer them.

There is one credit link in footer.php which can be disabled from the administration side by the theme user. It looks like this:

printf(__('A WordPress Theme by %s.', 'wpcrest'), '<a href="http://www.rhyzz.com/wpcrest.html">Rhyzz</a>');

Let me know if I must remove this?

Regarding the file you found there i.e. pagenavi.css, it provides matching styling for the popular WP-PageNavi plugin. Considering many people use that plugin I thought I would include it. Let me know if I should still remove it?

All functions inside functions.php are part of the WPCrest class that's why they haven't been prefixed because there won't be any clashing issues.

I'll take care of the rest and reupload for review.

Thanks!

#7 in reply to: ↑ 6 @vibhorp
4 years ago

Replying to naifamoodi:

printf(__('A WordPress Theme by %s.', 'wpcrest'), '<a href="http://www.rhyzz.com/wpcrest.html">Rhyzz</a>');

Either Remove It or If used, credit-link removal options are required to be opt-in (i.e. disabled by default, rather than enabled)

Remove Unused Tags from Style.css ('Theme Options')

#8 @themetracbot
4 years ago

  • Summary changed from THEME: WPCrest - 1.3 to THEME: WPCrest - 1.4

#9 @naifamoodi
4 years ago

Hi. I have reuploaded the theme and here is a summary of what I have taken care of:

[Remove Hard Coded Link in footer.php .] - These links are now opt-in, disabled by default.

[Found Some Style specific issues for HTML tags like Superscript Tag,Subscript Tag,Table . Check all styles specific posts of Theme Unit Test Data.] - I have taken care of these issues.

[I'd suggest ,to use dependency of jQuery once in the functions.php] - Took care of this too. It's now loaded only once at the top.

[Super Dooper Long Text breaks the Title of the Post in Blog page.] - Took care of this by setting CSS word-break property to break-all

[Remove Unused Tags from Style.css ('Theme Options')] - The theme does provide an Options page which is available if the Fields Framework plugin (http://wordpress.org/plugins/fields-framework/) is installed.

Last edited 4 years ago by naifamoodi (previous) (diff)

#10 follow-up: @vibhorp
4 years ago

->Need to manage all widgets.Refer the attached file.
->Remove Contact Template ,The contact us for is plugin territory and should be removed from the theme.

Rest Is Looks Good..

#11 @themetracbot
4 years ago

  • Summary changed from THEME: WPCrest - 1.4 to THEME: WPCrest - 1.5

#12 in reply to: ↑ 10 @naifamoodi
4 years ago

Hi. Thanks for your response! I am done taking care of everything you pointed in the screenshots above and also took care of removing the contact page template.

Only thing left is the issue pertaining to long titles you have pointed out in the screenshots. I had already taken care of this by adding a "word-break: break-all;" property so I am not sure why it persisted there. Can you please let me know if you still see it? If you do, I'll probably use an alternative way of taking care of this.

Thanks!

#13 @vibhorp
4 years ago

  • Status changed from reviewing to approved

Previous Issue Fixed.

#14 @naifamoodi
4 years ago

Hi again. I see you have changed the status but what happens now?

#15 @chipbennett
4 years ago

  • Status changed from approved to reopened

#16 @chipbennett
4 years ago

  • Status changed from reopened to reviewing

Required

  • Unless I'm mistaken, unless the Fields Framework Plugin is installed, this template is going to throw an undefined variable notice:

http://themes.svn.wordpress.org/wpcrest/1.5/template-showcase-page.php

  • Content of HTML <title> tag must be only the call to wp_title(). Any modifications must be implemented via wp_title filter
  • MCE buttons are Plugin territory
  • Theme documentation lists Fields Framework as a required Plugin. WPORG-hosted Themes cannot require any particular Plugins to be installed. Please revise this wording to recommended Plugin, rather than required.

Questions

  • It appears that the Fields Framework Plugin handles all Theme options functionality?
  • How thoroughly did you test the front-end user inputs? Front-end user-input data are the ultimate untrusted data, and are especially vulnerable to exploit vectors.

#17 @themetracbot
4 years ago

  • Summary changed from THEME: WPCrest - 1.5 to THEME: WPCrest - 1.6

#18 @themetracbot
4 years ago

  • Summary changed from THEME: WPCrest - 1.6 to THEME: WPCrest - 1.7

#19 @naifamoodi
4 years ago

Hi there,

Unless I'm mistaken, unless the Fields Framework Plugin is installed, this template is going to throw an undefined variable notice:

The variables on that template are first checked if whether they are empty or not. I have done it like this everywhere so that no such notices get thrown by PHP.

Content of HTML <title> tag must be only the call to wp_title(). Any modifications must be implemented via wp_title filter

I have taken care of this. It now does this using the wp_title filter as suggested.

MCE buttons are Plugin territory

I have removed this.

Theme documentation lists Fields Framework as a required Plugin. WPORG-hosted Themes cannot require any particular Plugins to be installed. Please revise this wording to recommended Plugin, rather than required.

I have changed the wording. The user won't be able to configure the options from the administration end without this plugin being active though however the theme will continue to be full functional even without this plugin.

It appears that the Fields Framework Plugin handles all Theme options functionality?

That is correct. But as I mentioned above, even if it's not active everything will work as expected however the user won't be able to configure the options from the administration end.

How thoroughly did you test the front-end user inputs? Front-end user-input data are the ultimate untrusted data, and are especially vulnerable to exploit vectors.

I am afraid I don't understand what front end user inputs you are referring to? On the user's end, the only input accepted is on the search form. On the backend all inputs are handled by Fields Framework plugin.

I have uploaded a revised version of the theme (v1.7).

#20 @vibhorp
4 years ago

  • Status changed from reviewing to approved

Approving theme on diff and quick visual check.

#21 @chipbennett
4 years ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.