WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#16423 closed theme (not-approved)

THEME: Enough - 0.87

Reported by: nobita Owned by: robin90
Priority: theme update Keywords: theme-enough
Cc: a.tenman@…

Description

Enough - 0.87

Satisfied enough necessary minimum structure Responsive Theme. HTML5 normalize.css . 11 kinds of homepage templates can be chosen for the purpose of using you.

Theme URL - http://www.tenman.info/wp3/enough/
Author URL - http://www.tenman.info/wp3/

SVN - http://themes.svn.wordpress.org/enough/0.87
ZIP - http://wordpress.org/themes/download/enough.0.87.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/enough/0.86&new_path=/enough/0.87

History:

Ticket Summary Status Resolution Owner
#7007 THEME: Enough - 0.1 closed live ElanTechnosys
#7274 THEME: Enough - 0.2 closed live chipbennett
#7300 THEME: Enough - 0.21 closed live chipbennett
#7333 THEME: Enough - 0.22 closed live chipbennett
#7352 THEME: Enough - 0.23 closed live kobenland
#7524 THEME: Enough - 0.24 closed closed-newer-version-uploaded chipbennett
#7526 THEME: Enough - 0.25 closed live chipbennett
#7541 THEME: Enough - 0.26 closed live emiluzelac
#7557 THEME: Enough - 0.27 closed live sixhours
#7883 THEME: Enough - 0.28 closed live kobenland
#8165 THEME: Enough - 0.31 closed live kobenland
#8235 THEME: Enough - 0.33 closed live SeizedPropaganda
#8276 THEME: Enough - 0.36 closed live chipbennett
#8470 THEME: Enough - 0.37 closed live kobenland
#8685 THEME: Enough - 0.39 closed live kobenland
#8836 THEME: Enough - 0.40 closed live applextrent
#9159 THEME: Enough - 0.41 closed live nishasingh
#9352 THEME: Enough - 0.42 closed live max2501
#9482 THEME: Enough - 0.43 closed live max2501
#9615 THEME: Enough - 0.44 closed live nishasingh
#9802 THEME: Enough - 0.45 closed live nishasingh
#10964 THEME: Enough - 0.46 closed live Fingli
#11067 THEME: Enough - 0.47 closed live tskk
#11567 THEME: Enough - 0.49 closed live nishasingh
#11715 THEME: Enough - 0.51 closed closed-newer-version-uploaded amdhas
#11854 THEME: Enough - 0.52 closed closed-newer-version-uploaded amdhas
#11880 THEME: Enough - 0.54 closed live amdhas
#11884 THEME: Enough - 0.55 closed live nishasingh
#12083 THEME: Enough - 0.56 closed live downstairsdev
#12244 THEME: Enough - 0.60 closed live sixhours
#12319 THEME: Enough - 0.62 closed live shelob9
#12447 THEME: Enough - 0.63 closed live jcastaneda
#12710 THEME: Enough - 0.64 closed live tskk
#12945 THEME: Enough - 0.72 closed live devcorn
#13254 THEME: Enough - 0.73 closed live poena
#13536 THEME: Enough - 0.76 closed live emiluzelac
#14331 THEME: Enough - 0.77 closed live nishasingh
#15462 THEME: Enough - 0.83 closed live ZGani
#15761 THEME: Enough - 0.85 closed live tskk
#16313 THEME: Enough - 0.86 closed live bravokeyl
#16423 THEME: Enough - 0.87 closed not-approved robin90

(this ticket)

#16565 THEME: Enough - 0.88 closed live robin90
#16962 THEME: Enough - 0.90 closed live jcastaneda
#16998 THEME: Enough - 0.91 closed live tskk
#18290 THEME: Enough - 0.92 closed live catchthemes
#18340 THEME: Enough - 0.93 closed live robin90
#18386 THEME: Enough - 0.94 closed live tskk
#18659 THEME: Enough - 0.95 closed live poena
#20219 THEME: Enough - 0.96 closed live karmatosed
#20286 THEME: Enough - 0.97 closed live catchthemes
#20475 THEME: Enough - 0.98 closed live catchthemes
#20925 THEME: Enough - 1.02 closed live catchthemes
#21823 THEME: Enough - 1.05 closed live poena
#21936 THEME: Enough - 1.06 closed live karmatosed
#22000 THEME: Enough - 1.08 closed live jcastaneda
#22031 THEME: Enough - 1.10 closed live karmatosed
#24145 THEME: Enough – 1.11 closed live jcastaneda
#24449 THEME: Enough – 1.12 closed live karmatosed
#27181 THEME: Enough – 1.13 closed live jcastaneda
#31712 THEME: Enough – 1.14 closed live themetracbot
#31919 THEME: Enough – 1.15 closed live themetracbot
#40174 THEME: Enough – 1.20 closed live themetracbot
#40206 THEME: Enough – 1.22 closed live themetracbot
#42140 THEME: Enough – 1.23 closed live themetracbot
#47566 THEME: Enough – 1.24 closed live themetracbot
#48223 THEME: Enough – 1.25 closed live themetracbot


https://themes.svn.wordpress.org/enough/0.87/screenshot.png

Change History (7)

#1 @robin90
4 years ago

  • Owner set to robin90
  • Status changed from new to reviewing

#2 @robin90
4 years ago

Hi,

The theme help tab that you have said is fixed in this version (according to your changelog) is not showing up in the your theme options at all. Have a look.

Review Summary

  • Previous version of theme Approved
  • Issues in Diff-review
  • Ticket being resolved as NOT-APPROVED

Regards,
Rabin

#3 @robin90
4 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

#4 @nobita
4 years ago

Thank you for review

I had pointed out helptab is not working, I confirm again

Chrome 32.0.1700.107 m works correctry
Firefox26 works correctry
Firefox27 works correctry
Safari5.1.7 works correctry
Opera18.0 works correctry

WordPress version 3.8.1
PHP Version 5.4.21 Server API CGI/FastCGI

Screenshot
http://www.tenman.info/wp3/enough/files/enough-help-snapshot.png

Issues, could you point out a little more specific?

#5 @nobita
4 years ago

not showing up in the your theme options at all.

It shows at wp-admin/themes.php when live enough.

Last edited 4 years ago by nobita (previous) (diff)

#6 @robin90
4 years ago

Hi,

Sorry about this but I was trying to find the help tab in your options page as this was the appropriate place for such information. But you seemed to hook it at themes.php
I have asked about this to other admins if this is appropriate or not. Will inform you after hearing what they have to say about this. Sorry for the confusion.

Rabin

#7 @robin90
4 years ago

Hi,

This is what Chip had to say.

You can hook into the contextual help for the Theme-defined settings page. I don't see any reason, need, or benefit of hooking into the contextual help for themes.php directly.

So it seems their is no tight rule for not using it. So if you want the same that's fine
Also,
Please fix this required issue

  • <title> includes wp_title() only, and any modifications, if included, are added via wp_title filter. Filtered content uses get_bloginfo() as appropriate if displaying site title, description, etc.

RECOMMENDED: Possible variable $enough_description found in translation function in functions.php. Translation function calls must NOT contain PHP variables.

Line 2142: , ( $enough_description ,'enough' )

You can now upload the next version fixing the issues. You can ping me and I will be happy to approve it.

Rabin

Note: See TracTickets for help on using tickets.