WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#16687 closed theme (live)

THEME: Wilson - 1.04

Reported by: Anlino Owned by: ZGani
Priority: new theme Keywords: theme-wilson
Cc: anders@…

Description

Wilson - 1.0

Watson is a simple, clean and responsive theme for personal sites and blogs. Features responsive design, retina-ready assets, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code.

Theme URL - http://www.andersnoren.se/teman/wilson-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/wilson/1.0
ZIP - https://wordpress.org/themes/download/wilson.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#16687 THEME: Wilson - 1.04 closed live ZGani

(this ticket)

#16753 THEME: Wilson - 1.05 closed live tskk
#16759 THEME: Wilson - 1.07 closed live tskk
#16769 THEME: Wilson - 1.08 closed live tskk
#16772 THEME: Wilson - 1.09 closed live jcastaneda
#16789 THEME: Wilson - 1.13 closed live tskk
#17421 THEME: Wilson - 1.15 closed live jcastaneda
#17862 THEME: Wilson - 1.17 closed live tskk
#19940 THEME: Wilson - 1.20 closed live woowthemes
#20503 THEME: Wilson - 1.21 closed live karmatosed
#26409 THEME: Wilson – 1.22 closed live karmatosed
#26769 THEME: Wilson – 1.23 closed live jcastaneda
#29514 THEME: Wilson – 1.24 closed live Otto42
#34025 THEME: Wilson – 1.25 closed live themetracbot
#34085 THEME: Wilson – 1.26 closed live themetracbot
#48626 THEME: Wilson – 1.27 closed live themetracbot
#48696 THEME: Wilson – 1.28 closed live themetracbot
#48697 THEME: Wilson – 1.29 closed live themetracbot
#48912 THEME: Wilson – 1.30 closed live themetracbot


https://themes.svn.wordpress.org/wilson/1.0/screenshot.png

Change History (8)

#1 @themetracbot
4 years ago

  • Summary changed from THEME: Wilson - 1.0 to THEME: Wilson - 1.01

Wilson - 1.01

wilson is a simple, clean and responsive theme for personal sites and blogs. Features responsive design, retina-ready assets, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code.

Theme URL - http://www.andersnoren.se/teman/wilson-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/wilson/1.01
ZIP - https://wordpress.org/themes/download/wilson.1.01.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wilson/1.0&new_path=/wilson/1.01

History:

Ticket Summary Status Resolution Owner
#16687 THEME: Wilson - 1.04 closed live ZGani

(this ticket)

#16753 THEME: Wilson - 1.05 closed live tskk
#16759 THEME: Wilson - 1.07 closed live tskk
#16769 THEME: Wilson - 1.08 closed live tskk
#16772 THEME: Wilson - 1.09 closed live jcastaneda
#16789 THEME: Wilson - 1.13 closed live tskk
#17421 THEME: Wilson - 1.15 closed live jcastaneda
#17862 THEME: Wilson - 1.17 closed live tskk
#19940 THEME: Wilson - 1.20 closed live woowthemes
#20503 THEME: Wilson - 1.21 closed live karmatosed
#26409 THEME: Wilson – 1.22 closed live karmatosed
#26769 THEME: Wilson – 1.23 closed live jcastaneda
#29514 THEME: Wilson – 1.24 closed live Otto42
#34025 THEME: Wilson – 1.25 closed live themetracbot
#34085 THEME: Wilson – 1.26 closed live themetracbot
#48626 THEME: Wilson – 1.27 closed live themetracbot
#48696 THEME: Wilson – 1.28 closed live themetracbot
#48697 THEME: Wilson – 1.29 closed live themetracbot
#48912 THEME: Wilson – 1.30 closed live themetracbot


https://themes.svn.wordpress.org/wilson/1.01/screenshot.png

#2 @themetracbot
4 years ago

  • Summary changed from THEME: Wilson - 1.01 to THEME: Wilson - 1.02

Wilson - 1.02

Wilson is a simple, clean and responsive theme for personal sites and blogs. Features responsive design, retina-ready assets, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code.

Theme URL - http://www.andersnoren.se/teman/wilson-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/wilson/1.02
ZIP - https://wordpress.org/themes/download/wilson.1.02.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wilson/1.01&new_path=/wilson/1.02

History:

Ticket Summary Status Resolution Owner
#16687 THEME: Wilson - 1.04 closed live ZGani

(this ticket)

#16753 THEME: Wilson - 1.05 closed live tskk
#16759 THEME: Wilson - 1.07 closed live tskk
#16769 THEME: Wilson - 1.08 closed live tskk
#16772 THEME: Wilson - 1.09 closed live jcastaneda
#16789 THEME: Wilson - 1.13 closed live tskk
#17421 THEME: Wilson - 1.15 closed live jcastaneda
#17862 THEME: Wilson - 1.17 closed live tskk
#19940 THEME: Wilson - 1.20 closed live woowthemes
#20503 THEME: Wilson - 1.21 closed live karmatosed
#26409 THEME: Wilson – 1.22 closed live karmatosed
#26769 THEME: Wilson – 1.23 closed live jcastaneda
#29514 THEME: Wilson – 1.24 closed live Otto42
#34025 THEME: Wilson – 1.25 closed live themetracbot
#34085 THEME: Wilson – 1.26 closed live themetracbot
#48626 THEME: Wilson – 1.27 closed live themetracbot
#48696 THEME: Wilson – 1.28 closed live themetracbot
#48697 THEME: Wilson – 1.29 closed live themetracbot
#48912 THEME: Wilson – 1.30 closed live themetracbot


https://themes.svn.wordpress.org/wilson/1.02/screenshot.png

#3 @ZGani
4 years ago

  • Owner set to ZGani
  • Status changed from new to reviewing

#4 @ZGani
4 years ago

Just a few issues need resolving before approval

Required:

  • global.js: Please explicitly declare the license and copyright of this file
  • style.css: A blanket license declaration is not acceptable - licenses and copyrights need to be explicitly declared as stated above. Please remove the line indicated below from this file
    All files, unless otherwise stated, are released under the GNU General Public License
    

Code Check

Required:

  • global.js: As theme does not support custom header the code for "Cool header image scroll" is redundant - please remove it from the file.
  • functions.php: The function wilson_load_style() should be hooked to wp_enqueue_scripts() and not wp_print_styles.
  • functions.php: Themes are required to use theme-slug ( or a reasonably unique slug) as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.) - The following need prefixing correctly.
    function cd_meta_box_add()
    function cd_meta_box_cc( $post )
    function cd_meta_box_save( $post_id )
    

Recommended:

  • functions.php: Other than the external Google fonts you do not need to register every stylesheet/script before enqueueing it - a direct enqueue is perfectly fine.

Theme Unit Test.

Recommended:

  • Post format video: WordPress TV video overflows its container - please look in to this.
  • Post with long title, title overflows its container causing a horizontal scroll bar to appear and thus breaks layout.

Although recommended, its highly advisable to fix the theme unit test issue for better end user experience.

Please fix these issues and upload a revised version for to conclude the review.

#5 @themetracbot
4 years ago

  • Summary changed from THEME: Wilson - 1.02 to THEME: Wilson - 1.03

Wilson - 1.03

Wilson is a clean, simple and responsive theme for personal sites and blogs. Features responsive design, retina-ready assets, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code. Included translations: Swedish/svenska.

Theme URL - http://www.andersnoren.se/teman/wilson-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/wilson/1.03
ZIP - https://wordpress.org/themes/download/wilson.1.03.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wilson/1.02&new_path=/wilson/1.03

History:

Ticket Summary Status Resolution Owner
#16687 THEME: Wilson - 1.04 closed live ZGani

(this ticket)

#16753 THEME: Wilson - 1.05 closed live tskk
#16759 THEME: Wilson - 1.07 closed live tskk
#16769 THEME: Wilson - 1.08 closed live tskk
#16772 THEME: Wilson - 1.09 closed live jcastaneda
#16789 THEME: Wilson - 1.13 closed live tskk
#17421 THEME: Wilson - 1.15 closed live jcastaneda
#17862 THEME: Wilson - 1.17 closed live tskk
#19940 THEME: Wilson - 1.20 closed live woowthemes
#20503 THEME: Wilson - 1.21 closed live karmatosed
#26409 THEME: Wilson – 1.22 closed live karmatosed
#26769 THEME: Wilson – 1.23 closed live jcastaneda
#29514 THEME: Wilson – 1.24 closed live Otto42
#34025 THEME: Wilson – 1.25 closed live themetracbot
#34085 THEME: Wilson – 1.26 closed live themetracbot
#48626 THEME: Wilson – 1.27 closed live themetracbot
#48696 THEME: Wilson – 1.28 closed live themetracbot
#48697 THEME: Wilson – 1.29 closed live themetracbot
#48912 THEME: Wilson – 1.30 closed live themetracbot


https://themes.svn.wordpress.org/wilson/1.03/screenshot.png

#6 @themetracbot
4 years ago

  • Summary changed from THEME: Wilson - 1.03 to THEME: Wilson - 1.04

Wilson - 1.04

Wilson is a clean, simple and responsive theme for personal sites and blogs. Features responsive design, retina-ready assets, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code. Included translations: Swedish/svenska.

Theme URL - http://www.andersnoren.se/teman/wilson-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/wilson/1.04
ZIP - https://wordpress.org/themes/download/wilson.1.04.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wilson/1.03&new_path=/wilson/1.04

History:

Ticket Summary Status Resolution Owner
#16687 THEME: Wilson - 1.04 closed live ZGani

(this ticket)

#16753 THEME: Wilson - 1.05 closed live tskk
#16759 THEME: Wilson - 1.07 closed live tskk
#16769 THEME: Wilson - 1.08 closed live tskk
#16772 THEME: Wilson - 1.09 closed live jcastaneda
#16789 THEME: Wilson - 1.13 closed live tskk
#17421 THEME: Wilson - 1.15 closed live jcastaneda
#17862 THEME: Wilson - 1.17 closed live tskk
#19940 THEME: Wilson - 1.20 closed live woowthemes
#20503 THEME: Wilson - 1.21 closed live karmatosed
#26409 THEME: Wilson – 1.22 closed live karmatosed
#26769 THEME: Wilson – 1.23 closed live jcastaneda
#29514 THEME: Wilson – 1.24 closed live Otto42
#34025 THEME: Wilson – 1.25 closed live themetracbot
#34085 THEME: Wilson – 1.26 closed live themetracbot
#48626 THEME: Wilson – 1.27 closed live themetracbot
#48696 THEME: Wilson – 1.28 closed live themetracbot
#48697 THEME: Wilson – 1.29 closed live themetracbot
#48912 THEME: Wilson – 1.30 closed live themetracbot


https://themes.svn.wordpress.org/wilson/1.04/screenshot.png

#7 @ZGani
4 years ago

  • Status changed from reviewing to approved

All issues have been resolved.

#8 @emiluzelac
4 years ago

  • Resolution set to live
  • Status changed from approved to closed

Note that <meta http-equiv="Content-type" content="text/html;charset=<?php bloginfo( 'charset' ); ?>"> does not exist in HTML5 and it will create issues for users.


Differences Between HTML 4.01 and HTML5
The scheme attribute is not supported in HTML5.

HTML5 has a new attribute, charset, which makes it easier to define charset:
HTML 4.01: <meta http-equiv="content-type" content="text/html; charset=UTF-8">
HTML5: <meta charset="UTF-8">


see

Note: See TracTickets for help on using tickets.