WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#16703 closed theme (not-approved)

THEME: Health-Lite - 1.1

Reported by: LizardThemes Owned by: ZGani
Priority: new theme Keywords: theme-health-lite
Cc: lz@…

Description

Health-Lite - 1.0

Health is a high-end website design which is sure to meet all your needs and requirements while building a professional website. This premium template includes a set of features, including different showroom sources, different layouts, slider effects, sharing and media options, nice CSS3 tricks, and also goes with unique widgets from Lizardthemes.

Theme URL - http://lizardthemes.com/health/
Author URL - http://lizardthemes.com/

SVN - https://themes.svn.wordpress.org/health-lite/1.0
ZIP - https://wordpress.org/themes/download/health-lite.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#16703 THEME: Health-Lite - 1.1 closed not-approved ZGani

(this ticket)


https://themes.svn.wordpress.org/health-lite/1.0/screenshot.png

Change History (14)

#1 @ZGani
4 years ago

  • Owner set to ZGani
  • Status changed from new to reviewing

#2 @ZGani
4 years ago

General Check.

Required:

  • Themes must declare copyright in the following format:
    Themename WordPress theme, Copyright (C) 2013 YOUR NAME or YOUR COMPANY NAME
    Themename WordPress theme is licensed under the GPL.
    
  • Themes must also explicitly declare license and copyright of any resources used in constructing the theme. i.e. scripts, images and fonts in the following format:
    Resource name here - ​http://resource.url/
    License: Distributed under the terms of the License Name
    Copyright: Author, authorurl.com
    

Code Check.

Required:

  • showroom.php & other files: Themes are required to use theme-slug ( or a reasonably unique slug) as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.)
  • showroom.php: Use wp_reset_postdata() rather than wp_reset_query(). Same for relatedposts.php.
  • searchform.php: Use esc_url(home_url( '/' )) instead of home_url( '/' )
  • dashboard.php: The section for Support is plugin territory - but the main concern is the collection of system data this script generates if a user should choose to use the option. Please remove this from the theme.
    <?php echo $_SERVER['SERVER_NAME']."\r\n"; ?>
    <?php echo $_SERVER['SERVER_SOFTWARE']."\r\n"; ?>
    <?php echo 'PHP '.phpversion()."\r\n"; ?>
    <?php echo $_SERVER["HTTP_USER_AGENT"]."\r\n"; ?>
    
  • settings.php: Custom Head Code section is also plugin territory and must be removed from the theme.
  • admin.php, settings.php or dashboard.php: I can not see how is the data being sanitized/validated on input
  • Themes are required to use a single settings array for all theme options - it seems that you are using 3 separate arrays (I say 3 as this is one of my week points and I shy away from settings/option pages - so please explain).
  • functions.php: health_register_theme_menus should be hooked to after_setup_theme and not init.
  • facebook.php: This script is plugin territory and must be removed from the theme.
  • socials.php: Data is not being sanitized/validated on input nor escaped correctly on output.

Post Installation.

Theme Check:

WARNING: The flexible-width and fixed-width tags changed to fluid-layout and fixed-layout tags in WordPress 3.8. Additionally, the responsive-layout tag was added. Please change to using one of the new tags.

RECOMMENDED: could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.

RECOMMENDED: Screenshot size should be 880x660, to account for HiDPI displays. Any 4:3 image size is acceptable, but 880x660 is preferred.

Theme Unit Test.

There seems to be no major unit test issues but I'd advise looking at how images are rendered in the sidebar - they seem stretched to me.

This is a full review and all required issues must be addressed and fixed before resubmitting for further consideration. You may want refer to the following resources to assist you in understanding the raised issues and fix them.

Resources to be used for testing...for reference and not as an indication of issues to any particular section!
Code Quality
Theme Test Unit Data
Theme Review Guidelines
Monster Widget plugin
Debug Bar plugin
Log Deprecated Notices
Theme Check Plugin
Debogger Plugin
Theme Development Guidelines
Next Post Link
Previous Post Link
Next Image Link
Previous Image Link

Will leave ticket open to facilitate a speedy follow up review - if you have any questions please feel free to ask in the comments.

Zulf.

#3 @ZGani
4 years ago

Need an update on the above raised issues - is a revised version with the fixes upcoming any time soon?

Keeping ticket open for the next 48hrs or will have to close as Not Approved.

#4 follow-up: @LizardThemes
4 years ago

Hi!
I can't find any notes about readme file in http://codex.wordpress.org/Theme_Development.
Custom Head Code in settings.php is needed for theme configuration. Is it possible to leave it there?

dashboard.php: The section for Support is plugin territory - but the main concern is the collection of system data this script generates if a user should choose to use the option. Please remove this from the theme.

It is our support for theme users. And we notify users that they can remove system information from the message, by unchecking option "Attach system details to the message". We would like to leave this option in the theme, because it realy helps to solve a lot of issues.

#5 in reply to: ↑ 4 @ZGani
4 years ago

Replying to LizardThemes:

Hi!
I can't find any notes about readme file in http://codex.wordpress.org/Theme_Development.

As noted in the review, this is a recommendation but is a preferred point of call for theme documentation.

Custom Head Code in settings.php is needed for theme configuration. Is it possible to leave it there?

I don't see how this has anything to do with theme configuration - it clearly state...

For example you can integrate your website with Google Analitics, by adding GA code to this field.

Which is and has been plugin territory for a long while now. So unfortunately no, the section has to be removed.

dashboard.php: The section for Support is plugin territory - but the main concern is the collection of system data this script generates if a user should choose to use the option. Please remove this from the theme.

It is our support for theme users. And we notify users that they can remove system information from the message, by unchecking option "Attach system details to the message". We would like to leave this option in the theme, because it realy helps to solve a lot of issues.

Having put emphasis on data collection (even if its by optin) does not take away from the fact that the script used for this is plugin territory and therefore can not be part of the theme! You are more than welcome to include a link to a contact page hosted on your site.

#6 @themetracbot
4 years ago

  • Summary changed from THEME: Health-Lite - 1.0 to THEME: Health-Lite - 1.1

Health-Lite - 1.1

Health is a high-end website design which is sure to meet all your needs and requirements while building a professional website. This premium template includes a set of features, including different showroom sources, different layouts, slider effects, sharing and media options, nice CSS3 tricks, and also goes with unique widgets from Lizardthemes.

Theme URL - http://lizardthemes.com/health/
Author URL - http://lizardthemes.com/

SVN - https://themes.svn.wordpress.org/health-lite/1.1
ZIP - https://wordpress.org/themes/download/health-lite.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/health-lite/1.0&new_path=/health-lite/1.1

History:

Ticket Summary Status Resolution Owner
#16703 THEME: Health-Lite - 1.1 closed not-approved ZGani

(this ticket)


https://themes.svn.wordpress.org/health-lite/1.1/screenshot.png

#7 follow-up: @ZGani
4 years ago

General Check.

Required:

  • Themes must declare copyright in the following format: Not Fixed!
    Themename WordPress theme, Copyright (C) 2013 YOUR NAME or YOUR COMPANY NAME
    Themename WordPress theme is licensed under the GPL.
    

Code check.

Required:

  • navigation.php: Scripts should not be hard coded in to template files - you need to wrap the scrip in a function and then call that function in the location the script is required.
  • showroom.php (now health-showroom.php): Use wp_reset_postdata() rather than wp_reset_query(). Not Fixed!
  • The prefix issue has not been fully addressed - like $slide should be prefixed correctly. Not Fixed!
  • default.php: Again, please use one single unique prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.) - you are using lz_ as a prefix here instead of health_
  • author.php: The function health_records_showroom() invokes a custom meta box to select a page template - WordPress already has this functionality built in and themes are required to support Core functions at all times.
  • admin.php: Please remove the function health_sendmail() and all related code from the theme. From what I can see most of the functions/code in this file fall outside of the theme functionality in relation to content presentation - it all very much fall under the plugin territory requirements.
  • settings.php: Themes are required to be self contained i.e. hotlinking/framing is not allowed - the themes page in the options page is an iframe with content from your site and is not allowed. Please remove this from the theme. You may include the images in the theme and construct the page from within if you wish.
  • I still can not see how and where data is being sanitized/validated on input!

Post Installation.

Theme Check: PASS!

The following recommendations were made by the plugin and need your attention

  • RECOMMENDED: Screenshot size should be 880x660, to account for HiDPI displays. Any 4:3 image size is acceptable, but 880x660 is preferred.
  • RECOMMENDED: Possible variable $post found in translation function in author.php. Translation function calls must NOT contain PHP variables.

Theme Unit Test.

Required:

  • Settings if implemented must function correctly - setting the slider to "off" has no effect i.e. the empty slider section still appears on the front end.
  • Please set all external links on the "Support" section of the options page to open in a new tab/window. This applies to all other links that are not related to the end user's internal linking system.

Recommended:

  • You may want to consider adding an option to turn infinity scroll off just in case users need/want to.

No further content issues detected.

The items marked as Required and the Not Fixed issues from previous review need addressing before the theme can be approved.

#8 @ZGani
4 years ago

Any feedback on this?

I may have to close the ticket due to the length of time its taking for the required fixes.

#9 in reply to: ↑ 7 @LizardThemes
4 years ago

Hello!
Thank you for your comments. At this moment we are preparing the theme for new upload. But we have some questions. First of all, can you please check that you are reviewing latest upload?

"Themes must declare copyright in the following format: Not Fixed!"

But this is fixed, you can see it in file license.txt (https://themes.svn.wordpress.org/health-lite/1.1/license.txt)

showroom.php (now health-showroom.php): Use wp_reset_postdata() rather than wp_reset_query(). Not Fixed!

This issue is fixed too (https://themes.svn.wordpress.org/health-lite/1.1/health-showroom.php)

The prefix issue has not been fully addressed - like $slide should be prefixed correctly. Not Fixed!

Could you give me more details about it? As I know only custom functions must use a prefix. I know it from the previous reviews, also all what I found in wordpress codex is:
All the functions in your Plugin need to have unique names that are different from functions in the WordPress core, other Plugins, and themes. For that reason, it is a good idea to use a unique function name prefix on all of your Plugin's functions.

author.php: The function health_records_showroom() invokes a custom meta box to select a page template - WordPress already has this functionality built in and themes are required to support Core functions at all times.

This page template used for choose which sidebars must be displayed on the page. WordPress does not support it by default.

settings.php: Themes are required to be self contained i.e. hotlinking/framing is not allowed - the themes page in the options page is an iframe with content from your site and is not allowed. Please remove this from the theme. You may include the images in the theme and construct the page from within if you wish.

Can you help me to find information about it on codex? As I know WordPress Theme Check notice about it just as INFO, and I can leave it in the theme.

navigation.php: Scripts should not be hard coded in to template files - you need to wrap the scrip in a function and then call that function in the location the script is required.

As I know from here (https://codex.wordpress.org/Using_Javascript) WordPress just recommends to use wp_enqueue_script(), but we prefere to use script as we do it now. Because we need to combine PHP and JavaScript in that place.

All the rest will be fixed as soon as possible.

#11 @ZGani
4 years ago

This page template used for choose which sidebars must be displayed on the page. WordPress does not support it by default.

What you have there are "Post templates" and not "Page Templates"
Page templates are supported - see here: http://codex.wordpress.org/Page_Templates
Custom Post Templates however are not supported by core and the function for those would fall under the plugin territory - I'll have to confirm this with one of the Admins.

Please confirm that is the case and I'll cc an Admin to have their input before you upload a revised version.

#12 follow-up: @LizardThemes
4 years ago

Yes you are right. I think we could name it just "Sidebars". But I don't think that it is plugin territory, because it works with sidebars of the theme, and it affects the appearance of the theme.

#13 in reply to: ↑ 12 @ZGani
4 years ago

Replying to LizardThemes:

Yes you are right. I think we could name it just "Sidebars". But I don't think that it is plugin territory, because it works with sidebars of the theme, and it affects the appearance of the theme.

Sidebars would work for me - marked as sidebar location for clarity I don't see any issues with that.

If you can get those issues that need addressing sorted and upload a revised version I'm good to continue with the review.

Regards,
Zulf

#14 @ZGani
4 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

I'm going to have to close this for now as it has been 2 week since my last review with no revised version with fixes being re-submitted.

Please feel free to resubmit when you are ready and I'll try to pick up from where I left of or one of the other reviewers will take over the review.

Regards,
Zulf

Note: See TracTickets for help on using tickets.