WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#16715 closed theme (not-approved)

THEME: Fitness Trainer - 1.9.2

Reported by: kais99 Owned by: cyberchimpscode
Priority: new theme Keywords: theme-fitness-trainer
Cc: qaiser.bashir@…

Description

Fitness Trainer - 1.0

A responsive theme for fitness trainer / personal trainer. Theme which adapts automatically to your tablets and mobile devices. Theme is easily customizable with numerous theme options. Features include option to upload your own logo & favicon, Google fonts and select font size, family and colours. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready.

Theme URL - http:/fitnessdesign360.com
Author URL - http:/kaisweb.com

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.0
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.0/screenshot.png

Attachments (1)

fitness-trainer.pot (4.8 KB) - added by cyberchimpscode 4 years ago.

Download all attachments as: .zip

Change History (58)

#1 @cyberchimpscode
4 years ago

  • Owner set to cyberchimpscode
  • Status changed from new to reviewing

#2 @cyberchimpscode
4 years ago

Required

  1. You have to enter a valid Author URL.
  2. You have to enter a valid Theme URL.
  3. Screenshot size should be 880x660, to account for HiDPI displays.
  4. There should be a readme.txt. not readme.md.
  5. Script tags should be included on wp_enqueue_scripts or admin_enqueue_scripts instead of embedded directly at file footer.php.
  6. Script tags should be included on wp_enqueue_scripts or admin_enqueue_scripts instead of embedded directly at file header.php.
  7. Styles should be included on wp_enqueue_scripts or admin_enqueue_scripts instead of embedded directly at file header.php.
  8. The only possible spelling of WordPress is with capital W and capital P. at file admin/ReduxCore/extensions/edd/edd_license/EDD_SL_Plugin_Updater.php, admin/ReduxCore/framework.php, admin/ReduxCore/inc/fields/editor/field_editor.php, admin/ReduxCore/inc/fields/typography/field_typography.php and admin/ReduxCore/inc/fields/select_image/field_select_image.php.
  9. Styles should be included on wp_enqueue_scripts or admin_enqueue_scripts instead of embedded directly at file admin/ReduxCore/inc/fields/typography/field_typography.php.
  10. Script tags should be included on wp_enqueue_scripts or admin_enqueue_scripts instead of embedded directly at file admin/ReduxCore/inc/tracking.php.
  11. wp_footer call should be right before the closing body tag. at file footer.php.
  12. Possible hard-coded links were found in the file options-config.php, footer.php.

#3 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.0 to THEME: Fitness Trainer - 1.1

Fitness Trainer - 1.1

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Theme is easily customizable with numerous theme options. Features include option to upload your own logo & favicon, Google fonts and select font size, family and colours. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://fitnessdesign360.com/

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.1
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.0&new_path=/fitness-trainer/1.1

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.1/screenshot.png

#4 @cyberchimpscode
4 years ago

Required

  1. Styles should be included on wp_enqueue_scripts or admin_enqueue_scripts instead of embedded directly at file admin/ReduxCore/inc/fields/typography/field_typography.php.
  2. Script tags should be included on wp_enqueue_scripts or admin_enqueue_scripts instead of embedded directly at file admin/ReduxCore/inc/tracking.php.
  3. I got an error when viewing the frontend except the site title and tag ine. Warning: Illegal string offset 'url' in example.com\wp-content\themes\fitness-trainer\header.php on line 28
  4. Both menus are showing even if some one selects only the Primary menu under Appearance > Menus.

#5 @kais99
4 years ago

Hi There

I have fixed all issues. I am going to upload theme again.

Thanks,
Qaiser

#6 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.1 to THEME: Fitness Trainer - 1.2

Fitness Trainer - 1.2

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Theme is easily customizable with numerous theme options. Features include option to upload your own logo & favicon. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://fitnessdesign360.com/

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.2
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.1&new_path=/fitness-trainer/1.2

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.2/screenshot.png

#7 @cyberchimpscode
4 years ago

  1. Undefined function found in file: wp_get_active_network_plugins in /sysinfo.php

$plugins = wp_get_active_network_plugins();

  1. There are some empty string has been passed to a gettext function in framework.php and options-config.php.
  2. Here is another issue now. When there is less contents added to the page, the footer goes up leaving space at the bottom. See the screenshot: http://imgur.com/94mF2HI
  3. On the above screenshot you can see that if mot=re menu items are added, the menu becomes to 2 rows but the container will not expand with that.

#8 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.2 to THEME: Fitness Trainer - 1.3

Fitness Trainer - 1.3

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://fitnessdesign360.com/

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.3
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.2&new_path=/fitness-trainer/1.3

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.3/screenshot.png

#9 @kais99
4 years ago

Hi
I used Redux Framework for theme settings, but I guess it doesn't comply with WordPress theme T&C. So I have removed it from the theme, I will try to find something different for the next version. I think 'Theme setting' option is very good for end user, they can upload logos and change theme very easily.

I might try 'Options Framework' for next version. Do you know any good framework for theme settings?

Best Regards,
Qaiser

#10 @cyberchimpscode
4 years ago

Required

  • You do not have valid RTL support to be able to use the rtl-language-support tag
  • Please remove the layouts folder as it is not needed.
  • The prefix and text domain should be fitness_trainer/fitness-trainer and not personal-trainer.
  • Please state the licence of all of the assets(css, js, fonts and images) and php in the readme
  • You need to use fitness_trainer_add_editor_styles() instead of my_theme_add_editor_styles()
  • You do not need to prefix the enqueue handles of standard scripts and css that can be used in multiple places.
  • Please remove custom-header.php as you are not using it. Also //require get_template_directory() . '/inc/custom-header.php'; from the functions.php

Notes

  • Redux Framework should be fine with WordPress licensing as it is GPL. Depending on how many options and how you want to display the option you might want to use another framework or just use the settings API. A number of themes also use the Options Framework.

u

Last edited 4 years ago by cyberchimpscode (previous) (diff)

#11 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.3 to THEME: Fitness Trainer - 1.4

Fitness Trainer - 1.4

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://kaisweb.co.uk

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.4
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.3&new_path=/fitness-trainer/1.4

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.4/screenshot.png

#12 @kais99
4 years ago

Thanks for the feedback.

You do not have valid RTL support to be able to use the rtl-language-support tag Fixed
Please remove the layouts folder as it is not needed. Fixed
The prefix and text domain should be fitness_trainer/fitness-trainer and not personal-trainer. Fixed
Please state the licence of all of the assets(css, js, fonts and images) and php in the readme
You need to use fitness_trainer_add_editor_styles() instead of my_theme_add_editor_styles() Fixed
You do not need to prefix the enqueue handles of standard scripts and css that can be used in multiple places. Fixed
Please remove custom-header.php as you are not using it. Also require get_template_directory() . '/inc/custom-header.php'; from the functions.php Fixed

Do we really need to state the licence of all of the assets(css, js, fonts and images)? I have downloaded couple of Bootstrap themes from theme directory, none of them has list of all the files and their licence. Everything used in this theme is open source, GNU, MIT etc.

Best Regards,
Qaiser

#13 @cyberchimpscode
4 years ago

The themes should include the licences in the readme for two reasons. It makes it easier for the reviewer to check the licences and then also for the user. You also don't have any attribution that the theme is built using _s.

I will continue the review later...

#14 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.4 to THEME: Fitness Trainer - 1.5

Fitness Trainer - 1.5

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://kaisweb.co.uk

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.5
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.4&new_path=/fitness-trainer/1.5

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.5/screenshot.png

#15 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.5 to THEME: Fitness Trainer - 1.6

Fitness Trainer - 1.6

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://kaisweb.co.uk

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.6
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.5&new_path=/fitness-trainer/1.6

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.6/screenshot.png

#16 @kais99
4 years ago

I have added file license details in readme.txt and attribution that the theme is built using _s in readme.txt and style.css.

Best Regards,
Qaiser

#17 @cyberchimpscode
4 years ago

Thanks - Royalty Free is not GPL comaptable. To be compatible the licence needs to give the same rights as GPL - http://choosealicense.com/licenses/gpl-v2/

#18 @kais99
4 years ago

Since I am not using 'theme settings framework' in this version of the theme so those social icons are not in use. I would remove them and re-upload the theme shortly.

Thanks,
Q

#19 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.6 to THEME: Fitness Trainer - 1.7

Fitness Trainer - 1.7

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://kaisweb.co.uk

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.7
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.6&new_path=/fitness-trainer/1.7

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.7/screenshot.png

#20 @cyberchimpscode
4 years ago

Required

  • You need to prefix skip-link-focus-fix, navigation, google-font script handles.
  • The theme does not look like the screenshot on activation.
  • Please remove custom-header.php as it does not seem to be used.

u

#21 @kais99
4 years ago

Hi There
To be honest, I don't know what you are up to. It's about 4 weeks and still there is no sign of theme approval. There are many things you could mention long time ago, but you save them till end. for example point 1 and 3 in your last message.

Regarding your point 2: As I mentioned in the read more file, you need slider and shortcode plugin to get the similar content area. Header and footer are exactly same as before.

I have published theme on the site and I am getting good response plus I reply to any support question. So far all good but I don't understand why you are dragging it.

I used an open source theme setting framework which could be very good for users but you mentioned so many issues in it that I had to remove it. There are many themes using it.

Please let me know if you think this theme shouldn't be approved and appear in the theme directory. Let's not waste our time.

I'll work on your list of issues tomorrow.

Regards,
Qaiser

#22 @cyberchimpscode
4 years ago

I am sorry that it dragged out a bit. I write the issues as I see them. I looked at the code multiple times as I do not see all of the issues in the first go. I do not get anything from not approving your theme but in the contrary. We reviewers get rewarded on the number of reviews that we are able to do but at the same time making sure the themes follow the guidelines.

The screenshot needs to be a “reasonable facsimile” of the Theme after it is initially activated with default options.

These are the last issues that I have seen. Once they are fixed I can approve the theme.

#23 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.7 to THEME: Fitness Trainer - 1.8

Fitness Trainer - 1.8

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://kaisweb.co.uk

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.8
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.7&new_path=/fitness-trainer/1.8

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.8/screenshot.png

#24 @kais99
4 years ago

Hi

I have made the changes.

I have taken the new screenshot. It look header and footer exactly like that and content area is done all from the wordpress backend using shortcode plugin. I hope it's Ok.

Many Thanks,
Qaiser

#25 @cyberchimpscode
4 years ago

  • Status changed from reviewing to approved

#26 @emiluzelac
4 years ago

  • Status changed from approved to reopened

When Theme uses "translation-ready" tags, all strings must be translatable:

<div class="copyright_wrapper">
	   	<div class="container copyright">
	   			&copy; 2014 </div>
			   					  
			   		
	   		
	   	</div><!-- footer -->

Also:

Text Domain: tersonaltrainer

it should be more like personal-trainer.

  • fitness-trainer.pot still refers to _s
  • Date in footer area must not be hardcoded.
  • Screenshot image license is not noted. All images must be GPL-Compatible.
  • wp_enqueue_style( 'google-font', "http://fonts.googleapis.com/css?family=Open+Sans|Dosis:400,800" ); will produce an error if user has HTTPS.
  • No need to use wp_enqueue_script('jquery'); when calling jQuery in array, just go with:

wp_enqueue_script( 'bootstrap', get_template_directory_uri() . '/assets/js/bootstrap.min.js', array( 'jquery' ), '', true );


Sorry, we need to reopen the ticket :)

#27 @kais99
4 years ago

Hi

No problem, Thanks for the feedback. I am learning lots of new things, I should have posted a theme 3 years ago.

I'll fix those issues today and get back to you.

Many Thanks,
Qaiser

#28 @cyberchimpscode
4 years ago

  • Status changed from reopened to reviewing

#29 @cyberchimpscode
4 years ago

@Emil I mentioned the point about loading jquery as dependency in other reviews and Chip told me it was needed. I don't think it is in the guidelines but I agree with you it is best practice. What do you recommend?

u

#30 @emiluzelac
4 years ago

jQuery should load only when needed to. And yes it is not in the guidelines, just like many other requirements, recommendations and/or best practices.

This is something I learned from Nacin long time ago.

It's your review Ulrich :)

#31 @kais99
4 years ago

Hi Emil & Cyberchimpscode

What does it mean 'fitness-trainer.pot still refers to _s'? How can I correct it?

Regarding the enqueue jquery: I am using jQuery superfish menu plugin so I think it was alright to load jquery on all theme files. Anyway now I have used it as you mentioned.

Many Thanks,
Qaiser


#33 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.8 to THEME: Fitness Trainer - 1.9

Fitness Trainer - 1.9

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://kaisweb.co.uk

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.9
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.8&new_path=/fitness-trainer/1.9

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.9/screenshot.png

#34 @kais99
4 years ago

Hi There
I have fixed all issues.

fitness-trainer.pot still refers to _s : Fixed.
Date in footer area must not be hardcoded. Fixed.
Screenshot image license is not noted. All images must be GPL-Compatible. I clearly stated in readmore 'Unless otherwise specified, all the theme files, scripts and images are licensed under GNU General Public License version 2'
wp_enqueue_style( 'google-font', "http://fonts.googleapis.com/css?family=Open+Sans|Dosis:400,800" ); will produce an error if user has HTTPS. Fixed
No need to use wp_enqueue_script('jquery'); when calling jQuery in array, just go with: Fixed

Best Regards,
Qaiser

#35 @cyberchimpscode
4 years ago

Required

  • This is how you enqueue google fonts: https://gist.github.com/grappler/9728526 Please aslso prefix the handle
  • The text domain in the style.css header is incorrect Text Domain: tersonaltrainer
  • Please update the pot file
  • Please delete the js/ folder as you do not seem to be using the files.
  • You still have some text domains that are personal-trainer. Please correct it.
  • Please delete the RTL.css and you are not using it.
  • Please change the text in the readme from -- Plugin required -- to -- Plugin recommended --

#36 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.9 to THEME: Fitness Trainer - 1.9.1

Fitness Trainer - 1.9.1

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://kaisweb.co.uk

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.9.1
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.9.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.9&new_path=/fitness-trainer/1.9.1

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.9.1/screenshot.png

#37 @kais99
4 years ago

This is how you enqueue google fonts: https://gist.github.com/grappler/9728526 Please aslso prefix the handle: Fixed. Many Thanks for the link.
The text domain in the style.css header is incorrect Text Domain: tersonaltrainer Fixed
Please update the pot file Fixed, I have update theme name instead of _s
Please delete the js/ folder as you do not seem to be using the files. Done, I left those there before so if any other developer download the theme, he could easily start using those features.
You still have some text domains that are personal-trainer. Please correct it. Fixed
Please delete the RTL.css and you are not using it. Done
Please change the text in the readme from -- Plugin required -- to -- Plugin recommended -- Done

Thanks,
Qaiser

#38 @cyberchimpscode
4 years ago

You need to generate the POT file and not just change the theme names. The POT file conatins all of the strings in you theme. You can read up more on it here. https://make.wordpress.org/docs/plugin-developer-handbook/15-internationalization/localization/

The text domain in the style.css header needs to be the same as that used on the strings. So it needs to be with a small "f". Text Domain: fitness-trainer

#39 @kais99
4 years ago

Hi

POT file has all the strings used in the theme. Did you notice anything missing? As far as I know, there is nothing wrong with POT file.

Thanks,
Qaiser

#40 @cyberchimpscode
4 years ago

Compare the attached file with the your own POT file and you will see the difference.

#41 @kais99
4 years ago

Hi
Many Thanks for this. I can see there are many differences specially line numbers. Is there an online tool to generate theme POT file, I searched and found only for plugins.

I'll submit theme bit later.

Thanks,
Qaiser

#42 @themetracbot
4 years ago

  • Summary changed from THEME: Fitness Trainer - 1.9.1 to THEME: Fitness Trainer - 1.9.2

Fitness Trainer - 1.9.2

A responsive theme for fitness trainer / personal trainer, personal training studios, health and fitness clubs, personal fitness blogs, or any other health related website/blog. Theme which adapts automatically to your tablets and mobile devices. Supports popular plugins like Breadcrumb NavXT, WP-PageNavi and Contact Form 7. It is also translation ready. It's responsive, customizable and totally awesome.

Theme URL - http://fitnessdesign360.com/fitness-trainer-free-wordpress-theme/
Author URL - http://kaisweb.co.uk

SVN - https://themes.svn.wordpress.org/fitness-trainer/1.9.2
ZIP - https://wordpress.org/themes/download/fitness-trainer.1.9.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/fitness-trainer/1.9.1&new_path=/fitness-trainer/1.9.2

History:

Ticket Summary Status Resolution Owner
#16715 THEME: Fitness Trainer - 1.9.2 closed not-approved cyberchimpscode

(this ticket)


https://themes.svn.wordpress.org/fitness-trainer/1.9.2/screenshot.png

#43 @cyberchimpscode
4 years ago

  • Status changed from reviewing to approved

This is what I used. https://github.com/blazersix/grunt-wp-i18n

The way for plugins and themes are quite similar.

APPPROVED

u

#44 @chipbennett
4 years ago

How does the user create the layout/appearance shown in the screenshot? I don't see any custom page template or Theme options or any other way for the user to accomplish it.

#45 @kais99
4 years ago

Hi

By using recommended plugins we can easily achieve the screenshot layout. There is a 'front-page.php' file (for homepage) for full width page without sidebar.
You can view a demo here
http://demo.fitnessdesign360.com/personaltrainer/

Thanks,
Qaiser

#46 @chipbennett
4 years ago

  • Status changed from approved to reopened

#47 @chipbennett
4 years ago

  • Status changed from reopened to reviewing

If the layout shown in your screenshot is only achievable by using Plugins, then you will need to revise your screenshot, as it is not a reasonable facsimile of the Theme in its default configuration.

Alternatively, you could incorporate those elements directly into your Theme. I don't see anything in your screenshot that can't be incorporated directly into the Theme.

#48 @kais99
4 years ago

Thanks for the feedback. My plan was to add theme settings in later version once theme approved but there is no harm in adding it now. I would add those elements to the theme, it will make users life easy.
Do you recommend any 'theme settings' framework? I used 'Redux', but I guess it's not compatible with the WordPress theme T&C (read cyberchimpscode feedback above).

Regards,
Qaiser

#49 @chipbennett
4 years ago

We don't recommend (i.e. endorse) any particular Settings API framework. Devin Price's Options Framework is used frequently, with good success, though.

That said: you probably don't even need to use Theme settings in this case.

For the slider, I would recommend taking advantage of the "sticky" post meta, or perhaps using the Image post format.

For the content boxes, if they're just pulling data from static pages, I would make a custom widget that pulls the featured image, title, and excerpt from a user-selected page. (Hint: you can add "Excerpt" support for the static page object, to allow the user to create nicely formatted page excerpts.) Then, just make that area a dynamic sidebar, and you're all set.

#50 @kais99
4 years ago

Cool. Thanks for the advice.
I think I can create some shortcodes as well.

I'll submit a new version in next week or so.

Thanks,
Qaiser

#51 @chipbennett
4 years ago

Shortcodes?

#52 @kais99
4 years ago

http://codex.wordpress.org/Shortcode_API
Below the homepage slider, there are three columns with some content. At the moment I am using bootstrap shortcode plugin. So I might code something similar or the way you suggested but as shortcode. What do you think?

I like your widget idea as well using some area on homepage as dynamic sidebar and then user can drop whatever he/she likes in it to display on the homepage.

Q

#53 @chipbennett
4 years ago

How/where would the user define/add the shortcode(s)?

#54 @kais99
4 years ago

I'll add a button in the editor. User will click on it to see all shortcodes and then click and insert.
http://code.tutsplus.com/tutorials/guide-to-creating-your-own-wordpress-editor-buttons--wp-30182

Q

#55 @chipbennett
4 years ago

That's what I was afraid of. Post-content shortcodes are Plugin territory, and can't be added to Themes.

#56 @kais99
4 years ago

Thanks for letting me know. It would save my a lot of time.

Qaiser

#57 @chipbennett
4 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing for now. Feel free to resubmit when you're ready.

Note: See TracTickets for help on using tickets.