WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#16789 closed theme (live)

THEME: Wilson - 1.13

Reported by: Anlino Owned by: tskk
Priority: theme update Keywords: theme-wilson
Cc: anders@…, chipbennett

Description

Wilson - 1.10

Wilson is a clean, simple and responsive theme for personal sites and blogs. Features responsive design, retina-ready assets, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code. Included translations: Swedish/svenska.

Theme URL - http://www.andersnoren.se/teman/wilson-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/wilson/1.10
ZIP - https://wordpress.org/themes/download/wilson.1.10.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wilson/1.09&new_path=/wilson/1.10

History:

Ticket Summary Status Resolution Owner
#16687 THEME: Wilson - 1.04 closed live ZGani
#16753 THEME: Wilson - 1.05 closed live tskk
#16759 THEME: Wilson - 1.07 closed live tskk
#16769 THEME: Wilson - 1.08 closed live tskk
#16772 THEME: Wilson - 1.09 closed live jcastaneda
#16789 THEME: Wilson - 1.13 closed live tskk

(this ticket)

#17421 THEME: Wilson - 1.15 closed live jcastaneda
#17862 THEME: Wilson - 1.17 closed live tskk
#19940 THEME: Wilson - 1.20 closed live woowthemes
#20503 THEME: Wilson - 1.21 closed live karmatosed
#26409 THEME: Wilson – 1.22 closed live karmatosed
#26769 THEME: Wilson – 1.23 closed live jcastaneda
#29514 THEME: Wilson – 1.24 closed live Otto42
#34025 THEME: Wilson – 1.25 closed live themetracbot
#34085 THEME: Wilson – 1.26 closed live themetracbot


https://themes.svn.wordpress.org/wilson/1.10/screenshot.png

Change History (14)

#1 @tskk
4 years ago

  • Owner set to tskk
  • Status changed from new to reviewing

#2 @tskk
4 years ago

  • Cc chipbennett added

Chip, are themes allowed to have iframes in template files?
https://themes.trac.wordpress.org/browser/wilson/1.10/content-video.php?rev=31938

#3 @chipbennett
4 years ago

Isn't there an oEmbed for that?

I think that falls under supporting core implementation of a feature (in this case: video-embedding). Rather than generate hard-coded IFrames, the Theme should simply output the generated URL, and let oEmbed handle it from there.

#4 @tskk
4 years ago

My thoughts as well.
@Anlino, if you need the video to be shown at a specific location, use [video src="video-source.mp4"] shortcode.
https://codex.wordpress.org/Video_Shortcode

#5 @themetracbot
4 years ago

  • Summary changed from THEME: Wilson - 1.10 to THEME: Wilson - 1.11

Wilson - 1.11

Wilson is a clean, simple and responsive theme for personal sites and blogs. Features responsive design, retina-ready assets, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code. Included translations: Swedish/svenska.

Theme URL - http://www.andersnoren.se/teman/wilson-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/wilson/1.11
ZIP - https://wordpress.org/themes/download/wilson.1.11.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wilson/1.10&new_path=/wilson/1.11

History:

Ticket Summary Status Resolution Owner
#16687 THEME: Wilson - 1.04 closed live ZGani
#16753 THEME: Wilson - 1.05 closed live tskk
#16759 THEME: Wilson - 1.07 closed live tskk
#16769 THEME: Wilson - 1.08 closed live tskk
#16772 THEME: Wilson - 1.09 closed live jcastaneda
#16789 THEME: Wilson - 1.13 closed live tskk

(this ticket)

#17421 THEME: Wilson - 1.15 closed live jcastaneda
#17862 THEME: Wilson - 1.17 closed live tskk
#19940 THEME: Wilson - 1.20 closed live woowthemes
#20503 THEME: Wilson - 1.21 closed live karmatosed
#26409 THEME: Wilson – 1.22 closed live karmatosed
#26769 THEME: Wilson – 1.23 closed live jcastaneda
#29514 THEME: Wilson – 1.24 closed live Otto42
#34025 THEME: Wilson – 1.25 closed live themetracbot
#34085 THEME: Wilson – 1.26 closed live themetracbot


https://themes.svn.wordpress.org/wilson/1.11/screenshot.png

#6 @tskk
4 years ago

You need to remove all iframes.

#7 @themetracbot
4 years ago

  • Summary changed from THEME: Wilson - 1.11 to THEME: Wilson - 1.12

Wilson - 1.12

Wilson is a clean, simple and responsive theme for personal sites and blogs. Features responsive design, retina-ready assets, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code. Included translations: Swedish/svenska.

Theme URL - http://www.andersnoren.se/teman/wilson-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/wilson/1.12
ZIP - https://wordpress.org/themes/download/wilson.1.12.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wilson/1.11&new_path=/wilson/1.12

History:

Ticket Summary Status Resolution Owner
#16687 THEME: Wilson - 1.04 closed live ZGani
#16753 THEME: Wilson - 1.05 closed live tskk
#16759 THEME: Wilson - 1.07 closed live tskk
#16769 THEME: Wilson - 1.08 closed live tskk
#16772 THEME: Wilson - 1.09 closed live jcastaneda
#16789 THEME: Wilson - 1.13 closed live tskk

(this ticket)

#17421 THEME: Wilson - 1.15 closed live jcastaneda
#17862 THEME: Wilson - 1.17 closed live tskk
#19940 THEME: Wilson - 1.20 closed live woowthemes
#20503 THEME: Wilson - 1.21 closed live karmatosed
#26409 THEME: Wilson – 1.22 closed live karmatosed
#26769 THEME: Wilson – 1.23 closed live jcastaneda
#29514 THEME: Wilson – 1.24 closed live Otto42
#34025 THEME: Wilson – 1.25 closed live themetracbot
#34085 THEME: Wilson – 1.26 closed live themetracbot


https://themes.svn.wordpress.org/wilson/1.12/screenshot.png

#8 @tskk
4 years ago

Sorry for the delay, forgot about the ticket.
I don't understand the logic here :

	                <?php if (strpos($videourl,'.mp4') !== true) : ?>
	                       
	                        <?php 
	                       
	                                $embed_code = wp_oembed_get($videourl); 
	                               
	                                echo $embed_code;
	                               
	                        ?>
	                                                                                                       
	                <?php elseif (strpos($videourl,'.mp4') !== false) : ?>
	                       
	                        [video src="<?php echo $videourl; ?>"]
	                               
	                <?php endif; ?>

#9 @Anlino
4 years ago

It checks whether the URL links to a MP4 file. If it doesn't, use the oEmbed. If it does, use the video short code.

#10 @tskk
4 years ago

but strpos will never return true, it will either return the position or false.
so first section will always be used even if i have .mp4 in url.

#11 @themetracbot
4 years ago

  • Summary changed from THEME: Wilson - 1.12 to THEME: Wilson - 1.13

Wilson - 1.13

Wilson is a clean, simple and responsive theme for personal sites and blogs. Features responsive design, retina-ready assets, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code. Included translations: Swedish/svenska.

Theme URL - http://www.andersnoren.se/teman/wilson-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/wilson/1.13
ZIP - https://wordpress.org/themes/download/wilson.1.13.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wilson/1.12&new_path=/wilson/1.13

History:

Ticket Summary Status Resolution Owner
#16687 THEME: Wilson - 1.04 closed live ZGani
#16753 THEME: Wilson - 1.05 closed live tskk
#16759 THEME: Wilson - 1.07 closed live tskk
#16769 THEME: Wilson - 1.08 closed live tskk
#16772 THEME: Wilson - 1.09 closed live jcastaneda
#16789 THEME: Wilson - 1.13 closed live tskk

(this ticket)

#17421 THEME: Wilson - 1.15 closed live jcastaneda
#17862 THEME: Wilson - 1.17 closed live tskk
#19940 THEME: Wilson - 1.20 closed live woowthemes
#20503 THEME: Wilson - 1.21 closed live karmatosed
#26409 THEME: Wilson – 1.22 closed live karmatosed
#26769 THEME: Wilson – 1.23 closed live jcastaneda
#29514 THEME: Wilson – 1.24 closed live Otto42
#34025 THEME: Wilson – 1.25 closed live themetracbot
#34085 THEME: Wilson – 1.26 closed live themetracbot


https://themes.svn.wordpress.org/wilson/1.13/screenshot.png

#12 @Anlino
4 years ago

I have tested the video embeds, and it has no problem separating the mp4:s from the YouTube/Vimeo URLs. The same code is used in Hemingway.

Explanation for the strpos code: http://stackoverflow.com/questions/4366730/how-to-check-if-a-string-contains-specific-words

#13 @tskk
4 years ago

  • Status changed from reviewing to approved

Issue fixed, Approving theme.

#14 @chipbennett
4 years ago

  • Resolution set to live
  • Status changed from approved to closed

Currently approved Theme, batch-synced as Live

Note: See TracTickets for help on using tickets.