WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#17420 closed theme (not-approved)

THEME: Hemingway - 1.36

Reported by: Anlino Owned by: downstairsdev
Priority: theme update Keywords: theme-hemingway
Cc: anders@…

Description

Hemingway - 1.34

Hemingway is a clean, beautiful and responsive two-column theme for bloggers. Features responsive design, retina-ready assets, full-width header image with parallax scrolling effect, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code. Included translations: Swedish/svenska.

Theme URL - http://www.andersnoren.se/teman/hemingway-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/hemingway/1.34
ZIP - https://wordpress.org/themes/download/hemingway.1.34.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/hemingway/1.33&new_path=/hemingway/1.34

History:

Ticket Summary Status Resolution Owner
#16425 THEME: Hemingway - 1.13 closed live pagelines
#16754 THEME: Hemingway - 1.14 closed live tskk
#16757 THEME: Hemingway - 1.18 closed live catchthemes
#16761 THEME: Hemingway - 1.20 closed live tskk
#16763 THEME: Hemingway - 1.21 closed live tskk
#16771 THEME: Hemingway - 1.22 closed live salsaturation
#16790 THEME: Hemingway - 1.29 closed live tskk
#17259 THEME: Hemingway - 1.30 closed live tskk
#17365 THEME: Hemingway - 1.31 closed live tskk
#17381 THEME: Hemingway - 1.32 closed live tskk
#17413 THEME: Hemingway - 1.33 closed live tskk
#17420 THEME: Hemingway - 1.36 closed not-approved downstairsdev

(this ticket)

#17521 THEME: Hemingway - 1.37 closed live downstairsdev
#17526 THEME: Hemingway - 1.38 closed live tskk
#17599 THEME: Hemingway - 1.39 closed live tskk
#17642 THEME: Hemingway - 1.40 closed live tskk
#17860 THEME: Hemingway - 1.41 closed live robin90
#17965 THEME: Hemingway - 1.42 closed live catchthemes
#18503 THEME: Hemingway - 1.43 closed live catchthemes
#18541 THEME: Hemingway - 1.44 closed live tskk
#19939 THEME: Hemingway - 1.47 closed live woowthemes
#21017 THEME: Hemingway - 1.48 closed not-approved woowthemes
#26103 THEME: Hemingway Child – 3.3.1 closed not-approved jcastaneda
#26401 THEME: Hemingway – 1.52 closed live rabmalin
#26742 THEME: Hemingway – 1.54 closed live rabmalin
#31205 THEME: Hemingway – 1.55 closed live themetracbot
#34016 THEME: Hemingway – 1.56 closed live themetracbot
#48627 THEME: Hemingway – 1.57 closed live themetracbot
#48698 THEME: Hemingway – 1.58 closed live themetracbot
#48911 THEME: Hemingway – 1.59 closed live themetracbot


https://themes.svn.wordpress.org/hemingway/1.34/screenshot.png

Change History (4)

#1 @themetracbot
4 years ago

  • Summary changed from THEME: Hemingway - 1.34 to THEME: Hemingway - 1.35

Hemingway - 1.35

Hemingway is a clean, beautiful and responsive two-column theme for bloggers. Features responsive design, retina-ready assets, full-width header image with parallax scrolling effect, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code. Included translations: Swedish/svenska.

Theme URL - http://www.andersnoren.se/teman/hemingway-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/hemingway/1.35
ZIP - https://wordpress.org/themes/download/hemingway.1.35.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/hemingway/1.34&new_path=/hemingway/1.35

History:

Ticket Summary Status Resolution Owner
#16425 THEME: Hemingway - 1.13 closed live pagelines
#16754 THEME: Hemingway - 1.14 closed live tskk
#16757 THEME: Hemingway - 1.18 closed live catchthemes
#16761 THEME: Hemingway - 1.20 closed live tskk
#16763 THEME: Hemingway - 1.21 closed live tskk
#16771 THEME: Hemingway - 1.22 closed live salsaturation
#16790 THEME: Hemingway - 1.29 closed live tskk
#17259 THEME: Hemingway - 1.30 closed live tskk
#17365 THEME: Hemingway - 1.31 closed live tskk
#17381 THEME: Hemingway - 1.32 closed live tskk
#17413 THEME: Hemingway - 1.33 closed live tskk
#17420 THEME: Hemingway - 1.36 closed not-approved downstairsdev

(this ticket)

#17521 THEME: Hemingway - 1.37 closed live downstairsdev
#17526 THEME: Hemingway - 1.38 closed live tskk
#17599 THEME: Hemingway - 1.39 closed live tskk
#17642 THEME: Hemingway - 1.40 closed live tskk
#17860 THEME: Hemingway - 1.41 closed live robin90
#17965 THEME: Hemingway - 1.42 closed live catchthemes
#18503 THEME: Hemingway - 1.43 closed live catchthemes
#18541 THEME: Hemingway - 1.44 closed live tskk
#19939 THEME: Hemingway - 1.47 closed live woowthemes
#21017 THEME: Hemingway - 1.48 closed not-approved woowthemes
#26103 THEME: Hemingway Child – 3.3.1 closed not-approved jcastaneda
#26401 THEME: Hemingway – 1.52 closed live rabmalin
#26742 THEME: Hemingway – 1.54 closed live rabmalin
#31205 THEME: Hemingway – 1.55 closed live themetracbot
#34016 THEME: Hemingway – 1.56 closed live themetracbot
#48627 THEME: Hemingway – 1.57 closed live themetracbot
#48698 THEME: Hemingway – 1.58 closed live themetracbot
#48911 THEME: Hemingway – 1.59 closed live themetracbot


https://themes.svn.wordpress.org/hemingway/1.35/screenshot.png

#2 @themetracbot
4 years ago

  • Summary changed from THEME: Hemingway - 1.35 to THEME: Hemingway - 1.36

Hemingway - 1.36

Hemingway is a clean, beautiful and responsive two-column theme for bloggers. Features responsive design, retina-ready assets, full-width header image with parallax scrolling effect, custom accent color, custom widgets (video, Flickr and Dribbble), page templates and translation-ready code. Included translations: Swedish/svenska.

Theme URL - http://www.andersnoren.se/teman/hemingway-wordpress-theme/
Author URL - http://www.andersnoren.se

SVN - https://themes.svn.wordpress.org/hemingway/1.36
ZIP - https://wordpress.org/themes/download/hemingway.1.36.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/hemingway/1.35&new_path=/hemingway/1.36

History:

Ticket Summary Status Resolution Owner
#16425 THEME: Hemingway - 1.13 closed live pagelines
#16754 THEME: Hemingway - 1.14 closed live tskk
#16757 THEME: Hemingway - 1.18 closed live catchthemes
#16761 THEME: Hemingway - 1.20 closed live tskk
#16763 THEME: Hemingway - 1.21 closed live tskk
#16771 THEME: Hemingway - 1.22 closed live salsaturation
#16790 THEME: Hemingway - 1.29 closed live tskk
#17259 THEME: Hemingway - 1.30 closed live tskk
#17365 THEME: Hemingway - 1.31 closed live tskk
#17381 THEME: Hemingway - 1.32 closed live tskk
#17413 THEME: Hemingway - 1.33 closed live tskk
#17420 THEME: Hemingway - 1.36 closed not-approved downstairsdev

(this ticket)

#17521 THEME: Hemingway - 1.37 closed live downstairsdev
#17526 THEME: Hemingway - 1.38 closed live tskk
#17599 THEME: Hemingway - 1.39 closed live tskk
#17642 THEME: Hemingway - 1.40 closed live tskk
#17860 THEME: Hemingway - 1.41 closed live robin90
#17965 THEME: Hemingway - 1.42 closed live catchthemes
#18503 THEME: Hemingway - 1.43 closed live catchthemes
#18541 THEME: Hemingway - 1.44 closed live tskk
#19939 THEME: Hemingway - 1.47 closed live woowthemes
#21017 THEME: Hemingway - 1.48 closed not-approved woowthemes
#26103 THEME: Hemingway Child – 3.3.1 closed not-approved jcastaneda
#26401 THEME: Hemingway – 1.52 closed live rabmalin
#26742 THEME: Hemingway – 1.54 closed live rabmalin
#31205 THEME: Hemingway – 1.55 closed live themetracbot
#34016 THEME: Hemingway – 1.56 closed live themetracbot
#48627 THEME: Hemingway – 1.57 closed live themetracbot
#48698 THEME: Hemingway – 1.58 closed live themetracbot
#48911 THEME: Hemingway – 1.59 closed live themetracbot


https://themes.svn.wordpress.org/hemingway/1.36/screenshot.png

#3 @downstairsdev
4 years ago

  • Owner set to downstairsdev
  • Status changed from new to reviewing

#4 @downstairsdev
4 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Terrific theme! Everything looks good with the update- but I have to ask you to make a couple minor updates to existing issues:

REQUIRED:

Google fonts should be loaded like this to avoid SSL issues:

wp_register_style('hemingway_googleFonts', '//fonts.googleapis.com/css?family=Lato:400,700,400italic,700italic|Raleway:700,400' );

There is a developer notice on search and 404 page:
Notice: Trying to get property of non-object in /review/wp-includes/post-template.php on line 29 class="search search-no-results logged-in admin-bar no-customize-support">

Likely has to do with how you are adding body classes. Something like this should fix it:

// Add class to body if the post/page has a featured image
add_action('body_class', 'hemingway_if_featured_image_class' );

function hemingway_if_featured_image_class($classes) {
	global $post;
	if ( isset( $post ) && has_post_thumbnail() ) {
		$classes[] = 'has-featured-image';
	}
	return $classes;
}

HIGHLY RECOMMENDED:

Header text color option does not appear to work in the customizer.

"Display header text" option does not work (for header image).

SUGGESTIONS:

It looks like this file is not being used and can be removed:
jquery.min.js

This might be a cleaner way to remove inline styling on captions:
http://www.mightyminnow.com/2014/02/wordpress-captions-how-to-remove-default-10px-padding/

We also won't have to worry about that in 3.9:
https://core.trac.wordpress.org/changeset/27668

You don't need to have this wp_enqueue_script( 'jquery' ); since it's a dependency in wp_register_script( 'hemingway_global', get_template_directory_uri().'/js/global.js', array('jquery'), , true );.

FEEDBACK:

Let me know if you have any questions about these items. If you ping me ( devin at wptheming.com) when the new version is uploaded I'll try to approve it quickly.

Note: See TracTickets for help on using tickets.