WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#17595 closed theme (live)

THEME: Siempel - 0.8

Reported by: dhmskrn Owned by: catchthemes
Priority: new theme Keywords: theme-siempel
Cc: admin@…

Description

Siempel - 0.1

Simple theme WordPress. This theme have "About" section, so you can show about yourself to visitor. This themes also fully responsive, that looks great on any device. Suitable for you who wants focused on the content.

Theme URL - http://www.dhimaskirana.com/siempel-themes-wordpress.html
Author URL - http://www.dhimaskirana.com/

SVN - https://themes.svn.wordpress.org/siempel/0.1
ZIP - https://wordpress.org/themes/download/siempel.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#17595 THEME: Siempel - 0.8 closed live catchthemes

(this ticket)

#18279 THEME: Siempel - 0.9 closed live robin90


https://themes.svn.wordpress.org/siempel/0.1/screenshot.png

Change History (31)

#1 @catchthemes
3 years ago

  • Owner set to catchthemes
  • Status changed from new to reviewing

#2 @catchthemes
3 years ago

Theme Check Plugin Test: Install Theme Check Plugin and review

  • Screenshot dimensions are wrong. Screenshot size should be 880x660, to account for HiDPI displays. Any 4:3 image size is acceptable, but 880x660 is preferred.
  • All URL output should be escaped using esc_url(). I hard coded link in header.php file.

Code Quality Check: Read the Guidelines

  • Themes are required to use theme-slug ( or a reasonably unique slug) as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.) Theme does not use unique slug in some function in file function.php. Add prefix to all functions.
  • wp_enqueue_style()/wp_enqueue_script() for custom scripts.styles requires theme slug as prefix as well in function siempel_scripts() in function.php file.
  • Minified style.css is not allowed. If you want to minified version then you need to included the development unminified version file as well.

Theme Check: Read the Guidelines

  • wp_head() should be immediately before </head>.
  • screenshot issue already mentioned in Theme Check plugin test.

Theme Security and Privacy Check: Read the Guidelines

  • Themes are required to validate and sanitize all untrusted data before entering data into the database, and to escape all untrusted data before being output in the Settings form fields or in the Theme template files.
    • Possible hard-coded links were found in the file header.php and footer.php.
  • Themes are required to include within the Theme all images, scripts, and other bundled resources. Such resources must notbe “hotlinked” from a third-party site. Found hotlinked font-awesome.css file in our function.php file.

Licensing, Theme Name, Credit Links, Up-Sell Themes Check: Read the Guidelines

  • Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible. Need to mention the license details in your readme.txt
  • Themes are required to declare copyright and license information as specified by the applicable license. See the format that you should add in your readme.txt file e.g.:
    Theme Name WordPress Theme, Copyright 2014 WordPress.org
    Theme Name is distributed under the terms of the GNU GPL
    
  • Theme URI, if used, is required to link to a page specifically related to the Theme. If a demonstration site or page is being used, the content must be related to the theme itself. Theme URI pages show 404 not found.

Fix the above mentioned issues and upload the new version.

#3 @themetracbot
3 years ago

  • Summary changed from THEME: Siempel - 0.1 to THEME: Siempel - 0.2

Siempel - 0.2

Simple theme WordPress. This theme have "About" section, so you can show about yourself to visitor. This themes also fully responsive, that looks great on any device. Suitable for you who wants focused on the content.

Theme URL - http://www.dhimaskirana.com/siempel-wordpress-themes.html
Author URL - http://www.dhimaskirana.com/

SVN - https://themes.svn.wordpress.org/siempel/0.2
ZIP - https://wordpress.org/themes/download/siempel.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/siempel/0.1&new_path=/siempel/0.2

History:

Ticket Summary Status Resolution Owner
#17595 THEME: Siempel - 0.8 closed live catchthemes

(this ticket)

#18279 THEME: Siempel - 0.9 closed live robin90


https://themes.svn.wordpress.org/siempel/0.2/screenshot.png

#4 @catchthemes
3 years ago

  • Theme Check Plugin Test: Fixed
  • Code Quality Check: Fixed
  • Theme Check : Fixed

Theme Security and Privacy Check: Not Fixed

  • Use of incorrect Data validation and sanitization in your theme-option.php file. URL should use esc_url_raw() while storing it in database

Licensing, Theme Name, Credit Links, Up-Sell Themes Check:

  • Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible. Need to mention the license details in your readme.txt: NOT FIXED, you need to add in license details about the resources use. I only see the links. Also mention about the Images used.
  • Looks like theme is derived from Underscores theme. But cannot find Attribution to it. Please add in the following details:
    Siempel is based on Underscores
    http://underscores.me/
    Copyright: Automattic, automattic.com
    Licensed under GPL
    

Please fix the above issues and upload the new version.

#5 @themetracbot
3 years ago

  • Summary changed from THEME: Siempel - 0.2 to THEME: Siempel - 0.3

Siempel - 0.3

Simple theme WordPress. This theme have "About" section, so you can show about yourself to visitor. This themes also fully responsive, that looks great on any device. Suitable for you who wants focused on the content.

Theme URL - http://www.dhimaskirana.com/siempel-wordpress-themes.html
Author URL - http://www.dhimaskirana.com/

SVN - https://themes.svn.wordpress.org/siempel/0.3
ZIP - https://wordpress.org/themes/download/siempel.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/siempel/0.2&new_path=/siempel/0.3

History:

Ticket Summary Status Resolution Owner
#17595 THEME: Siempel - 0.8 closed live catchthemes

(this ticket)

#18279 THEME: Siempel - 0.9 closed live robin90


https://themes.svn.wordpress.org/siempel/0.3/screenshot.png

#6 @catchthemes
3 years ago

Remaining Issues:

  • Licensing, Theme Name, Credit Links, Up-Sell Themes Check
    • Missing License details in your readme.txt file Components section, please add license details with link. I only see the links.
    • License missing for font Source Sans Pro found in style.css file. Add it in readme.txt file.
  • Theme Security and Privacy Check
    • Themes are required to include within the Theme all images, scripts, and other bundled resources. Such resources must not be "hotlinked" from a third-party site. Following hotlink found in your style.css
      http://themes.googleusercontent.com/static/fonts/sourcesanspro/v7/ODelI1aHBYDBqgeIAH2zlBM0YzuT7MdOe03otPbuUS0.woff
      

Recommended

  • Since jquery is already added as dependencies in scripts, wp_enqueue_script('jquery', true) in functions.php file line 132 has no meaning. It is recommended to remove it.
  • Social icons should not be shown if the user has left the option blank in theme options blank.( What will user do if he wants only facebook icon? )

#7 @themetracbot
3 years ago

  • Summary changed from THEME: Siempel - 0.3 to THEME: Siempel - 0.4

Siempel - 0.4

Simple theme WordPress. This theme have "About" section, so you can show about yourself to visitor. This themes also fully responsive, that looks great on any device. Suitable for you who wants focused on the content.

Theme URL - http://www.dhimaskirana.com/siempel-wordpress-themes.html
Author URL - http://www.dhimaskirana.com/

SVN - https://themes.svn.wordpress.org/siempel/0.4
ZIP - https://wordpress.org/themes/download/siempel.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/siempel/0.3&new_path=/siempel/0.4

History:

Ticket Summary Status Resolution Owner
#17595 THEME: Siempel - 0.8 closed live catchthemes

(this ticket)

#18279 THEME: Siempel - 0.9 closed live robin90


https://themes.svn.wordpress.org/siempel/0.4/screenshot.png

#8 @catchthemes
3 years ago

Licensing, Theme Name, Credit Links, Up-Sell Themes Check:

  • Missing license of JS files such as html5.js, small-menu.js and others. You need to add in license details of these files in your readme.txt file.
  • Also in the following details mentioned in readme.txt file. You need to add in License details.
    - Gridiculo.us Grid System by c.bavota - http://gridiculo.us/
    - Font Awesome - http://fortawesome.github.io/Font-Awesome/
    - Nice Scroll Plugin Jquery - http://areaaperta.com/nicescroll/
    

About to get this them Approved. Please fix the above mentioned issues and upload new version.

Other Issues

  • Theme uses minifed JS files such as nicescroll.js. For all minified JS and CSS files, you need to add in development unminifed version in the theme bundle.

#9 @themetracbot
3 years ago

  • Summary changed from THEME: Siempel - 0.4 to THEME: Siempel - 0.5

Siempel - 0.5

Simple theme WordPress. This theme have "About" section, so you can show about yourself to visitor. This themes also fully responsive, that looks great on any device. Suitable for you who wants focused on the content.

Theme URL - http://www.dhimaskirana.com/siempel-wordpress-themes.html
Author URL - http://www.dhimaskirana.com/

SVN - https://themes.svn.wordpress.org/siempel/0.5
ZIP - https://wordpress.org/themes/download/siempel.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/siempel/0.4&new_path=/siempel/0.5

History:

Ticket Summary Status Resolution Owner
#17595 THEME: Siempel - 0.8 closed live catchthemes

(this ticket)

#18279 THEME: Siempel - 0.9 closed live robin90


https://themes.svn.wordpress.org/siempel/0.5/screenshot.png

#10 @dhmskrn
3 years ago

Hi catchthemes,

small-menu.js is javascript from Underscores Starter Themes, so the license is included in the license of Underscores Starter Themes.

All issues are mentioned above has fixed. Please approve this themes. Thanks!

#11 @catchthemes
3 years ago

  • Status changed from reviewing to approved
  • All Previous Issues Has Been Fixed.
  • No Issues Found. Marking as Approved.

#12 @chipbennett
3 years ago

  • Status changed from approved to reopened

#13 @chipbennett
3 years ago

  • Status changed from reopened to reviewing

Required

  • All custom functions must be properly namespaced (prefixed) (see theme_options.php)
  • Theme options must be escaped on output (see custom CSS in document head)
  • Remove function_exists() conditional wrapper from dynamic_sidebar() and any other function introduced prior to WordPress 3.6

Recommended

  • Consider using wp_add_inline_style() to output custom CSS

#14 @themetracbot
3 years ago

  • Summary changed from THEME: Siempel - 0.5 to THEME: Siempel - 0.6

Siempel - 0.6

Simple theme WordPress. This theme have "About" section, so you can show about yourself to visitor. This themes also fully responsive, that looks great on any device. Suitable for you who wants focused on the content.

Theme URL - http://www.dhimaskirana.com/siempel-wordpress-themes.html
Author URL - http://www.dhimaskirana.com/

SVN - https://themes.svn.wordpress.org/siempel/0.6
ZIP - https://wordpress.org/themes/download/siempel.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/siempel/0.5&new_path=/siempel/0.6

History:

Ticket Summary Status Resolution Owner
#17595 THEME: Siempel - 0.8 closed live catchthemes

(this ticket)

#18279 THEME: Siempel - 0.9 closed live robin90


https://themes.svn.wordpress.org/siempel/0.6/screenshot.png

#15 @dhmskrn
3 years ago

Hi chipbennett

Thanks for reviewing my themes. All issues are mentioned above has fixed. Please accept my themes.

#16 @catchthemes
3 years ago

Previous issues:

  • All custom functions must be properly namespaced (prefixed) (see theme_options.php): Partially Fixed. I still see functions without proper prefix in line 14 of theme_options.php
    function theme_options_do_page() { ...
    
  • Theme options must be escaped on output (see custom CSS in document head): FIXED
  • Remove function_exists() conditional wrapper from dynamic_sidebar() and any other function introduced prior to WordPress 3.6: NOT FIXED. Please see sidebar-footer.php

New issues:

  • Need to escape all output URL in header.php for added social icons.

Please fix above issues and re-update the theme.

Last edited 3 years ago by catchthemes (previous) (diff)

#17 @themetracbot
3 years ago

  • Summary changed from THEME: Siempel - 0.6 to THEME: Siempel - 0.7

Siempel - 0.7

Simple theme WordPress. This theme have "About" section, so you can show about yourself to visitor. This themes also fully responsive, that looks great on any device. Suitable for you who wants focused on the content.

Theme URL - http://www.dhimaskirana.com/siempel-wordpress-themes.html
Author URL - http://www.dhimaskirana.com/

SVN - https://themes.svn.wordpress.org/siempel/0.7
ZIP - https://wordpress.org/themes/download/siempel.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/siempel/0.6&new_path=/siempel/0.7

History:

Ticket Summary Status Resolution Owner
#17595 THEME: Siempel - 0.8 closed live catchthemes

(this ticket)

#18279 THEME: Siempel - 0.9 closed live robin90


https://themes.svn.wordpress.org/siempel/0.7/screenshot.png

#18 @dhmskrn
3 years ago

Hi catchthemes,

Thanks for reviewing my themes. All issues has fixed. Please make this themes live. I can't wait again. Many thanks. :)

#19 @catchthemes
3 years ago

Ok, i will do a final check and let you know.

#20 @catchthemes
3 years ago

One more issue:

  • In header.php, you have added custom css but you need to hook it appropriately.

Themes are required to enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function, rather than hard-coding stylesheet/script links or tags in the template.Refer to Template tags and hooks

#21 @themetracbot
3 years ago

  • Summary changed from THEME: Siempel - 0.7 to THEME: Siempel - 0.8

Siempel - 0.8

Simple theme WordPress. This theme have "About" section, so you can show about yourself to visitor. This themes also fully responsive, that looks great on any device. Suitable for you who wants focused on the content.

Theme URL - http://www.dhimaskirana.com/siempel-wordpress-themes.html
Author URL - http://www.dhimaskirana.com/

SVN - https://themes.svn.wordpress.org/siempel/0.8
ZIP - https://wordpress.org/themes/download/siempel.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/siempel/0.7&new_path=/siempel/0.8

History:

Ticket Summary Status Resolution Owner
#17595 THEME: Siempel - 0.8 closed live catchthemes

(this ticket)

#18279 THEME: Siempel - 0.9 closed live robin90


https://themes.svn.wordpress.org/siempel/0.8/screenshot.png

#22 @dhmskrn
3 years ago

I hope this is the last one.

#23 @dhmskrn
3 years ago

Could you please delete custom.css file? I forgot to delete it. Thanks. :)

#24 @catchthemes
3 years ago

I won't be able to delete it. You need to upload a new version removing unnecessary files. Then I can approve the theme.

#25 @dhmskrn
3 years ago

I see. I will fix it on the next version. Thanks catchthemes. :)

#26 @dhmskrn
3 years ago

So, you can approve my themes. Thank you for your cooperation. :)

#27 @catchthemes
3 years ago

You need to upload new theme removing custom.css file before I can approve it.

#28 @chipbennett
3 years ago

You could approve it, with the caveat that custom.css be removed in the next revision. As long as the instructions for the user to modify custom.css have been removed, it's just a legacy file, and not likely to impact the user.

#29 @catchthemes
3 years ago

  • Status changed from reviewing to approved

@chipbennett: Ok, thanks Chip, i will approve the theme and thanks for your help in the theme approval process as a whole.

NOTE: Please remove custom.css file in the next version.

No further issues. Marking theme as approved.

Last edited 3 years ago by catchthemes (previous) (diff)

#30 @dhmskrn
3 years ago

@chipbennett: Thanks Chip :)
@catchthemes: Thanks for approving my theme. I promise to delete it on next version.

#31 @chipbennett
3 years ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.