WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#17614 closed theme (not-approved)

THEME: multiloquent - 6.2.0

Reported by: jonathansblog Owned by: Frank Klein
Priority: theme update Keywords: theme-multiloquent
Cc: jonathan@…

Description

multiloquent - 6.2.0

multiloquent html5 / bootstrap theme - a theme with 10 dynamic sidebars in various locations using twitter bootstrap complete with yaarp related posts theme, dynamic top10 front page featured posts, fontawesome icons, category index page template, tag index page template and 3 post templates. Version 6.1.0 adds wordpress theme customisation API for theme colours and text colours.

Theme URL - http://jonathansblog.co.uk/multiloquent
Author URL - http://jonathansblog.co.uk

SVN - https://themes.svn.wordpress.org/multiloquent/6.2.0
ZIP - https://wordpress.org/themes/download/multiloquent.6.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/multiloquent/6.1.01&new_path=/multiloquent/6.2.0

History:

Ticket Summary Status Resolution Owner
#15617 THEME: multiloquent - 6.0.5 closed not-approved alex27
#16233 THEME: multiloquent - 6.0.10 closed live cyberchimpscode
#16513 THEME: multiloquent - 6.0.11 closed live chipbennett
#16544 THEME: multiloquent - 6.0.12 closed live tskk
#16916 THEME: multiloquent - 6.0.13 closed live tskk
#16959 THEME: multiloquent - 6.0.15 closed not-approved tskk
#17205 THEME: multiloquent - 6.1.01 closed live jcastaneda
#17614 THEME: multiloquent - 6.2.0 closed not-approved Frank Klein

(this ticket)

#17787 THEME: multiloquent - 6.2.02 closed live jacenty3590
#17788 THEME: multiloquent - 6.2.03 closed live tskk
#17809 THEME: multiloquent - 6.3.0 closed live robin90
#18092 THEME: multiloquent - 6.3.1 closed live tskk
#18124 THEME: multiloquent - 6.3.2 closed live robin90
#18903 THEME: multiloquent - 6.3.3 closed live emiluzelac
#19005 THEME: multiloquent - 6.3.4 closed live bijayyadav
#19111 THEME: multiloquent - 6.3.6 closed live tskk
#19218 THEME: multiloquent - 6.4.0 closed live kharisblank
#19432 THEME: multiloquent - 7.0.0 closed live catchthemes
#19542 THEME: multiloquent - 7.1.1 closed live robin90
#21077 THEME: multiloquent - 8.0.01 closed live karmatosed
#21083 THEME: multiloquent - 8.0.02 closed live karmatosed
#23168 THEME: multiloquent - 8.0.03 closed live emiluzelac
#25050 THEME: multiloquent – 9.0.0 closed live cais
#25646 THEME: multiloquent – 9.1.01 closed live downstairsdev
#27896 THEME: multiloquent – 9.2.01 closed live jcastaneda
#33101 THEME: multiloquent – 9.2.02 closed live themetracbot
#36996 THEME: multiloquent – 9.3.01 closed live themetracbot
#37882 THEME: multiloquent – 9.3.03 closed live themetracbot
#38093 THEME: multiloquent – 9.3.04 closed live themetracbot
#40421 THEME: multiloquent – 9.4.01 closed live themetracbot
#40423 THEME: multiloquent – 9.4.02 closed live themetracbot


https://themes.svn.wordpress.org/multiloquent/6.2.0/screenshot.png

Change History (5)

#1 @jonathansblog
4 years ago

lots of changes in this version:

fixes to author archives: fixed h1 tag
fixes to pagination on archives: styled to look like bootstrap
new pop-out sidebar with wordpress menu support
new elements in customise api: pop out menu, body background
various fixes to css / code
total revamp of comments styling
new 'top/featured' posts on single post page - shows 4 of the posts from the homepage slider
next post / prev post links on single article page
pages now look like full-width posts
changed theme url to point to a page on my site to offer more detailed instructions on setup, etc

#2 @Frank Klein
4 years ago

  • Owner set to Frank Klein
  • Status changed from new to reviewing

#3 @Frank Klein
4 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
  • front-page.php is broken: no admin bar, extremely slow, does not respect the Reading Settings.
  • Please use get_template_part() instead of multiloquent_get_template_part() function.
  • index.phpcan not be repurposed in the way you did it. This template file is the main template file and as such a backup for all other template files. Therefore it needs to contain header, footer and a full loop.
  • footer.php: Please remove the hardcoded "This website is most definitely not best viewed in Netscape" and "multiloquent html5 theme" version text.
  • multiloquent_register_and_generate_custom_control(): every Customizer setting needs a sanitization callback set.
  • Every call to get_theme_mod() needs to be escaped on output.
  • multiloquent_paralax_featured_sliders() The SQL query needs to be removed entirely. Use the "Top 10 Posts" API instead of a direct query.
  • The archive templates (archive.php, author.php,...) should be reviewed. Using a proper loop with a call to the_post() before the content of the page would make all the hacks avoidable.

#4 @jonathansblog
4 years ago

thats cool, will look at loading issues etc.

I was told for the last release not to use get_template_part() and to use require instead, so made multiloquent_get_template_part as a wrapper round a php require call...

#5 @Frank Klein
4 years ago

Hi,

I'm sorry about that, I see now why you have chosen this method of adding the template parts.

I disagree with the previous reviewer though. To me, the files that you require in the template files look like parts of the template. So the correct function is get_template_part().

It is true though that if you require non template files, like for example parts of the functions.php file, then an include or require is correct.

Here is a good article on the function: http://kovshenin.com/2013/get_template_part/

Cheers!

Note: See TracTickets for help on using tickets.