WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#17615 closed theme (not-approved)

THEME: Claydell Media - 1.0.7

Reported by: jamielt Owned by: Frank Klein
Priority: theme update Keywords: theme-claydell-media
Cc: jamielt55@…

Description

Claydell Media - 1.0.7

The Claydell Media Wordpress Theme is a responsive, semantic, HTML5, theme. Features include logo management, social icons and an easy to use social menu, styling for post formats on both index and single views.

Theme URL - http://jamiethompson.com/themes/claydell-media/
Author URL - http://jamiethompson.com/

SVN - https://themes.svn.wordpress.org/claydell-media/1.0.7
ZIP - https://wordpress.org/themes/download/claydell-media.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/claydell-media/1.0.6&new_path=/claydell-media/1.0.7

History:

Ticket Summary Status Resolution Owner
#12891 THEME: Claydell Media - 1.0 closed not-approved ZGani
#13306 THEME: Claydell Media - 1.0.6 closed live bhadaway
#17615 THEME: Claydell Media - 1.0.7 closed not-approved Frank Klein

(this ticket)

#17903 THEME: Claydell Media - 1.1.0 closed live metodiew


https://themes.svn.wordpress.org/claydell-media/1.0.7/screenshot.png

Change History (3)

#1 @Frank Klein
4 years ago

  • Owner set to Frank Klein
  • Status changed from new to reviewing
  • claydellmedia_oddeven_post_class() as $current_class is a global, it needs to be prefixed with the theme slug.
  • customizer.php: Every $wp_customize->add_setting needs to have a sanitization callback set.
  • socialmedia.php: The calls to get_theme_mod() need to be escaped before output.

#2 follow-up: @Frank Klein
4 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

#3 in reply to: ↑ 2 @jamielt
4 years ago

Replying to Frank Klein:

  1. claydellmedia_oddeven_post_class() as $current_class is a global, it needs to be prefixed with the theme slug.

My example::
/

  • Add Odd/Even Class. */

if ( ! function_exists( 'claydell_media_oddeven_post_class' ) ) :
function claydell_media_oddeven_post_class ( $classes ) {

global $current_class;
$classes[] = $current_class;
$current_class = ($current_class == 'odd') ? 'even' : 'odd';
return $classes;

}

global $current_class;
$current_class = 'odd';

add_filter ( 'post_class' , 'claydell_media_oddeven_post_class' );
endif; claydell_media_oddeven_post_class

  1. Will this work for "Every $wp_customize->add_setting needs to have a sanitization callback set"?

My example: $wp_customize->add_setting( 'rss', array(

'default' => ,
'sanitize_callback' => 'claydellmedia_sanitize_rss',

) );

  1. Please give example of how to escape the calls to get_theme_mod()in socialmedia.php before output?

My example: <?php if ( get_theme_mod( 'rss' ) ) : ?>

<li><a href="<?php echo esc_url( get_theme_mod( 'rss' ) ); ?>" class="genericon genericon-feed" title="<?php echo esc_url( get_theme_mod( 'rss' ) ); ?>" target="_blank"></a><li>

<?php endif; ?>

Thanks,

Jamie

Last edited 4 years ago by jamielt (previous) (diff)
Note: See TracTickets for help on using tickets.