WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#17867 closed theme (live)

THEME: Pelham - 1.0.3

Reported by: ZaneMatthew Owned by: umbrellathemes
Priority: new theme Keywords: theme-pelham
Cc: zanematthew@…

Description

Pelham - 1.0.0

Pelham is a logic-oriented, clean and responsive theme. It seamlessly integrates the WordPress admin and supports; gallery columns, shadowbox styled images, editor styles, widgetized areas, theme customizer and post-formats.

Theme URL -
Author URL - http://zanematthew.com

SVN - https://themes.svn.wordpress.org/pelham/1.0.0
ZIP - https://wordpress.org/themes/download/pelham.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#17867 THEME: Pelham - 1.0.3 closed live umbrellathemes

(this ticket)


https://themes.svn.wordpress.org/pelham/1.0.0/screenshot.png

Attachments (1)

pelham.zip (471.0 KB) - added by ZaneMatthew 4 years ago.

Download all attachments as: .zip

Change History (27)

#2 @emiluzelac
4 years ago

  • Owner set to umbrellathemes
  • Status changed from new to reviewing

Trainee assigned...

#3 @umbrellathemes
4 years ago

@ZaneMatthew :
Theme Reviewed : No Error , Issue Found.

PS: Re upload Next Version with Theme URI.

Thanks

@ZaneMatthew
4 years ago

#4 @themetracbot
4 years ago

  • Summary changed from THEME: Pelham - 1.0.0 to THEME: Pelham - 1.0.1

Pelham - 1.0.1

Pelham is a logic-oriented, clean and responsive theme. It seamlessly integrates the WordPress admin and supports; gallery columns, shadowbox styled images, editor styles, widgetized areas, theme customizer and post-formats.

Theme URL - http://zanematthew.com/blog/2014/04/pelham-logic-oriented-wordpress-theme/
Author URL - http://zanematthew.com

SVN - https://themes.svn.wordpress.org/pelham/1.0.1
ZIP - https://wordpress.org/themes/download/pelham.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/pelham/1.0.0&new_path=/pelham/1.0.1

History:

Ticket Summary Status Resolution Owner
#17867 THEME: Pelham - 1.0.3 closed live umbrellathemes

(this ticket)


https://themes.svn.wordpress.org/pelham/1.0.1/screenshot.png

#5 follow-up: @umbrellathemes
4 years ago

  • Status changed from reviewing to approved

No Previous Issues.
Diff Review Only
No issues. Theme URI added. Marking it as approved.

Thank's

#6 in reply to: ↑ 5 @chipbennett
4 years ago

  • Status changed from approved to reopened

#7 follow-up: @chipbennett
4 years ago

  • Status changed from reopened to reviewing

Replying to umbrellathemes:

Diff Review Only

This is a new Theme, and requires a full review.

#8 in reply to: ↑ 7 @ZaneMatthew
4 years ago

Replying to chipbennett:

Replying to umbrellathemes:

Diff Review Only

This is a new Theme, and requires a full review.

Hi Chip,

The diff, https://themes.trac.wordpress.org/changeset?old_path=/pelham/1.0.0&new_path=/pelham/1.0.1 for the theme shows that only the style.css changed. What qualifies it as a new theme, as apposed to the one I had already uploaded? Should I not have increased the version number?

#9 follow-up: @chipbennett
4 years ago

The Theme was originally uploaded in this ticket as Version 1.0.0, and has never before been reviewed in our system. A revision, Version 1.0.1, was uploaded and appended to the ticket. But because the Theme has never before been reviewed and approved in the Directory, it remains a New Theme, subject to a full review prior to approval.

#10 in reply to: ↑ 9 @ZaneMatthew
4 years ago

Replying to chipbennett:

The Theme was originally uploaded in this ticket as Version 1.0.0, and has never before been reviewed in our system. A revision, Version 1.0.1, was uploaded and appended to the ticket. But because the Theme has never before been reviewed and approved in the Directory, it remains a New Theme, subject to a full review prior to approval.

Hi Chip,

Thanks for the detailed response, its much appreciated :D

#11 follow-up: @umbrellathemes
4 years ago

HI,

Theme has been reviewed fully.

Some Points must be corrected the next version.

1)Expand issue in post/page.

-> When I open expand . the icon must be change when all feature are showing. In short expand function showing same icon in both cases.

2) I have not found any theme-options in this theme, Why you have added Tag in header of the style.css file. Remove extra unused tags.

3)WordPress itself provide customize. why you have added your own customize class for the same ?

All issue must be sorted out.

Thanks

#12 in reply to: ↑ 11 @ZaneMatthew
4 years ago

Replying to umbrellathemes:

HI,

Theme has been reviewed fully.

Some Points must be corrected the next version.

1)Expand issue in post/page.

-> When I open expand . the icon must be change when all feature are showing. In short expand function showing same icon in both cases.

2) I have not found any theme-options in this theme, Why you have added Tag in header of the style.css file. Remove extra unused tags.

3)WordPress itself provide customize. why you have added your own customize class for the same ?

All issue must be sorted out.

Thanks

Hi,

Thanks for the follow-up, all are valid points and will be fixed. I implemented the customizer class based on the Sample Theme Customization Classhttps://codex.wordpress.org/Theme_Customization_API#Sample_Theme_Customization_Class as seen in the codex. Considering I can implement the theme customizer without the extra code it will be removed.

#13 follow-up: @umbrellathemes
4 years ago

@ZaneMatthew , also hav not found any specific license for the JS, CSS , Fonts and other resources used in this theme. Add license .

#14 @themetracbot
4 years ago

  • Summary changed from THEME: Pelham - 1.0.1 to THEME: Pelham - 1.0.2

Pelham - 1.0.2

Pelham is a logic-oriented, clean and responsive theme. It seamlessly integrates the WordPress admin and supports; gallery columns, shadowbox styled images, editor styles, widgetized areas, theme customizer and post-formats.

Theme URL - http://zanematthew.com/blog/2014/04/pelham-logic-oriented-wordpress-theme/
Author URL - http://zanematthew.com

SVN - https://themes.svn.wordpress.org/pelham/1.0.2
ZIP - https://wordpress.org/themes/download/pelham.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/pelham/1.0.1&new_path=/pelham/1.0.2

History:

Ticket Summary Status Resolution Owner
#17867 THEME: Pelham - 1.0.3 closed live umbrellathemes

(this ticket)


https://themes.svn.wordpress.org/pelham/1.0.2/screenshot.png

#15 follow-up: @ZaneMatthew
4 years ago

Hi Umbrella Themes,

I've fixed the issues posted earlier.

Regarding the theme customizer class. It is not clear as to how I can remove it and still allow for the following customization:

Custom background and color for site title tag
Custom site width
Custom logo image (replaces site name)
Custom link color (and hover color)
Custom CSS (via a textarea)

I've implemented it via the example in the codex: https://codex.wordpress.org/Theme_Customization_API#Sample_Theme_Customization_Class

I've added a license.txt for the unsemantic css file as there is already license's for the genericon fonts.

#16 in reply to: ↑ 13 @ZaneMatthew
4 years ago

Replying to umbrellathemes:

@ZaneMatthew , also hav not found any specific license for the JS, CSS , Fonts and other resources used in this theme. Add license .

Thanks for the info. I've included a license for the unsemantic css file, the genericon css file already has a license with it. I'm not using any 3rd party JS files and was under the assumption that the license uri linked in my style.css would suffice for the JS file I wrote.

Are you saying I need a license for the JS I wrote for the theme as well?

#17 in reply to: ↑ 15 @umbrellathemes
4 years ago

Replying to ZaneMatthew:

Regarding the theme customizer class. It is not clear as to how I can remove it and still allow for the following customization:

Custom background and color for site title tag
Custom site width
Custom logo image (replaces site name)
Custom link color (and hover color)
Custom CSS (via a textarea)

In the WordPress' Customize Option you get
Custom Background and Color
Custom Image
Site Title and Blog Info.
Navigation
Static Page

For extra options you have implemented right code.

No,No need for License JS you have written.

Thanks

#18 @umbrellathemes
4 years ago

  • Status changed from reviewing to approved

#19 @chipbennett
4 years ago

  • Status changed from approved to reopened

#20 follow-up: @chipbennett
4 years ago

  • Status changed from reopened to reviewing

Required

  • Custom WP_Customize controls require sanitize_callback
  • Move $content_width definition inside the Theme setup function

#21 @themetracbot
4 years ago

  • Summary changed from THEME: Pelham - 1.0.2 to THEME: Pelham - 1.0.3

Pelham - 1.0.3

Pelham is a logic-oriented, clean and responsive theme. It seamlessly integrates the WordPress admin and supports; gallery columns, shadowbox styled images, editor styles, widgetized areas, theme customizer and post-formats.

Theme URL - http://zanematthew.com/blog/2014/04/pelham-logic-oriented-wordpress-theme/
Author URL - http://zanematthew.com

SVN - https://themes.svn.wordpress.org/pelham/1.0.3
ZIP - https://wordpress.org/themes/download/pelham.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/pelham/1.0.2&new_path=/pelham/1.0.3

History:

Ticket Summary Status Resolution Owner
#17867 THEME: Pelham - 1.0.3 closed live umbrellathemes

(this ticket)


https://themes.svn.wordpress.org/pelham/1.0.3/screenshot.png

#22 in reply to: ↑ 20 @ZaneMatthew
4 years ago

Replying to chipbennett:

Required

  • Custom WP_Customize controls require sanitize_callback
  • Move $content_width definition inside the Theme setup function

Hi Chip,

The issues are fixed in the latest version, along with a minor styling change. I noticed that the default values of the customizer did not match the values in style.css and the theme was defaulting to a gray background when viewed in the theme customizer (since updating to 3.9).

Regarding the Theme Customizer sanitization I referenced existing themes in the WordPress theme repository, but many do not use the sanitization callback (I referenced your theme https://themes.svn.wordpress.org/oenology/3.3/functions/options-customizer.php and a few others). In the end I referenced the JetPack plugin as an example http://plugins.svn.wordpress.org/jetpack/tags/2.7/modules/custom-post-types/testimonial.php and used the core WordPress functions, i.e., sanitize_hex_color, and sanitize_text_field. If sanitization isn't implemented properly can you please provide an example.

Once again, thanks for the review, its a joy and learning experience.

#23 @umbrellathemes
4 years ago

  • Status changed from reviewing to approved

#24 @ZaneMatthew
4 years ago

Hi,

I was reading over on (Make WordPress)http://make.wordpress.org/themes/2014/04/08/selective-ticket-assignment-and-ticket-hogging/#comment-34197 that tickets with no response will be closed after 5 days. As this ticket has gone 8 days without a response, I'm in fear that it will be automatically closed.

#25 @ZaneMatthew
4 years ago

Hello reviewers,

Just following up on the status of theme review. Really looking forward to sharing this theme...let me know if you have any questions or need anything else from me.

Thanks!

Zane

#26 @emiluzelac
4 years ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.