WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#17896 closed theme (live)

THEME: Subtle - 1.5.4

Reported by: xavortm Owned by: alex27
Priority: new theme Keywords: theme-subtle
Cc: xavortm@…

Description

Subtle - 1.0

One minimalistic looking WordPress theme good for standart blogging.

Theme URL - http://www.demo.xavortm.com/subtle
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.0
ZIP - https://wordpress.org/themes/download/subtle.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.0/screenshot.png

Attachments (2)

subtle.zip (853.1 KB) - added by xavortm 4 years ago.
Updated theme
Screen Shot 2014-04-14 at 10.51.08.png (22.7 KB) - added by alex27 4 years ago.

Download all attachments as: .zip

Change History (30)

#1 @alex27
4 years ago

  • Owner set to alex27
  • Status changed from new to reviewing

#2 @alex27
4 years ago

REQUIRED

CODE

  • <?php wp_head(); ?> should be directly before closing </head> tag
  • comment-reply script should be enqueued from functions.php
  • html5.js must be bundled with the theme, themes are not allowed to load files from CDN. Same goes for Font Awesome stylesheet.
  • Only one script can be placed directly in header.php in conditional tags, and that’s html5shiv.js.
  • wp_print_styles should not be used to enqueue styles or scripts. Use wp_enqueue_scripts instead.
  • Google fonts need to be properly enqueued without the protocol (http:). Also there’s no need to register first, just proceed with the enqueue.
  • Page with comments doesn’t display comments or comment form.
  • Custom Header feature does not work.

LAYOUT

  • visual issues with the default menu (before menu is assigned to main menu location) - see screenshot

OTHER

  • Themes must provide explicit credit and license info for all resources bundled with the theme (Font Awesome, Bootstrap), like so:

[Theme name] Uses [Resource Name and URL], licensed under [Name of license].

CONCLUSION

Please fix above issues and upload new version of your theme, I'll leave this ticket open for another 2-3 days. Feel free to ask if you have any questions.

#3 @xavortm
4 years ago

I have a question about the comment-reply that you mentioned. What exactly i have to do there? I didn't found it (ctrl+f), maybe im just little desorientated right now :D Little help would come good.

@xavortm
4 years ago

Updated theme

#4 @themetracbot
4 years ago

  • Summary changed from THEME: Subtle - 1.0 to THEME: Subtle - 1.1

Subtle - 1.1

One minimalistic looking WordPress theme good for standart blogging.

Theme URL - http://www.demo.xavortm.com/subtle
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.1
ZIP - https://wordpress.org/themes/download/subtle.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/subtle/1.0&new_path=/subtle/1.1

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.1/screenshot.png

#5 @alex27
4 years ago

Hello!

There are still some issues that need fixing:

  • comment-reply script - right now it’s in two places
    • in header.php
    • in functions.php
  • when you enqueue Google Fonts please drop the protocol (http:) and start with //, so the link should look like this:
    • fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,700,400italic
  • Custom Header Function - the “Show header text with your image” option doesn’t work - unchecking doesn’t make a difference.
  • Custom Background - while this feature works as expected, the page can easily become unreadable after you set background image, since you don’t provide any kind of background to main content area.

#6 @themetracbot
4 years ago

  • Summary changed from THEME: Subtle - 1.1 to THEME: Subtle - 1.2

Subtle - 1.2

One minimalistic looking WordPress theme good for standart blogging.

Theme URL - http://www.demo.xavortm.com/subtle
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.2
ZIP - https://wordpress.org/themes/download/subtle.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/subtle/1.1&new_path=/subtle/1.2

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.2/screenshot.png

#7 @themetracbot
4 years ago

  • Summary changed from THEME: Subtle - 1.2 to THEME: Subtle - 1.3

Subtle - 1.3

One minimalistic looking WordPress theme good for standart blogging.

Theme URL - http://www.demo.xavortm.com/subtle
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.3
ZIP - https://wordpress.org/themes/download/subtle.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/subtle/1.2&new_path=/subtle/1.3

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.3/screenshot.png

#8 @xavortm
4 years ago

The last thing i forgot to change and i think you would've denied is the navigation menu when narrowing the browser width. Right now i removed the support for responsive menu and let it be as usual with more rows of content instead of dropdown.

#9 @alex27
4 years ago

Hello!

Two items to address:

  • Theme URL is 404 error page. Please note that for Theme URI mere demo website with dummy content is not sufficient. It should be a page dedicated to the theme and you can add link to demo to that page. Also it's enough to provide only Author URI.
  • Custom Header feature is still not properly implemented - there's no color picker for Header Text Color and Header Text checkbox doesn't work. Please test all the settings thoroughly!

#10 @themetracbot
4 years ago

  • Summary changed from THEME: Subtle - 1.3 to THEME: Subtle - 1.4

Subtle - 1.4

One minimalistic looking WordPress theme good for standart blogging.

Theme URL - http://www.demo.xavortm.com/subtle
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.4
ZIP - https://wordpress.org/themes/download/subtle.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/subtle/1.3&new_path=/subtle/1.4

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.4/screenshot.png

#11 @xavortm
4 years ago

Oups, just noticed one RECOMENDED that i forgot i messed up before. Please check if there left something else and i will fix it then so i dont resubmit 1000 times.

#12 @alex27
4 years ago

Hello!

The custom header feature still isn't properly configured. You need to add proper parameters, like default-text-color, width, height etc., (just like with custom background). Check the Codex for full list of parameters and test before reuploading.
Theme URI - as mentioned before it cannot be a simple demo site with dummy content. Theme URI, if used, is required to link to a page specifically related to the Theme. If a demonstration site or page is being used, the content must be related to the theme itself.

#13 @themetracbot
4 years ago

  • Summary changed from THEME: Subtle - 1.4 to THEME: Subtle - 1.5

Subtle - 1.5

One minimalistic looking WordPress theme good for standart blogging.

Theme URL -
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.5
ZIP - https://wordpress.org/themes/download/subtle.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/subtle/1.4&new_path=/subtle/1.5

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.5/screenshot.png

#14 @xavortm
4 years ago

I prefer not to use default header image the same way i didnt for the background of the theme. Its user's choise, what they get is the minimalistic aproach. The height and width + text color are there thought. I hope there is nothing more left :)

Also i removed the theme URI and that leaves recomended notice from the theme check, but i believe its ok to ingore it.

#15 @alex27
4 years ago

Hello!

Previous issues have been fixed, but you changed the screenshot and you need to provide credit and licensing info to all resource including images used in screenshot (even if not included with the theme).

#16 @themetracbot
4 years ago

  • Summary changed from THEME: Subtle - 1.5 to THEME: Subtle - 1.5.1

Subtle - 1.5.1

One minimalistic looking WordPress theme good for standart blogging.

Theme URL -
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.5.1
ZIP - https://wordpress.org/themes/download/subtle.1.5.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/subtle/1.5&new_path=/subtle/1.5.1

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.5.1/screenshot.png

#17 @alex27
4 years ago

Hello!

What you supplied is not enough - you didn't mention image license! All resources, including images used in the screenshot must be on a GPL compatible license. Great source of free photos is http://pixabay.com/

#18 @themetracbot
4 years ago

  • Summary changed from THEME: Subtle - 1.5.1 to THEME: Subtle - 1.5.2

Subtle - 1.5.2

One minimalistic looking WordPress theme good for standart blogging.

Theme URL -
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.5.2
ZIP - https://wordpress.org/themes/download/subtle.1.5.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/subtle/1.5.1&new_path=/subtle/1.5.2

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.5.2/screenshot.png

#19 @themetracbot
4 years ago

  • Summary changed from THEME: Subtle - 1.5.2 to THEME: Subtle - 1.5.3

Subtle - 1.5.3

One minimalistic looking WordPress theme good for standart blogging.

Theme URL -
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.5.3
ZIP - https://wordpress.org/themes/download/subtle.1.5.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/subtle/1.5.2&new_path=/subtle/1.5.3

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.5.3/screenshot.png

#20 @alex27
4 years ago

  • Status changed from reviewing to approved

All previous issues have been resolved. Marking theme as APPROVED.

#21 @chipbennett
4 years ago

  • Status changed from approved to reopened

#22 @chipbennett
4 years ago

  • Status changed from reopened to reviewing

Required

  • Stylesheets (whether linked or inline) must not be hard-coded in the document head. They must be enqueued (linked stylesheet) or added via callback hooked into an appropriate action (inline). In this case, hook the inline stylesheet into wp_head, or, alternately, add it to 'stylesheet' via wp_add_inline_style().

#23 @themetracbot
4 years ago

  • Summary changed from THEME: Subtle - 1.5.3 to THEME: Subtle - 1.5.4

Subtle - 1.5.4

One minimalistic looking WordPress theme good for standart blogging.

Theme URL -
Author URL - http://www.xavortm.com

SVN - https://themes.svn.wordpress.org/subtle/1.5.4
ZIP - https://wordpress.org/themes/download/subtle.1.5.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/subtle/1.5.3&new_path=/subtle/1.5.4

History:

Ticket Summary Status Resolution Owner
#2015 THEME: SubtleFlux - 1.1 closed not-approved chipbennett
#17596 THEME: Carrot Lite - 1.5.2 closed live alex27
#17896 THEME: Subtle - 1.5.4 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/subtle/1.5.4/screenshot.png

#24 @alex27
4 years ago

The function you created custom_header_css lacks theme prefix.

#25 @xavortm
4 years ago

Yes, because its all wrapped in the theme Class, the same way all other functions don't have the prefix. Is that a problem?

#26 @alex27
4 years ago

  • Status changed from reviewing to approved

Ah yes, I didn't notice that, sorry! Since all issues have been resolved I'm marking theme as APPROVED.

#27 @xavortm
4 years ago

Thanks :)

#28 @emiluzelac
4 years ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.