WordPress.org

Make WordPress Themes

#18444 closed theme (live)

THEME: Pictorico - 1.01

Reported by: automattic Owned by: catchthemes
Priority: new theme Keywords: theme-pictorico
Cc: themes@…

Description

Pictorico - 1.0

A single-column, grid-based portfolio theme with large featured images and a post slider, perfect for photoblogging or a portfolio site.

Theme URL - http://theme.wordpress.com/themes/pictorico/
Author URL - http://automattic.com

SVN - https://themes.svn.wordpress.org/pictorico/1.0
ZIP - https://wordpress.org/themes/download/pictorico.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#18444 THEME: Pictorico - 1.01 closed live catchthemes

(this ticket)

#19109 THEME: Pictorico - 1.03 closed live tskk
#19202 THEME: Pictorico - 1.04 closed live emiluzelac
#19682 THEME: Pictorico - 1.06 closed live jcastaneda
#20090 THEME: Pictorico - 1.07 closed live emiluzelac


https://themes.svn.wordpress.org/pictorico/1.0/screenshot.png

Change History (8)

comment:1 @catchthemes15 months ago

  • Owner set to catchthemes
  • Status changed from new to reviewing

comment:2 @catchthemes15 months ago

Theme Check Plugin Errors and Recommendations:No issues found.
Depreciated Functions:No issues found.
Code Quality: No issues found.
Plugin Territory: No issues found.
Template Tags and Hooks: No issues found.
Security and Privacy: No issues found.


Theme Check:

  • Move $content_width definition inside the Theme setup function. View tickets #18303 and #18189 for reference.

License, Theme Name, Credit Links, Up-Sell Themes:

  • Themes are required to declare copyright and license information as specified by the applicable license.See the format that you should add in your readme.txt file e.g.:
    Twenty Fourteen WordPress Theme, Copyright 2014 WordPress.org
    Twenty Fourteen is distributed under the terms of the GNU GPL
    
  • All images, js, bundle files used must be GPL comptible.
    • License details of images used in Screenshot.png is not found. Please add all license details of all the images used in Screenshot.png.
    • Themes are required to document in the Theme readme or license file the copyright/license attribution for all bundled resources. Themes are required to provide this documentation in the Theme readme file, regardless of where or how those bundled resources provide their own attribution. Cannot find it for flexslider.
Last edited 15 months ago by catchthemes (previous) (diff)

comment:3 @automattic15 months ago

Thanks for the review!

Move $content_width definition inside the Theme setup function. View tickets #18303 and #18189 for reference.

There seems to be a lot of discussion around this, and the jury is still out. Is it a blocker, or can we revisit once a firm decision has been made in core?

Ref:
https://github.com/Automattic/_s/pull/460
https://github.com/Automattic/_s/pull/100
https://core.trac.wordpress.org/ticket/21256
https://core.trac.wordpress.org/ticket/27863

Themes are required to declare copyright and license information as specified by the applicable license.See the format that you should add in your readme.txt file e.g.:

We've included this information in style.css rather than readme.txt as per the _s standard: https://github.com/Automattic/_s/blob/master/style.css#L17

We'll include license information for the screenshot photos and Flexslider in a future release, just want to clarify that the above two issues are/are not blockers before we proceed. Thanks again.

comment:4 @catchthemes15 months ago

  • Cc chipbennett added

About the content width issue, i think there is no problem. But about the license issue, i will have to ping someone with greater authority :).

@chipbennett: hi Chip, needing your help again. Can I approve the theme with a notification for future reviewers about the license issue?(Since the author has made it clear)

Last edited 15 months ago by catchthemes (previous) (diff)

comment:5 @chipbennett15 months ago

Including license information in style.css is fine.

The guidelines are quite clear regarding $content_width. Everything in functions.php must be inside a callback, hooked into an appropriate action/filter hook. But it is a minor issue, that at the reviewer's discretion can be considered as something to be addressed in the next Theme revision.

comment:6 @themetracbot15 months ago

  • Summary changed from THEME: Pictorico - 1.0 to THEME: Pictorico - 1.01

Pictorico - 1.01

A single-column, grid-based portfolio theme with large featured images and a post slider, perfect for photoblogging or a portfolio site.

Theme URL - http://theme.wordpress.com/themes/pictorico/
Author URL - http://automattic.com

SVN - https://themes.svn.wordpress.org/pictorico/1.01
ZIP - https://wordpress.org/themes/download/pictorico.1.01.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/pictorico/1.0&new_path=/pictorico/1.01

History:

Ticket Summary Status Resolution Owner
#18444 THEME: Pictorico - 1.01 closed live catchthemes

(this ticket)

#19109 THEME: Pictorico - 1.03 closed live tskk
#19202 THEME: Pictorico - 1.04 closed live emiluzelac
#19682 THEME: Pictorico - 1.06 closed live jcastaneda
#20090 THEME: Pictorico - 1.07 closed live emiluzelac


https://themes.svn.wordpress.org/pictorico/1.01/screenshot.png

comment:7 @catchthemes15 months ago

  • Cc chipbennett removed
  • Status changed from reviewing to approved

All issues resolved. No further issues. Marking theme as approved.

@chipbennet: Thanks for your help.

comment:8 @emiluzelac15 months ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.