WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#18732 closed theme (live)

THEME: Mercury - 1.0.3

Reported by: ryansommers Owned by: salsaturation
Priority: new theme Keywords: theme-mercury child-theme parent-P2
Cc: ryan@…

Attachments (1)

mercury-issues1.jpg (89.6 KB) - added by salsaturation 4 years ago.

Download all attachments as: .zip

Change History (23)

#1 @ryansommers
4 years ago

I had to change the folder name of the parent theme and the reference to it in style.css.

When you download P2 from p2theme.com, it extracts to a folder name of p2-wpcom.

But when trying to upload, I kept receiving the error "For child themes, you must use a parent theme that already exists in the directory."

Users may have a hard time figuring out they need to either rename the parent theme directory, or change the Template reference in style.css.

#2 @salsaturation
4 years ago

  • Keywords changed from theme-mercury, child-theme, parent-P2 to theme-mercury child-theme parent-P2

@ryansommers

Not sure what you mean by the above comments. When I go to p2theme.com it points me to pworg for the download and the extracted folder is p2 as expected which makes you theme activation fail... so I think you need to keep the reference as p2 as most users will download the theme from wporg.

I changed it to and it worked as expected

Template:       p2
Version:        1.0.0
*/

@import url("../p2/style.css");

please note the case-sensitive Template: P2 vs p2

Also I think you have inadvertently bundled the p2 theme in you theme - please remove and resubmit. Thumbnail is also broken

Last edited 4 years ago by salsaturation (previous) (diff)

#3 follow-up: @ryansommers
4 years ago

My apologies, I must have downloaded it from http://theme.wordpress.com/themes/p2/

The download link is http://public-api.wordpress.com/rest/v1/themes/download/p2.zip, but it downloads a file named p2-wpcom-1-5-3.zip, and extracts to a folder called "p2-wpcom."

I just double checked the download at http://wordpress.org/themes/p2 and you're right, the folder name ends up being just p2.

And yes, I had included that P2 folder as a workaround for getting the automated theme checker to give me a passing grade. Chalk it up to being a first-time uploader, I'm a newb. When I uploaded it pointing to "p2-wpcom" and it kept telling me it couldn't find all the required files (because it couldn't find the parent theme), I thought it meant I had to include the parent theme in the upload. Once I did, those errors went away. Might be a bug?

Do I resubmit the theme at http://wordpress.org/themes/upload/ or upload it as an attachment here?

#4 in reply to: ↑ 3 @salsaturation
4 years ago

Replying to ryansommers:

My apologies, I must have downloaded it from http://theme.wordpress.com/themes/p2/

The download link is http://public-api.wordpress.com/rest/v1/themes/download/p2.zip, but it downloads a file named p2-wpcom-1-5-3.zip, and extracts to a folder called "p2-wpcom."

I just double checked the download at http://wordpress.org/themes/p2 and you're right, the folder name ends up being just p2.

And yes, I had included that P2 folder as a workaround for getting the automated theme checker to give me a passing grade. Chalk it up to being a first-time uploader, I'm a newb. When I uploaded it pointing to "p2-wpcom" and it kept telling me it couldn't find all the required files (because it couldn't find the parent theme), I thought it meant I had to include the parent theme in the upload. Once I did, those errors went away. Might be a bug?

Do I resubmit the theme at http://wordpress.org/themes/upload/ or upload it as an attachment here?

No worries and no need to apologies... were here to help. Yes please resubmit updated version at http://wordpress.org/themes/upload/

#5 @themetracbot
4 years ago

  • Summary changed from THEME: Mercury - 1.0.0 to THEME: Mercury - 1.0.1

#6 @emiluzelac
4 years ago

@salsaturation please feel free to assign to yourself :)

#7 @ryansommers
4 years ago

Just wondering if I'm supposed to do anything before you guys review, or if it's just a matter of making it through the queue?

First theme submission so I'm not sure if I'm missing anything :)

Thanks,

Ryan

#8 @salsaturation
4 years ago

  • Owner set to salsaturation
  • Status changed from new to reviewing

@ryansommers - Sorry had another review in progress so didn't take this one incase someone else had time to do this review. I will do the review

#9 @salsaturation
4 years ago

Hi Ryan

Thanks for the patience - Please find my review. The ones marked 'Required' need to be resolved before theme can be approved. When ready please resubmit updated version at http://wordpress.org/themes/upload/

Required: header.php: Apart from the default stylesheet all styles/scripts are required to be enqueued correctly via a function callback and hooked to the appropriate action - please remove the following and enqueue them correctly:
<link href='http://fonts.googleapis.com/css?family=Open+Sans:400,700,300' rel='stylesheet' type='text/css'>
Also please note that href='http://fonts will cause problems for https users - use href='fonts instead.

Required: Themes are required to use theme-slug ( or a reasonably unique slug) as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.)
See http://make.wordpress.org/themes/guidelines/guidelines-code-quality/ . 'function p2_remove_iPhone' should be something like 'function mercury_p2_remove_iPhone'

Required
Please retain the original theme licence. The following needs to be put back, but you can edit the tags to suit your theme

License: GNU General Public License v2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Tags: blue, custom-colors, two-columns, fixed-layout, rtl-language-support, right-sidebar, white, light, front-page-post-form, translation-ready, custom-background, custom-header, custom-menu, post-formats, sticky-post, theme-options

This theme, like WordPress, is licensed under the GPL.
Use it to make something cool, have fun, and share what you've learned with others

Required: Please change the them url from https://github.com/ryansommers/mercury to http://ryansommers.com/mercury/

Required: Please remove all unused files
._screenshot.png
img/._icons.png
img/._icons-2x.png

Visual Test
Required: The following bugs introduced as part of mercury child theme (see screenshot)

  • Menu and title missalignment on inner pages - ok on homepage
  • Sidebar Comments widget avatar - text padding

Auto Theme Test results - For your info - some already covered above
WARNING: Found wrong tag, remove focus from your style.css header.
WARNING: Found wrong tag, remove from your style.css header.
WARNING: .ds_store Hidden Files or Folders found.
RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
INFO: Possible hard-coded links were found in the file footer.php.
Line 15: <?php printf( ( 'Theme: %1$s by %2$s.', 'Mercury' ), 'Mercury', '<a href='http://ryansommers.com/' rel='designer'>Ryan Sommers</a>' ); ?>
INFO: inc/template-tags.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 45: require( ABSPATH . '/wp-admin/includes/template.php' );
Line 192: include_once( ABSPATH . '/wp-admin/includes/media.php' );

Thanks

#10 @ryansommers
4 years ago

Thanks, I think I've got everything except this one:

"Menu and title missalignment on inner pages - ok on homepage"

I didn't see an attached screenshot to see what you're seeing. The title and menu look like they're in the same place on all pages to me.

#11 @salsaturation
4 years ago

Opps there you go

#12 @ryansommers
4 years ago

I remember seeing that issue when I first started developing the theme, but thought I'd fixed it (haven't seen it myself since).

What browser and browser version are you using?

#13 @salsaturation
4 years ago

Latest Chrome

Here is the user agent string

Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.114 Safari/537.36

#14 @themetracbot
4 years ago

  • Summary changed from THEME: Mercury - 1.0.1 to THEME: Mercury - 1.0.2

#15 @themetracbot
4 years ago

  • Summary changed from THEME: Mercury - 1.0.2 to THEME: Mercury - 1.0.3

#16 @salsaturation
4 years ago

  • Status changed from reviewing to approved

Hi Ryan

Thank you for addressing all the issues.

@Admin - all issues fixed therefore

Recommend: I recommend that the theme should be approved

#17 @ryfry07
4 years ago

Last edited 4 years ago by ryfry07 (previous) (diff)

#18 @ryansommers
4 years ago

Checking in to see how long it typically takes for a theme to move from approved to live?

Thanks!

Ryan

#19 @salsaturation
4 years ago

Hi Ryan

Unfortunately the Admins are volunteers as well and they are swamped at the moment. Currently they do batch approvals whenever possible.. hopefully you wont have to wait much longer.

Thanks

Tom

#20 @ryansommers
4 years ago

I figured, no problem. Thanks for the update.

#21 @Otto42
4 years ago

  • Resolution set to live
  • Status changed from approved to closed

#22 @emiluzelac
3 years ago

Screenshot needs to be an actual facsimile of your theme. Please remove the small screen in next release.

Thanks!

Note: See TracTickets for help on using tickets.