WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18794 closed theme (not-approved)

THEME: Eighties - 1.0.0

Reported by: Kopepasah Owned by: imon Hasan
Priority: new theme Keywords: theme-eighties
Cc: justin@…

Description

Eighties - 1.0.0

Hi. I'm a modern theme designed to keep your content front and center.

Theme URL - http://kopepasah.com/project/eighties/
Author URL - http://kopepasah.com/

SVN - https://themes.svn.wordpress.org/eighties/1.0.0
ZIP - https://wordpress.org/themes/download/eighties.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#18794 THEME: Eighties - 1.0.0 closed not-approved imon Hasan

(this ticket)

#19074 THEME: Eighties - 1.0.2 closed live imon Hasan
#19387 THEME: Eighties - 1.0.3 closed live poena
#19582 THEME: Eighties - 1.1.0 closed live catchthemes
#19802 THEME: Eighties - 1.2.0 closed live Milmor
#20259 THEME: Eighties - 1.2.1 closed live sixhours
#41836 THEME: Eighties – 1.3.0 closed live benlumia007


https://themes.svn.wordpress.org/eighties/1.0.0/screenshot.png


Change History (19)

#1 @imon Hasan
3 years ago

  • Owner set to imon Hasan
  • Status changed from new to reviewing

#2 @imon Hasan
3 years ago

General review

Required Issues

RECOMMENDED: could not find the file readme.txt in the theme. Please see http://codex.wordpress.org/Theme_Review#Theme_Documentation for more information.

  • No license info provided for the resources used in the theme. Please provide license info for all the frameworks,images , js used in the theme. You need to state the license explicitly in the readme.txt file.
  • Attribution for TwentyThirteen is missing - attribution copyright/license of resources and derivative work/code should be in the following format
Resource name here - ​http://resource.url/
License: Distributed under the terms of the License Name
Copyright: Author, authorurl.com

pls read or check theme review guideline

http://www.chipbennett.net/2011/04/20/a-guide-to-reviewing-themes-for-the-wordpress-theme-repository/
http://codex.wordpress.org/Theme_Review

this is not complete review
thanks

#3 follow-up: @Kopepasah
3 years ago

Imon,

I do not believe a readme.txt is required for a theme (I know you just recommended it); as such, I do not plan to add one. There is a readme.md that will contain the information about the theme and the licenses are defined in the style.css file.

I am not sure what you are referring to in regards to "Attribution for TwentyThirteen is missing". Could you please explain?

#4 in reply to: ↑ 3 @imon Hasan
3 years ago

  • Cc emiluzelac added

Replying to Kopepasah:

Imon,

I do not believe a readme.txt is required for a theme (I know you just recommended it); as such, I do not plan to add one. There is a readme.md that will contain the information about the theme and the licenses are defined in the style.css file.

I am not sure what you are referring to in regards to "Attribution for TwentyThirteen is missing". Could you please explain?

  • you are not provide license info about js,frameworks in style.css or readme.txt => image must be public domain image or GPL compatible . even screenshot

http://make.wordpress.org/themes/guidelines/guidelines-license-theme-name-credit-links-up-sell-themes/

  • i don't know theme is support readme.md or not . so i refer this issue for senior reviewer
  • Attribution for TwentyThirteen is missing => sorry about that i make a mistake

#5 @Kopepasah
3 years ago

No problem Imon. Thanks for you initial review.

The project is on Github and the newer style.css contains more information regarding licenses.

#6 @Kopepasah
3 years ago

Update: I've just released version 1.0.1 of Eighties. This version is more up to date with what I want to release on WordPress.org.

#7 follow-up: @chipbennett
3 years ago

What help do you need?

#8 in reply to: ↑ 7 @imon Hasan
3 years ago

Replying to chipbennett:

What help do you need?

  • this theme have no readme.txt file but have readme.md
  • No license info provided for the resources used in the theme. Please provide license info for all the frameworks,images , js used in the theme and also not state the license explicitly in the readme.txt file.

can i approve that ? or theme author need to provide those information

because theme author say :

  • I do not believe a readme.txt is required for a theme (I know you just recommended it); as such, I do not plan to add one. There is a readme.md that will contain the information about the theme and the licenses are defined in the style.css file.

#9 follow-up: @chipbennett
3 years ago

A particular readme is not required, as long as required documentation is included. Per the WordPress 3.9 Guidelines revisions:

Themes are required to document in the Theme readme or license file the copyright/license attribution for all bundled resources.

So, copyright/license information for bundled resources must be attributed explicitly in a readme or license file.

What resources are bundled? Are their copyright/license attributions included?

#10 in reply to: ↑ 9 @imon Hasan
3 years ago

Replying to chipbennett:

A particular readme is not required, as long as required documentation is included. Per the WordPress 3.9 Guidelines revisions:

Themes are required to document in the Theme readme or license file the copyright/license attribution for all bundled resources.

So, copyright/license information for bundled resources must be attributed explicitly in a readme or license file.

What resources are bundled? Are their copyright/license attributions included?

He state the theme copyright/license only in style.css but not declared any license info about js,framework use in theme only provide the resources link or font

just like that

'/*
Theme Name: Eighties
Theme URI: http://kopepasah.com/project/eighties/
Author: Justin Kopepasah
Author URI: http://kopepasah.com/
Description: Hi. I'm a modern theme designed to keep your content front and center.
Version: 1.0.0
License: GNU General Public License v2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Text Domain: eighties
Domain Path: /languages/
Tags: light, custom-header, one-column, responsive-layout, custom-menu, sticky-post, threaded-comments, translation-ready, editor-style, featured-images

This theme, like WordPress, is licensed under the GPL.
Use it to make something cool, have fun, and share what you've learned with others.
Eighties is based on Underscores http://underscores.me/, (C) 2012-2014 Automattic, Inc.

Resetting and rebuilding styles have been helped along thanks to the fine work of
Eric Meyer http://meyerweb.com/eric/tools/css/reset/index.html
along with Nicolas Gallagher and Jonathan Neal http://necolas.github.com/normalize.css/
and Blueprint http://www.blueprintcss.org/
*/

thanks

#11 @Manoz69
3 years ago

I'm not sure if I can post here but Guidelines: License, Theme Name, Credit Links, Up-Sell Themes will probably help.

I looked at some .js files and all licenses informations are displayed and MIT licensed (wich is GPL compatible) but not in a readme or documentation file. I do not understand why it is difficult to add them in the readme.md?

#12 @Kopepasah
3 years ago

Hey guys, I am currently working on a readme.txt and it will include all necessary information (e.g. Description, Installation, FAQs, et cetera). I'll have something pushed up later today.

#13 @Kopepasah
3 years ago

Pushed a tag that includes a readme.txt. https://github.com/kopepasah/eighties/releases/tag/1.0.2

I'll update SVN later today.

#14 @imon Hasan
3 years ago

  • Cc emiluzelac removed

any update ? if not i will close this ticket within 24 hours

#15 @imon Hasan
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

no update from theme author .

#16 @Kopepasah
3 years ago

Imon,

The newer version (1.0.2) can be found on Github or downloaded as a zip.

I am not sure how to push a new version to SVN here. I am familiar with using SVN with plugins and core, but not themes. Anyone have a resource for this?

#17 follow-up: @imon Hasan
3 years ago

Hi,

their is a link for upload theme

https://wordpress.org/themes/upload/

after upload pls give me your ticket link . i will review it

thanks

#18 in reply to: ↑ 17 @Kopepasah
3 years ago

Replying to imon Hasan:

Hi,

their is a link for upload theme

https://wordpress.org/themes/upload/

after upload pls give me your ticket link . i will review it

thanks

Surely there has to be a better way that uploading a new theme each time.

Note: See TracTickets for help on using tickets.