WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#18916 closed theme (live)

THEME: Healthy WP - 1.0.2

Reported by: StefanRisticDev Owned by: tamim007
Priority: new theme Keywords: theme-healthy-wp
Cc: stefan.ristic@…

Description

Change History (16)

#1 @emiluzelac
4 years ago

  • Owner set to tamim007
  • Status changed from new to reviewing

Trainee assigned

#2 @tamim007
4 years ago

Initial Theme Check

RECOMMENDED: could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.

Also it will be good for you, if you please read this -> Theme Review Guide

RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Please resolve these steps and install Theme Check plugin in your development environment to check common problem of your theme.

#3 @StefanRisticDev
4 years ago

Hello Tamim!

Those are the recommended implementations, and as far as I understand those are not required. Am I correct?

Thanks.

#4 @StefanRisticDev
4 years ago

I have the Theme Check plugin installed and running, but I think that those recommended steps are not required in order to submit the theme?

#5 @tamim007
4 years ago

Hi @StefanRisticDev,

Please check this link Theme Review , Under Theme Features section you should see

Whether implementing required, recommended, or optional features, Themes are required to support proper WordPress core implementation of all included features.

These are best practices for ensuring Wordpress Coding standards ! But yes , not required . Let us know.

#6 @StefanRisticDev
4 years ago

Thank you for the clarification.

I've implemented all recommendations except custom header one, which I don't think is needed with this theme.

If I re-upload the theme from here:

https://wordpress.org/themes/upload/

it should automatically update this thread, right?

#8 @themetracbot
4 years ago

  • Summary changed from THEME: Healthy WP - 1.0 to THEME: Healthy WP - 1.0.1

#9 @emiluzelac
4 years ago

Few notes:

  • Theme uses <div id = "main"> while there should be <div id="main"> space must be removed in the order for this to work.
  • Author URL is inappropriate it leads to an empty page.
  • Use bundled JS and remove wp_enqueue_script( 'jquery-min', get_template_directory_uri() . '/js/jquery-latest.min.js' );
  • Menu was created with CSS Menu Maker which is not compatible with GPL: http://cssmenumaker.com/terms-of-use-privacy

Question:

  • Screenshot images are GPL-Compatible? if so can you add the license and/or few words about it?

#10 @emiluzelac
4 years ago

Any updates here?

#11 @StefanRisticDev
4 years ago

Sorry, got really busy with some things.

Re screenshot question: Those images are from the PixaBay plugin. I will replace the images with GPL-Compatible ones.

The problems from the notes should be solved by Sunday...

#12 @emiluzelac
4 years ago

Perfect! Thanks :)

#13 @tamim007
4 years ago

Thanks to both of you! :)

#14 @themetracbot
4 years ago

  • Summary changed from THEME: Healthy WP - 1.0.1 to THEME: Healthy WP - 1.0.2

#15 @StefanRisticDev
4 years ago

Spaces removed from classes/ids.

Author URL removed for now.

Additional JS became unnecessary since I had to re-code the menu(removed).

Menu changed.

Re images:

If I'm not missing something, PixaBay images turned to be GPL(CC0) compatible:
https://make.wordpress.org/themes/2014/06/05/gpl-compatible-images/

so I left the screenshot as is.

#16 @emiluzelac
4 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

Thanks! All good.

Note: See TracTickets for help on using tickets.