WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 4 years ago

#19074 closed theme (live)

THEME: Eighties - 1.0.2

Reported by: Kopepasah Owned by: imon Hasan
Priority: previously reviewed Keywords: theme-eighties
Cc: greenshady

Description

Eighties - 1.0.2

Hello. I'm a modern, progressively enhanced theme designed to keep your content front and center. My menu and sidebar are built to stay out of the way until a user wants to see them; giving users what they want, when they want it.

Theme URL - http://eighties.me
Author URL - http://kopepasah.com/

SVN - https://themes.svn.wordpress.org/eighties/1.0.2
ZIP - https://wordpress.org/themes/download/eighties.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/eighties/1.0.0&new_path=/eighties/1.0.2

History:

Ticket Summary Status Resolution Owner
#18794 THEME: Eighties - 1.0.0 closed not-approved imon Hasan
#19074 THEME: Eighties - 1.0.2 closed live imon Hasan

(this ticket)

#19387 THEME: Eighties - 1.0.3 closed live poena
#19582 THEME: Eighties - 1.1.0 closed live catchthemes
#19802 THEME: Eighties - 1.2.0 closed live Milmor
#20259 THEME: Eighties - 1.2.1 closed live sixhours
#41836 THEME: Eighties – 1.3.0 closed live benlumia007


https://themes.svn.wordpress.org/eighties/1.0.2/screenshot.png

Change History (13)

#1 @imon Hasan
4 years ago

  • Owner set to imon Hasan
  • Status changed from new to reviewing

#2 follow-ups: @imon Hasan
4 years ago

Hi,

Require issue :

  • Theme url can not be to a mere demo - theme url if used must be to a page/site with content relevant to the theme itself.
  • functions.php: Use get_stylesheet_directory_uri() instead of get_template_directory_uri() for all theme bundled resources.
  • use wp_enqueue_script instead of wp_register_script
  • all font css should be add using wp_enqueue_style on function.php
  • you can not use add_editor_style instead of wp_enqueue_style

This is a full review and all required issue must be resolved before the theme can be approved.

#3 in reply to: ↑ 2 ; follow-up: @Kopepasah
4 years ago

Replying to imon Hasan:

  • Theme url can not be to a mere demo - theme url if used must be to a page/site with content relevant to the theme itself.
  • functions.php: Use get_stylesheet_directory_uri() instead of get_template_directory_uri() for all theme bundled resources.
  • use wp_enqueue_script instead of wp_register_script
  • all font css should be add using wp_enqueue_style on function.php
  • you can not use add_editor_style instead of wp_enqueue_style

Where are you getting this information?

#4 in reply to: ↑ 3 @imon Hasan
4 years ago

Replying to Kopepasah:

Replying to imon Hasan:

  • Theme url can not be to a mere demo - theme url if used must be to a page/site with content relevant to the theme itself.
  • functions.php: Use get_stylesheet_directory_uri() instead of get_template_directory_uri() for all theme bundled resources.
  • use wp_enqueue_script instead of wp_register_script
  • all font css should be add using wp_enqueue_style on function.php
  • you can not use add_editor_style instead of wp_enqueue_style

Where are you getting this information?

check out this link

http://make.wordpress.org/themes/guidelines/guidelines-template-tags-and-hooks/

you must read theme guideline before upload the theme

http://codex.wordpress.org/Theme_Review

#5 @imon Hasan
4 years ago

  • Cc greenshady added; justin@… removed

can you pls look at this ticket for his question . my be you are well explain that question

Where are you getting this information?

#6 in reply to: ↑ 2 @Kopepasah
4 years ago

Imon,

I think you are misinterpreting the guidelines for template tags and hooks. I can help you understand this better if you can give me an example of code from Eighties that you are questioning.

I can answer the first question though:

  • Theme url can not be to a mere demo - theme url if used must be to a page/site with content relevant to the theme itself.

The Theme URI eighties.me serves as both a resource for information about the theme and a demo of the theme. This is the location where I will share information, updates and other content relevant to the theme; as such, it is best to use this as the Theme URI.

#7 follow-up: @imon Hasan
4 years ago

1 )

// Add Editor Style
	add_editor_style( 'css/editor.css' );

2 )

// Font Awesome Icons
	wp_enqueue_style( 'font-awesome', get_template_directory_uri() . '/fonts/fa/font-awesome.css' );


3)

// Register scripts
	wp_register_script( 'backstretch', get_template_directory_uri() . '/js/jquery.backstretch.js', array( 'jquery' ), '2.0.4',  true  );
	wp_register_script( 'bigslide',    get_template_directory_uri() . '/js/jquery.bigslide.js',    array( 'jquery' ), '0.4.3',  true  );
	wp_register_script( 'fitvids',     get_template_directory_uri() . '/js/fitvids.js',            false,             '1.0.3',  true  );

	// Change no-js to js on the documentElement.
	wp_enqueue_script( 'eighties-enable-js', get_template_directory_uri() . '/js/eighties-enable-js.js', false, '20140502', false );

	// Enqueue global (includes navigation and others).
	wp_enqueue_script( 'eighties', get_template_directory_uri() . '/js/eighties.js', array( 'fitvids' ), '20120206', true );

	// Skip link focus. NOTE Review this.
	wp_enqueue_script( 'eighties-skip-link-focus-fix', get_template_directory_uri() . '/js/skip-link-focus-fix.js', false, '20130115', true );

	if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) {
		wp_enqueue_script( 'comment-reply' );
	}


* Theme uri 



    Themes may optionally designate Author URI and Theme URI in style.css.

        Theme URI, if used, is required to link to a page specifically related to the Theme. If a demonstration site or page is being used, the content must be related to the theme itself.
        Author URI, if used, is required to link to an author’s personal web site or project/development website.
        Themes are recommended to provide at least one of these two links, in order to ensure Theme users have a point of contact for the Theme developer.


#8 in reply to: ↑ 7 @Kopepasah
4 years ago

Replying to imon Hasan:

1 )

// Add Editor Style
	add_editor_style( 'css/editor.css' );

This is the method for adding a stylesheet to the TinyMCE editor. Using wp_enqueue_style() is not the proper method to do this.

---

Using get_template_directory_uri() in these instances is perfectly acceptable as these files are not meant to be overridden by a child theme. get_stylesheet_directory_uri() should only be used when the resource is meant to be overridden by the child theme. None of those resources are meant to be overridden by the child theme, as doing so could cause issues with the theme.

---

Using wp_register_script() is best when a script is a dependent of another script. For example, the eighties script depends on fitvids, but this does not mean fitvids should be enqueued. If the theme were to enqueue fitvids (instead of registering) anyone dequeueing eighties would still have fitvids unnecessarily enqueued. Following this practice ensures that you have dependent scripts enqueued only when you need them.

---

On a side note, I noticed that I am registering a script that I do not need or use. It is not causing any problems in the theme (as it is never enqueued), but should be removed. I have added this to my issue tracker and will address this issue at a later date.

#9 @tskk
4 years ago

Theme url is probably fine.

get_template_directory_uri() can be used for all elements of theme that are not intended to be overriden by child theme. So using it for loading fontawesome is fine otherwise child themes will have to include those files in them.

wp_register_script can also be used

add_editor_style is for tinymce, it makes the editor content look like front end

#10 @imon Hasan
4 years ago

  • Status changed from reviewing to approved

no major issue found

#11 @greenshady
4 years ago

I think you all may have covered this, but just in case:

Theme url can not be to a mere demo - theme url if used must be to a page/site with content relevant to the theme itself.

The URL is more than just a demo. It's relevant and informational about the theme.

functions.php: Use get_stylesheet_directory_uri() instead of get_template_directory_uri() for all theme bundled resources.

Definitely do not do this. "Stylesheet" is always for the active theme, which means that if a user installs or creates a child theme, this will break. "Template" is for the active theme or parent theme if a child theme is installed. Read this: http://justintadlock.com/archives/2010/11/17/how-to-load-files-within-wordpress-themes

use wp_enqueue_script instead of wp_register_script

That's not an either/or. These two functions serve two different purposes. The use of wp_register_script() is to register scripts for later use.

all font css should be add using wp_enqueue_style on function.php

You can @import them via style.css or another stylesheet as well.

you can not use add_editor_style instead of wp_enqueue_style

You must use add_editor_style() to add editor stylesheets. wp_enqueue_style() will not work for this.

#12 @imon Hasan
4 years ago

thanks @greenshady

#13 @Otto42
4 years ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.