WordPress.org

Make WordPress Themes

Opened 4 years ago

Closed 3 years ago

#19173 closed theme (live)

THEME: Smartline Lite - 1.0.1

Reported by: ThemeZee Owned by: fasterthemes
Priority: new theme Keywords: theme-smartline-lite
Cc: emiluzelac, chipbenett

Description

Smartline Lite - 1.0

Smartline Lite is a perfect theme for news and magazine websites as well as simple blogs. The responsive design with bold colors and smart lines looks great on any device. The main highlight of Smartline is the flexible and widgetized front page template which allows you to create a magazine-styled homepage with ease.

Theme URL - http://themezee.com/themes/smartline/
Author URL - http://themezee.com

SVN - https://themes.svn.wordpress.org/smartline-lite/1.0
ZIP - https://wordpress.org/themes/download/smartline-lite.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#19173 THEME: Smartline Lite - 1.0.1 closed live fasterthemes

(this ticket)

#20570 THEME: Smartline Lite - 1.0.2 closed live nishasingh
#20937 THEME: Smartline Lite - 1.0.3 closed live gpriday
#21268 THEME: Smartline Lite - 1.0.4 closed live karmatosed
#21586 THEME: Smartline Lite - 1.0.5 closed live catchthemes
#21793 THEME: Smartline Lite - 1.0.6 closed live karmatosed
#22041 THEME: Smartline Lite - 1.0.7 closed live karmatosed
#22111 THEME: Smartline Lite - 1.0.8 closed live karmatosed
#22517 THEME: Smartline Lite - 1.0.9 closed live karmatosed
#22661 THEME: Smartline Lite - 1.1 closed live poena
#22997 THEME: Smartline Lite - 1.1.1 closed live emiluzelac
#23253 THEME: Smartline Lite - 1.1.2 closed live emiluzelac
#23496 THEME: Smartline Lite – 1.1.3 closed live jcastaneda
#23792 THEME: Smartline Lite – 1.1.4 closed live jcastaneda
#24062 THEME: Smartline Lite – 1.1.5 closed live poena
#24466 THEME: Smartline Lite – 1.1.6 closed live karmatosed
#24768 THEME: Smartline Lite – 1.1.7 closed live jcastaneda
#25009 THEME: Smartline Lite – 1.1.8 closed live karmatosed
#25337 THEME: Smartline Lite – 1.1.9 closed live jcastaneda
#25648 THEME: Smartline Lite – 1.2 closed live downstairsdev
#25905 THEME: Smartline Lite – 1.2.1 closed live jcastaneda
#26216 THEME: Smartline Lite – 1.2.2 closed live rabmalin
#26588 THEME: Smartline Lite – 1.2.3 closed live jcastaneda
#26860 THEME: Smartline Lite – 1.2.4 closed live jcastaneda
#27232 THEME: Smartline Lite – 1.2.5 closed live jcastaneda
#27596 THEME: Smartline Lite – 1.2.6 closed live jcastaneda
#27954 THEME: Smartline Lite – 1.2.7 closed live karmatosed
#28014 THEME: Smartline Lite – 1.2.8 closed live karmatosed
#28305 THEME: Smartline Lite – 1.2.9 closed live jcastaneda
#28625 THEME: Smartline Lite – 1.3.0 closed live karmatosed
#28977 THEME: Smartline Lite – 1.3.1 closed live karmatosed
#29393 THEME: Smartline Lite – 1.3.2 closed live karmatosed
#29986 THEME: Smartline Lite – 1.3.3 closed live emiluzelac
#30822 THEME: Smartline Lite – 1.3.4 closed live jcastaneda
#32185 THEME: Smartline Lite – 1.3.5 closed live themetracbot
#32984 THEME: Smartline Lite – 1.3.6 closed live themetracbot
#33868 THEME: Smartline Lite – 1.3.7 closed live themetracbot
#34886 THEME: Smartline Lite – 1.3.8 closed live themetracbot
#34898 THEME: Smartline Lite – 1.3.9 closed live themetracbot
#34997 THEME: Smartline Lite – 1.4.0 closed live themetracbot
#35829 THEME: Smartline Lite – 1.4.1 closed live themetracbot
#36451 THEME: Smartline Lite – 1.4.2 closed live themetracbot
#38717 THEME: Smartline Lite – 1.4.3 closed live themetracbot
#39900 THEME: Smartline Lite – 1.4.4 closed live themetracbot
#50464 THEME: Smartline Lite – 1.4.5 closed live themetracbot


https://themes.svn.wordpress.org/smartline-lite/1.0/screenshot.png


Attachments (1)

smartline-lite.1.0.4.zip (612.0 KB) - added by KAWASHKAR 2 years ago.

Download all attachments as: .zip

Change History (13)

#1 @emiluzelac
4 years ago

  • Owner set to smartcat
  • Status changed from new to reviewing

#2 @ThemeZee
4 years ago

Hi there,

Thanks for taking the time to review our newest theme.

In case you need a quick overview of Smartline you can check the documentation page: http://themezee.com/docs/smartline-documentation/

I don't know but maybe it helps you to review the theme.

Cheers,
Thomas from ThemeZee

#3 @ThemeZee
4 years ago

Any update on this review? :)

#4 @ThemeZee
4 years ago

  • Cc emiluzelac chipbenett added; netzberufler@… removed

@Emil & Chip: There was no response for 13 days now. Can you please assign the ticket to another reviewer? Thank you :)

#5 @fasterthemes
4 years ago

Can we take this up ?

#6 @emiluzelac
4 years ago

  • Owner changed from smartcat to fasterthemes

#7 @fasterthemes
4 years ago

Hi Thomas.

Please find below a few points which were show-stoppers and we couldn't complete the full theme review. Please fix these point first and then we'll have a deeper look and will provide you the detailed feedback.
Points are :

  1. All the variable names must start with "theme slug".
  1. When we click on SAVE MENU in wp-admin then we get following errors :
       Notice: Trying to get property of non-object
       Notice: Undefined index: designation
       Notice: Undefined index: emp_num  
    
  1. Custom widget developed by you doesn't work. It throws following error :
Notice: WP_Query was called with an argument that is <strong>deprecated</strong> 
since version 3.1! 
"caller_get_posts" is deprecated. Use "ignore_sticky_posts" instead. 
  1. When we QUICK EDIT a post or page and then update in WP-admin then it throws following errors :
       Notice: Trying to get property of non-object
       Notice: Undefined index: designation 
       Notice: Trying to get property of non-object
    

Please get these fixed and we'll then have a deeper look as mentioned above.

#8 @ThemeZee
4 years ago

Hi there,

Thanks for the fast review, I highly appreciated it.

I'm sorry that I have to disagree with your first point. In my opinion only function, class and variable names in the global namespace should be prefixed with the theme slug to avoid name collisions, but it should be no requirement for any variables inside of functions.

Therefore most variable names should be just fine without the theme slug as prefix. We can discuss that point and I like to hear your arguments :)

I was also not able to reconstruct the SAVE MENU and QUICK EDIT errors. My theme does not make any changes to these core functions. I have also searched all theme files and there is no 'designation' index which could be undefined.

Could you please check these errors again? Maybe there is some plugin which causes these issues on your test website?

Thanks for pointing out the 'caller_get_posts' issue, I really missed that it is deprecated. I have fixed it and will upload the update the next minutes.

#9 @themetracbot
4 years ago

  • Summary changed from THEME: Smartline Lite - 1.0 to THEME: Smartline Lite - 1.0.1

Smartline Lite - 1.0.1

Smartline Lite is a perfect theme for news and magazine websites as well as simple blogs. The responsive design with bold colors and smart lines looks great on any device. The main highlight of Smartline is the flexible and widgetized front page template which allows you to create a magazine-styled homepage with ease.

Theme URL - http://themezee.com/themes/smartline/
Author URL - http://themezee.com

SVN - https://themes.svn.wordpress.org/smartline-lite/1.0.1
ZIP - https://wordpress.org/themes/download/smartline-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/smartline-lite/1.0&new_path=/smartline-lite/1.0.1

History:

Ticket Summary Status Resolution Owner
#19173 THEME: Smartline Lite - 1.0.1 closed live fasterthemes

(this ticket)

#20570 THEME: Smartline Lite - 1.0.2 closed live nishasingh
#20937 THEME: Smartline Lite - 1.0.3 closed live gpriday
#21268 THEME: Smartline Lite - 1.0.4 closed live karmatosed
#21586 THEME: Smartline Lite - 1.0.5 closed live catchthemes
#21793 THEME: Smartline Lite - 1.0.6 closed live karmatosed
#22041 THEME: Smartline Lite - 1.0.7 closed live karmatosed
#22111 THEME: Smartline Lite - 1.0.8 closed live karmatosed
#22517 THEME: Smartline Lite - 1.0.9 closed live karmatosed
#22661 THEME: Smartline Lite - 1.1 closed live poena
#22997 THEME: Smartline Lite - 1.1.1 closed live emiluzelac
#23253 THEME: Smartline Lite - 1.1.2 closed live emiluzelac
#23496 THEME: Smartline Lite – 1.1.3 closed live jcastaneda
#23792 THEME: Smartline Lite – 1.1.4 closed live jcastaneda
#24062 THEME: Smartline Lite – 1.1.5 closed live poena
#24466 THEME: Smartline Lite – 1.1.6 closed live karmatosed
#24768 THEME: Smartline Lite – 1.1.7 closed live jcastaneda
#25009 THEME: Smartline Lite – 1.1.8 closed live karmatosed
#25337 THEME: Smartline Lite – 1.1.9 closed live jcastaneda
#25648 THEME: Smartline Lite – 1.2 closed live downstairsdev
#25905 THEME: Smartline Lite – 1.2.1 closed live jcastaneda
#26216 THEME: Smartline Lite – 1.2.2 closed live rabmalin
#26588 THEME: Smartline Lite – 1.2.3 closed live jcastaneda
#26860 THEME: Smartline Lite – 1.2.4 closed live jcastaneda
#27232 THEME: Smartline Lite – 1.2.5 closed live jcastaneda
#27596 THEME: Smartline Lite – 1.2.6 closed live jcastaneda
#27954 THEME: Smartline Lite – 1.2.7 closed live karmatosed
#28014 THEME: Smartline Lite – 1.2.8 closed live karmatosed
#28305 THEME: Smartline Lite – 1.2.9 closed live jcastaneda
#28625 THEME: Smartline Lite – 1.3.0 closed live karmatosed
#28977 THEME: Smartline Lite – 1.3.1 closed live karmatosed
#29393 THEME: Smartline Lite – 1.3.2 closed live karmatosed
#29986 THEME: Smartline Lite – 1.3.3 closed live emiluzelac
#30822 THEME: Smartline Lite – 1.3.4 closed live jcastaneda
#32185 THEME: Smartline Lite – 1.3.5 closed live themetracbot
#32984 THEME: Smartline Lite – 1.3.6 closed live themetracbot
#33868 THEME: Smartline Lite – 1.3.7 closed live themetracbot
#34886 THEME: Smartline Lite – 1.3.8 closed live themetracbot
#34898 THEME: Smartline Lite – 1.3.9 closed live themetracbot
#34997 THEME: Smartline Lite – 1.4.0 closed live themetracbot
#35829 THEME: Smartline Lite – 1.4.1 closed live themetracbot
#36451 THEME: Smartline Lite – 1.4.2 closed live themetracbot
#38717 THEME: Smartline Lite – 1.4.3 closed live themetracbot
#39900 THEME: Smartline Lite – 1.4.4 closed live themetracbot
#50464 THEME: Smartline Lite – 1.4.5 closed live themetracbot


https://themes.svn.wordpress.org/smartline-lite/1.0.1/screenshot.png

#10 @fasterthemes
4 years ago

  • Status changed from reviewing to approved

In my opinion only function, class and variable names in the global namespace should be prefixed with the theme slug to avoid name collisions, but it should be no requirement for any variables inside of functions. You are right !


I was also not able to reconstruct the SAVE MENU and QUICK EDIT errors. My theme does not make any changes to these core functions. I have also searched all theme files and there is no 'designation' index which could be undefined. We tried on our live server and it worked fine.Might be some temp issue on our localhost.


@Admins : All the issues have been addressed and in our opinion theme is good to go live !

#11 @ThemeZee
4 years ago

Thank you so much for taking the time to review the theme and approving it :)

#12 @emiluzelac
3 years ago

  • Resolution set to live
  • Status changed from approved to closed

Marking live based on @ThemeZee review and quick scan only.

Note: See TracTickets for help on using tickets.