WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#19573 closed theme (not-approved)

THEME: Quick-Vid - 2.0.0

Reported by: mattdanner Owned by: jcastaneda
Priority: theme update Keywords: theme-quick-vid
Cc: matt@…

Description

Quick-Vid - 2.0.0

Quick-Vid is a free theme designed by the guys at iThemes

Theme URL - http://ithemes.com/quick-vid
Author URL - http://ithemes.com

SVN - https://themes.svn.wordpress.org/quick-vid/2.0.0
ZIP - https://wordpress.org/themes/download/quick-vid.2.0.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/quick-vid/1.0.3&new_path=/quick-vid/2.0.0

History:

Ticket Summary Status Resolution Owner
#299 THEME: Quick-Vid - 0.0.1 closed closed-newer-version-uploaded
#386 THEME: Quick-Vid - 0.0.2 closed closed-newer-version-uploaded
#435 THEME: Quick-Vid - 0.0.3 closed closed-newer-version-uploaded Frumph
#552 THEME: Quick-Vid - 0.0.4 closed not-approved Frumph
#824 THEME: Quick-Vid - 0.0.5 closed not-approved cais
#1004 THEME: Quick-Vid - 1.0.0 closed closed-newer-version-uploaded Frumph
#1005 THEME: Quick-Vid - 1.0.1 closed suggest-approval
#1012 THEME: Quick-Vid - 1.0.2 closed live cais
#2933 THEME: Quick-Vid - 1.0.3 closed live kovshenin
#19573 THEME: Quick-Vid - 2.0.0 closed not-approved jcastaneda

(this ticket)


https://themes.svn.wordpress.org/quick-vid/2.0.0/screenshot.png

Change History (4)

#1 @jcastaneda
3 years ago

  • Owner set to jcastaneda
  • Status changed from new to reviewing

#2 @jcastaneda
3 years ago

Great to see you're wanting to keep the theme up-to-date! Since it has been so long I'll have to do a total review. :)

required

  • all CSS/JS must be properly enqueued
  • function checks:
    • add_image_size
    • body_class
    • wp_nav_menu
    • get_custom_header
  • Translation missing in some
    • archive.php ( 'Filed under:' )
    • comments.php
    • functions.php ( sidebar name )
    • search.php ( 'Filed under:' )
    • sidebar.php
  • wp_footer() must be before closing body tag.
  • title can only have wp_title and must be filtered
  • Please make sure that add_theme_support calls are hooked to after_setup_theme

These are some of the things I noticed code-wise; as for visual things the biggest one being the fallback menu isn't styled.

I'll leave the ticket open. If you have any questions, please don't hesitate to ask and I'll try to reply as soon as I can. :)

-Jose

#3 @mattdanner
3 years ago

Thanks! Sorry I just now saw this. We'll take care of getting these items updated and re-submit.

#4 @jcastaneda
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hey Matt, sorry to close the ticket but it has been some time. I think it's awesome you're trying to keep the theme up to date. :)

If you have questions please don't hesitate to ask. :)

Note: See TracTickets for help on using tickets.