WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#19731 closed theme (not-approved)

THEME: White Xmas - 1.3

Reported by: poena Owned by: catchthemes
Priority: theme update Keywords: theme-white-xmas accessibility-ready
Cc: myazalea@…, joedolson

Description

White Xmas - 1.2

A responsive, accessible seasonal Christmas theme in blue and white. -Hide the images in the customizer and it's suitable all year round. Swedish translation included.

Theme URL - http://gratistema.se/white-xmas/
Author URL - http://layout.nu/about/

SVN - https://themes.svn.wordpress.org/white-xmas/1.2
ZIP - https://wordpress.org/themes/download/white-xmas.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/white-xmas/1.01&new_path=/white-xmas/1.2

History:

Ticket Summary Status Resolution Owner
#15533 THEME: White Xmas - 1.01 closed live rohitink
#19731 THEME: White Xmas - 1.3 closed not-approved catchthemes

(this ticket)

#21827 THEME: White Xmas - 1.4 closed live karmatosed
#29148 THEME: White Xmas – 1.5 closed live karmatosed
#46522 THEME: White Xmas – 1.6 closed live themetracbot


https://themes.svn.wordpress.org/white-xmas/1.2/screenshot.png

Change History (7)

#1 @poena
3 years ago

  • Keywords changed from theme-white-xmas, accessibility-ready to theme-white-xmas accessibility-ready

Please don't close the ticket until an accessibility review has been made.

#2 @catchthemes
3 years ago

  • Owner set to catchthemes
  • Status changed from new to reviewing

#3 @catchthemes
3 years ago

  • Cc joedolson added

No issues with update.

@joedolson: Theme update needs accessibility review, can you help me with this?

#4 @joedolson
3 years ago

Accessibility Review:

Images:

No theme-contributed img elements noted. Featured images include alt attribute. Looks good.

Media:

None noted.

Headings:

Should not have an H2 before an H1; currently, the site description appears before the site title and uses an H2. Recommend: style the site description as a div or a p; it's not a semantic heading for anything, as it is not followed by any kind of content. Otherwise it's fine.

Link Text:

Read more links look great. For administrative accessibility, it would be good to have the Edit links also include the post title; although it could certainly be screen-reader hidden text.

Keyboard Navigation:

I can't tell for certain whether this theme supports drop-down menus; they're present on the page, but hidden. I don't see any logic in either CSS or JS to make them visible, but I could just be missing something. If they are supposed to be hidden, you may want to change your wp_nav_menu call to set the depth argument so that those extra items aren't present on the page.

Your responsive menu toggle is an <h2>. As a heading, this is an invalid use of a heading; but it also breaks keyboard and screen reader accessibility for activating controls. That control should be changed to either an <a> or a <button>. (Additionally, it didn't appear to work for me; but I only tested this in Chrome.)

For other keyboard navigability: it looks like everything has a good focus outline, and that works for me.

Contrasts:

The contrast between links and normal text is only 2.89:1; this works because the links are also underlined. However, the difference between the default state and hover state for links is the same difference, and is below the requirements. You need to either increase the color contrast between those two states or toggle the text-decoration on hover to improve the visibility of that action.

The :hover state for the Skip to Content link is white, which falls well below contrast minimums.

Skip Link:

The skip link should be moved to appear as the first focusable element on the page, before the linked site title. Otherwise, it's fine.

Forms:

Forms looked good.

#5 @themetracbot
3 years ago

  • Summary changed from THEME: White Xmas - 1.2 to THEME: White Xmas - 1.3

White Xmas - 1.3

A responsive, accessible seasonal Christmas theme in blue and white. -Hide the images in the customizer and it's suitable all year round. Swedish translation included.

Theme URL - http://gratistema.se/white-xmas/
Author URL - http://layout.nu/about/

SVN - https://themes.svn.wordpress.org/white-xmas/1.3
ZIP - https://wordpress.org/themes/download/white-xmas.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/white-xmas/1.2&new_path=/white-xmas/1.3

History:

Ticket Summary Status Resolution Owner
#15533 THEME: White Xmas - 1.01 closed live rohitink
#19731 THEME: White Xmas - 1.3 closed not-approved catchthemes

(this ticket)

#21827 THEME: White Xmas - 1.4 closed live karmatosed
#29148 THEME: White Xmas – 1.5 closed live karmatosed
#46522 THEME: White Xmas – 1.6 closed live themetracbot


https://themes.svn.wordpress.org/white-xmas/1.3/screenshot.png

#6 @joedolson
3 years ago

Just one remaining issue, and it's an easy fix: you're now using an anchor element for the Menu toggle in responsive, which is an improvement -- but it doesn't have an href attribute. Anchors without href attributes are not links - links are a subset of the anchor element controlled by the href attribute. Because the anchor doesn't have an href attribute, it's not natively actionable or focusable.

You'll need to add an href attribute to that toggle. I usually use href='#menu-container', so that the link actually points directly at the menu that will be opened.

#7 @chipbennett
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.