WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#19732 closed theme (live)

THEME: Studio-X - 1.0.3

Reported by: xavortm Owned by: rohitink
Priority: new theme Keywords: theme-studio-x
Cc: xavortm@…

Description

Studio-X - 1.0.0

Studio X is free WordPress theme directly focused on Typography and making the user feel great reading your articles. If you have any questions about it please, write in the support forums in WordPress.

Theme URL -
Author URL - http://xavortm.com

SVN - https://themes.svn.wordpress.org/studio-x/1.0.0
ZIP - https://wordpress.org/themes/download/studio-x.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#19732 THEME: Studio-X - 1.0.3 closed live rohitink

(this ticket)

#20393 THEME: Studio-X - 1.1.0 closed live karmatosed


https://themes.svn.wordpress.org/studio-x/1.0.0/screenshot.png


Change History (17)

#1 @themetracbot
3 years ago

  • Summary changed from THEME: Studio-X - 1.0.0 to THEME: Studio-X - 1.0.1

Studio-X - 1.0.1

Studio X is free WordPress theme directly focused on Typography and making the user feel great reading your articles. If you have any questions about it please, write in the support forums in WordPress.

Theme URL -
Author URL - http://xavortm.com

SVN - https://themes.svn.wordpress.org/studio-x/1.0.1
ZIP - https://wordpress.org/themes/download/studio-x.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/studio-x/1.0.0&new_path=/studio-x/1.0.1

History:

Ticket Summary Status Resolution Owner
#19732 THEME: Studio-X - 1.0.3 closed live rohitink

(this ticket)

#20393 THEME: Studio-X - 1.1.0 closed live karmatosed


https://themes.svn.wordpress.org/studio-x/1.0.1/screenshot.png

#2 @bravokeyl
3 years ago

  • Owner set to bravokeyl
  • Status changed from new to reviewing

#3 @rohitink
3 years ago

I Will take this ticket up :)

#4 @emiluzelac
3 years ago

  • Owner changed from bravokeyl to rohitink

#5 @rohitink
3 years ago

Hello, xavortm.

I will review this by tomorrow. :)

#6 @xavortm
3 years ago

That would be great. After that i could work on updating the theme with the issues you find. I am waiting for your review :)

#7 @rohitink
3 years ago

  1. You are not inheriting Font awesome Documentation. Please remove Documentation licensed under CC BY 3.0 from the readme.
  1. Correct Way of Declaring Copyrights/Licenses is this. http://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/
  1. State License Explicitly for Images in img folder. License for other content like JS files, Navwalker, etc should be stated.
  1. All theme defined functions in functions.php should be prefixed with theme name.
  1. Following is Plugin Territory. Not allowed. In header.php
<meta name="description" content="<?php bloginfo( 'description' ); ?>">
<meta name="author" content="<?php bloginfo( 'author' ); ?>">
  1. It is recommended to make your theme Translation Ready :). Not Required though.

#8 @xavortm
3 years ago

  1. All theme defined functions in functions.php should be prefixed with theme name.

Why is this requiremend? In my other theme the reviewer did the same statment and then said its fine if its wrapped in class.

Also i have a question: do i have to state all images inside the img folder, even those i have created?

Another thing:

  1. Following is Plugin Territory. Not allowed. In header.php

Then i guess this have to be updated:
http://codex.wordpress.org/Meta_Tags_in_WordPress

Last edited 3 years ago by xavortm (previous) (diff)

#9 @themetracbot
3 years ago

  • Summary changed from THEME: Studio-X - 1.0.1 to THEME: Studio-X - 1.0.2

Studio-X - 1.0.2

Studio X is free WordPress theme directly focused on Typography and making the user feel great reading your articles. If you have any questions about it please, write in the support forums in WordPress.

Theme URL -
Author URL - http://xavortm.com

SVN - https://themes.svn.wordpress.org/studio-x/1.0.2
ZIP - https://wordpress.org/themes/download/studio-x.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/studio-x/1.0.1&new_path=/studio-x/1.0.2

History:

Ticket Summary Status Resolution Owner
#19732 THEME: Studio-X - 1.0.3 closed live rohitink

(this ticket)

#20393 THEME: Studio-X - 1.1.0 closed live karmatosed


https://themes.svn.wordpress.org/studio-x/1.0.2/screenshot.png

#10 @rohitink
3 years ago

  1. Regard function prefixes. Yes, if they are inside class no prefix reqd. Sorry abaout that.
  1. For the images created by you. You should explicitly state that they have been created by you and fall under theme's license.
  1. The Following License is not allowed: Attribution-NoDerivs 2.0 Generic (CC BY-ND 2.0) Please replace that Image, and use something that is Public Domain or GPL Compatible. Many good choices available here: http://pixabay.com/

Seems like all other issues have been resolved.

#11 @themetracbot
3 years ago

  • Summary changed from THEME: Studio-X - 1.0.2 to THEME: Studio-X - 1.0.3

Studio-X - 1.0.3

Studio X is free WordPress theme directly focused on Typography and making the user feel great reading your articles. If you have any questions about it please, write in the support forums in WordPress.

Theme URL -
Author URL - http://xavortm.com

SVN - https://themes.svn.wordpress.org/studio-x/1.0.3
ZIP - https://wordpress.org/themes/download/studio-x.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/studio-x/1.0.2&new_path=/studio-x/1.0.3

History:

Ticket Summary Status Resolution Owner
#19732 THEME: Studio-X - 1.0.3 closed live rohitink

(this ticket)

#20393 THEME: Studio-X - 1.1.0 closed live karmatosed


https://themes.svn.wordpress.org/studio-x/1.0.3/screenshot.png

#12 @rohitink
3 years ago

  • Status changed from reviewing to approved

All Good Now :)

#13 @xavortm
3 years ago

yeah, thanks for the reviewing :) In the future i thought to add just a little bit more customization, because i am not really happy with how the single post look like. Would it be fine to add Redux Framework for the options pannel?

I believe if the license is fine, then there is no problem, but just to make sure, because there are not many themes in the official WordPress theme directory that uses them.

#14 @rohitink
3 years ago

Yes, Brother. Redux Framework is totally Fine. I use it in all my latest themes :)

#15 @xavortm
3 years ago

Uh ... im sorry to keep asking here this, but can you link me where you have used the framework, becasue from my experience in the past half an hour it prints tons of WARNINGs in the theme-check plugin.

(the type of "file_get_contents was found..." warnings). I believe a theme is unacseptable with them, but they are part of the framework and not my job. Any advice on this?

Version 0, edited 3 years ago by xavortm (next)

#16 @rohitink
3 years ago

Add me on Hangouts, and i will explain :)

#17 @emiluzelac
3 years ago

  • Resolution set to live
  • Status changed from approved to closed

We are now officially 2 months behind and it is virtually impossible to catch up.

I am batch modifying all* reviewer-approved themes older than 7 days.

If there is an issue and I am sure that some will be, we will address in next update.

We are absence of choice and admin aware :)

Note: See TracTickets for help on using tickets.