WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20006 closed theme (live)

THEME: Microfusion - 1.3

Reported by: design311 Owned by: sakinshrestha
Priority: new theme Keywords: theme-microfusion
Cc: hello@…

Description

MicroFusion - 1.0.1

MicroFusion is a very clean WordPress theme which supports 2 widget-areas and 2 menu locations. If you need support contact me at <a href="mailto:hello@…">hello@…</a>

Theme URL -
Author URL - http://design311.com/

SVN - https://themes.svn.wordpress.org/microfusion/1.0.1
ZIP - https://wordpress.org/themes/download/microfusion.1.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha

(this ticket)


https://themes.svn.wordpress.org/microfusion/1.0.1/screenshot.png


Change History (31)

#1 @design311
3 years ago

A new version is on its way, if you could kindly await this new version before reviewing this theme that would be great. Thanks!

#2 @emiluzelac
3 years ago

  • Owner set to sakinshrestha
  • Status changed from new to reviewing

I am sure that @sakinshrestha will :)

#3 @sakinshrestha
3 years ago

@design311: Yes sure I will wait for your new version and then start reviewing it. Please make it fast as I am fast at reviewing. :)

#4 @design311
3 years ago

Going through all posts in the WP test unit right now to make sure I didn't forget anything, and then I'll upload it!

#5 @themetracbot
3 years ago

  • Summary changed from THEME: MicroFusion - 1.0.1 to THEME: Microfusion - 1.1

Microfusion - 1.1

Microfusion is a very clean WordPress theme which supports 2 widget-areas and 2 menu locations. If you need support contact me at <a href="mailto:hello@…">hello@…</a>

Theme URL -
Author URL - http://design311.com/

SVN - https://themes.svn.wordpress.org/microfusion/1.1
ZIP - https://wordpress.org/themes/download/microfusion.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/microfusion/1.0.1&new_path=/microfusion/1.1

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha

(this ticket)


https://themes.svn.wordpress.org/microfusion/1.1/screenshot.png

#6 @design311
3 years ago

There we go, overhauled the whole theme a little bit as you can see. Awaiting your review, I don't expect many issues :)

#7 @sakinshrestha
3 years ago

Theme Check Plugin Errors and Recommendations: No issues found
Depreciated Functions: No issues found
Template Tags and Hooks: No issues found
Plugin Territory: No issues found
Theme Check: No issues found


Code Quality:Read Guidelines

  • Correct XFN profile link in <head> tag: <head profile="http://gmpg.org/xfn/11"> or <link rel="profile" href="http://gmpg.org/xfn/11" />

Security and Privacy:Read Guidelines


Licensing, Theme Name, Credit Links, Up-Sell Themes:Read Guidelines

  • Screenshot image license details required. (preferably in readme.txt file)
  • Need to remove <!-- I'm providing this theme free of charge, please leave this here or a kitty dies. --> from footer.php: Against GPL terms

Visual Issues

  • Top menu and main menu issues on default settings. Footer menu overflow issue. Shown in screenshot below.https://www.diigo.com/file/image/qecdbbrzccrbedqpazbesacbop/microfuion+visual+issues.jpg

Other Issues:

  • Use readme.txt instead or readme.md
  • Your top menu depth is set to 1 and this is special case. So, you need to mention about this in your readme.txt file
  • Couldn't find a way to add email and phone number as in screenshot header. Can you explain how to add these in readme.txt file

Fix the above mentioned issues and upload the new version. Thanks

#8 @design311
3 years ago

Thank you very much for your prompt review, I'm fixing these issues now, expect and udpate real soonish :)

#9 @themetracbot
3 years ago

  • Summary changed from THEME: Microfusion - 1.1 to THEME: Microfusion - 1.2

Microfusion - 1.2

Microfusion is a very clean WordPress theme which supports 2 widget-areas and 2 menu locations. If you need support contact me at <a href="mailto:hello@…">hello@…</a>

Theme URL -
Author URL - http://design311.com/

SVN - https://themes.svn.wordpress.org/microfusion/1.2
ZIP - https://wordpress.org/themes/download/microfusion.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/microfusion/1.1&new_path=/microfusion/1.2

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha

(this ticket)


https://themes.svn.wordpress.org/microfusion/1.2/screenshot.png

#10 follow-up: @design311
3 years ago

All issues have been fixed, new version uploaded. :)

I was wondering though, would it be GPL-OK if I reworded the footer sentence to the following:
You're free to do what you want with this theme. Please remember that I made this theme available free of charge, consider leaving this credit link here.

PS: Awesome review layout, you should consider sharing it'''

#11 in reply to: ↑ 10 @sakinshrestha
3 years ago

Replying to design311:

All issues have been fixed, new version uploaded. :)

I was wondering though, would it be GPL-OK if I reworded the footer sentence to the following:
You're free to do what you want with this theme. Please remember that I made this theme available free of charge, consider leaving this credit link here.

PS: Awesome review layout, you should consider sharing it'''

--- Yes, this looks fine but consider adding it in readme.txt file instead of footer.php file.

#12 @sakinshrestha
3 years ago

Previous issues:

  • Code Quality: Fixed
  • Licensing, Theme Name, Credit Links, Up-Sell Themes: Fixed
  • Visual Issues: Fixed
  • Other Issues: Fixed
  • Security and Privacy: Partially Fixed
    • home_url() needs esc_url() and trailingslash in header.php line 14. Read This. It should be as below:
      <?php echo esc_url( home_url( '/' ) ); ?> 
      

New issues:

  • Visual Issues:
    • Added long site title and tagline and it is cropped. Cannot view it all.
    • Assigned Top Menu item and it is overflow to second line.
    • See the screenshot below

https://www.diigo.com/file/image/qqqcreozccrcscdoozbesbrecd/microfusion.jpg


Just a minor issues that need to be fixed before I approve it. Please fix it and submit the new version. Thanks.

#13 @themetracbot
3 years ago

  • Summary changed from THEME: Microfusion - 1.2 to THEME: Microfusion - 1.3

Microfusion - 1.3

Microfusion is a very clean WordPress theme which supports 2 widget-areas and 2 menu locations. If you need support contact me at <a href="mailto:hello@…">hello@…</a>

Theme URL -
Author URL - http://design311.com/

SVN - https://themes.svn.wordpress.org/microfusion/1.3
ZIP - https://wordpress.org/themes/download/microfusion.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/microfusion/1.2&new_path=/microfusion/1.3

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha

(this ticket)


https://themes.svn.wordpress.org/microfusion/1.3/screenshot.png

#14 follow-up: @design311
3 years ago

All done, I don't understand why the trailing slash in home_url() is mandatory though, either the function's default value for the first parameter should change to the trailing slash or the trailing slash should become optional in a theme check. Don't you think so?

If you, or anybody else could explain why it is required, that would be great :)

#15 in reply to: ↑ 14 @sakinshrestha
3 years ago

Replying to design311:

All done, I don't understand why the trailing slash in home_url() is mandatory though, either the function's default value for the first parameter should change to the trailing slash or the trailing slash should become optional in a theme check. Don't you think so?

If you, or anybody else could explain why it is required, that would be great :)

#16 @sakinshrestha
3 years ago

  • Status changed from reviewing to approved

Thanks for the update


All previous issues has been fixed. Marking it as Approved.


Recommendation:

  • Move notification text from footer.php file to readme.txt file.

Note to Admin: There is following notification text in footer.php file, line no 22.

<!-- You're free to do what you want with this theme, but please remember that I made this theme available free of charge, consider leaving the credit link here. -->

#17 follow-up: @design311
3 years ago

I've read that URL before posting it, I see no information why it is important that the trailing slash is included. Could you give me a hint?

#18 @sakinshrestha
3 years ago

@design311: I found one issue in your theme. There is content missing for Error 404. When there is not found, you can empty content. Please fix this in next version update.

#19 in reply to: ↑ 17 ; follow-up: @sakinshrestha
3 years ago

Replying to design311:

I've read that URL before posting it, I see no information why it is important that the trailing slash is included. Could you give me a hint?

#20 in reply to: ↑ 19 @design311
3 years ago

Replying to sakinshrestha:

But I'm not using the scheme parameters, so I don't see why the '/' is mandatory in this case? Either way, will you agree that the first parameter should default to '/' rather than nothing?

Fixing 404 pages now, thanks :)

#21 follow-up: @jcastaneda
3 years ago

You can use: trailingslashit( home_url() ) as well. :)

#22 in reply to: ↑ 21 @design311
3 years ago

Replying to jcastaneda:

You can use: trailingslashit( home_url() ) as well. :)

Thing is, I'm asking why the trailing slash is mandatory?

#23 follow-up: @jcastaneda
3 years ago

For some reason when it's not used it doesn't always work. I'm guessing server configurations. I know when I left it out on my localhost environment the link wouldn't work but works fine on other setups. A little strange. But the function trailingslashit is a good one since it'll append it if left out or if already there it won't. :)

#24 in reply to: ↑ 23 @design311
3 years ago

Replying to jcastaneda:

For some reason when it's not used it doesn't always work. I'm guessing server configurations. I know when I left it out on my localhost environment the link wouldn't work but works fine on other setups. A little strange. But the function trailingslashit is a good one since it'll append it if left out or if already there it won't. :)

Oh! I believe I understand now! For the root domain is is never an issue, but WordPress can also be installed in a subdirectory and then it CAN (but it really shouldn't) be an issue. I was thinking that WordPress was always installed on the root domain, but that's not always the case of course. Thank you and sorry for taking such a long time to understand! :)

#25 follow-up: @jcastaneda
3 years ago

Happy to help. :)

And yes, it took me awhile to understand somethings as well. Rome wasn't built in a day.

#26 in reply to: ↑ 25 ; follow-up: @sakinshrestha
3 years ago

Replying to jcastaneda:

Happy to help. :)

And yes, it took me awhile to understand somethings as well. Rome wasn't built in a day.

  • Thanks for helping @design311 to understand it. Cheers :)

#27 in reply to: ↑ 26 @design311
3 years ago

Replying to sakinshrestha:

  • Thanks for helping @design311 to understand it. Cheers :)

Haha, sorry that you had to call in an emergency helpline, I probably drove you insane (or close) :D

#28 follow-up: @jcastaneda
3 years ago

Funny thing is he didn't. I just happen to be on the timeline and the ticket caught my attention. :)

#29 in reply to: ↑ 28 @sakinshrestha
3 years ago

Replying to jcastaneda:

Funny thing is he didn't. I just happen to be on the timeline and the ticket caught my attention. :)

  • Yes thanks. I was thinking that he will understand it. Anyway problem solved. Thanks :)

#30 follow-up: @emiluzelac
3 years ago

  • Resolution set to live
  • Status changed from approved to closed

When theme uses <!DOCTYPE html> you don't need to do this:

<head profile="http://gmpg.org/xfn/11">
<meta http-equiv="content-type" content="<?php bloginfo('html_type'); ?>; charset=<?php bloginfo('charset'); ?>" />

this is more than enough:

<html <?php language_attributes(); ?>>
<head>
<meta charset="<?php bloginfo( 'charset' ); ?>">

While it works either way, shorter is better!

#31 in reply to: ↑ 30 @sakinshrestha
3 years ago

Replying to emiluzelac:

When theme uses <!DOCTYPE html> you don't need to do this:

<head profile="http://gmpg.org/xfn/11">
<meta http-equiv="content-type" content="<?php bloginfo('html_type'); ?>; charset=<?php bloginfo('charset'); ?>" />

this is more than enough:

<html <?php language_attributes(); ?>>
<head>
<meta charset="<?php bloginfo( 'charset' ); ?>">

While it works either way, shorter is better!

@emiluzelac: Thank Emil and Yes, I understand that. But what about the Code Quality Guideline. Why it is mentioned as

Correct XFN profile link in <head> tag: <head profile="http://gmpg.org/xfn/11"> or <link rel="profile" href="http://gmpg.org/xfn/11" />

If we can update this guide or make it more clear then it will be better for others as well. Thanks.

Note: See TracTickets for help on using tickets.