WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#20116 closed theme (live)

THEME: BirdFIELD - 1.07

Reported by: sysbird Owned by: tareiking
Priority: new theme Keywords: theme-birdfield
Cc: sysbird@…

Description

BirdFIELD - 1.0

BirdFIELD is a responsive web design theme. Feature fullscreen and parallax custom image, and fixed header. The homepage displays with tagged news and the grid posts. You can choose the text color, link color, header background color by theme options.

Theme URL - http://www.sysbird.jp/birdfield/
Author URL - http://www.sysbird.jp/wptips/

SVN - https://themes.svn.wordpress.org/birdfield/1.0
ZIP - https://wordpress.org/themes/download/birdfield.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20116 THEME: BirdFIELD - 1.07 closed live tareiking

(this ticket)

#29741 THEME: BirdFIELD – 1.08 closed live greenshady
#31461 THEME: BirdFIELD – 1.09 closed live themetracbot


https://themes.svn.wordpress.org/birdfield/1.0/screenshot.png


Attachments (3)

long-title-long-tagline.png (900.1 KB) - added by tareiking 3 years ago.
long title
typo-in-homepage-widget.png (8.8 KB) - added by tareiking 3 years ago.
widget area typo
blog-page-with-static-front-page.png (728.6 KB) - added by tareiking 3 years ago.

Download all attachments as: .zip

Change History (41)

#1 @emiluzelac
3 years ago

Trainee assigned ticket.

#2 @emiluzelac
3 years ago

  • Owner set to tareiking
  • Status changed from new to reviewing

#3 @tareiking
3 years ago

Hi Sysbird,

Lovely theme - I've just installed it and will review over the next few days.

#4 @sysbird
3 years ago

Hi Thank You!!

#5 @tareiking
3 years ago

Hi Sysbird,

Automatic Theme-Check went 100% - well done!

I'm about 80% through the Theme review guideline checks and I'm super impressed with your work so far.

Only a few things that I noticed on my journey:

  • Typo in Homepage widget area "ont", presumed "one"
  • Long Site Name and Tagline not 100% supported.
  • Right aligned menu becomes left aligned and drops below Site Name and Tagline
  • Text domain is set as : Birdfarm in styles.css, however its referred to as "birdfield" within translation strings. Suggest editing style.css

Will be in touch with more information tomorrow.

@tareiking
3 years ago

long title

@tareiking
3 years ago

widget area typo

#6 @tareiking
3 years ago

Required: When using static page as front-page, the page assigned to blog posts shows the customer header, but the homepage widget area display differently:

When using static page as front-page, the assigned static page does not show the header (this may be intentional in your design.

#7 @tareiking
3 years ago

Hi Sysbird,

My review is complete the the aforementioned changes required before approval (I have listed them below so you can keep track), please let me know when the changes are updated and I will ask a moderator to review and approve your theme!

  • Typo in Homepage widget area "ont", presumed "one"
  • Long Site Name and Tagline not 100% supported.

-- Right aligned menu becomes left aligned and drops below Site Name and Tagline

  • Text domain is set as : Birdfarm in styles.css, however its referred to as "birdfield" within translation strings. Suggest editing style.css
  • Display issues when setting a static front page

Thanks again for your patience.

#8 @sysbird
3 years ago

Thank You review!
I'll fix problems in a few days.

#9 @themetracbot
3 years ago

  • Summary changed from THEME: BirdFIELD - 1.0 to THEME: BirdFIELD - 1.01

BirdFIELD - 1.01

BirdFIELD is a responsive web design theme. Feature fullscreen and parallax custom image, and fixed header. The homepage displays with tagged news and the grid posts. You can choose the text color, link color, header background color by theme options.

Theme URL - http://www.sysbird.jp/birdfield/
Author URL - http://www.sysbird.jp/wptips/

SVN - https://themes.svn.wordpress.org/birdfield/1.01
ZIP - https://wordpress.org/themes/download/birdfield.1.01.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/birdfield/1.0&new_path=/birdfield/1.01

History:

Ticket Summary Status Resolution Owner
#20116 THEME: BirdFIELD - 1.07 closed live tareiking

(this ticket)

#29741 THEME: BirdFIELD – 1.08 closed live greenshady
#31461 THEME: BirdFIELD – 1.09 closed live themetracbot


https://themes.svn.wordpress.org/birdfield/1.01/screenshot.png

#10 @tareiking
3 years ago

Hi Sysbird,

I've reviewed your diff and everything appears to be addressed. I'm excited that you converted your code match WordPress Coding standards! Nice job.

I'll conditionally approve the theme, and request a senior Theme Review member double check and approve if all is well.

Thanks again for the theme submission, will be in touch!

#11 @cais
3 years ago

At a quick glance (as in just reading the notes here) the author URL is inappropriate ... please see this guideline: http://make.wordpress.org/themes/guidelines/guidelines-license-theme-name-credit-links-up-sell-themes/

#12 @themetracbot
3 years ago

  • Summary changed from THEME: BirdFIELD - 1.01 to THEME: BirdFIELD - 1.02

BirdFIELD - 1.02

BirdFIELD is a responsive web design theme. Feature fullscreen and parallax custom image, and fixed header. The homepage displays with tagged news and the grid posts. You can choose the text color, link color, header background color by theme options.

Theme URL - http://www.sysbird.jp/birdfield/
Author URL - http://www.sysbird.jp/wptips/

SVN - https://themes.svn.wordpress.org/birdfield/1.02
ZIP - https://wordpress.org/themes/download/birdfield.1.02.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/birdfield/1.01&new_path=/birdfield/1.02

History:

Ticket Summary Status Resolution Owner
#20116 THEME: BirdFIELD - 1.07 closed live tareiking

(this ticket)

#29741 THEME: BirdFIELD – 1.08 closed live greenshady
#31461 THEME: BirdFIELD – 1.09 closed live themetracbot


https://themes.svn.wordpress.org/birdfield/1.02/screenshot.png

#13 follow-up: @sysbird
3 years ago

I Add theme option display copyright and display credit.

#14 in reply to: ↑ 13 @cais
3 years ago

Replying to sysbird:

I Add theme option display copyright and display credit.

Although an option to display or not display credit links is nice to add, it does not change the fact the Author URI is not acceptable as it is.

Last edited 3 years ago by cais (previous) (diff)

#15 @sysbird
3 years ago

Hi thanks review!

It's my blog url for tips on Wordpress.
It has been approved in other themes in the Author URI.
Why Do I can not use this URL?

#16 @cais
3 years ago

As far as I am concerned it should not have been approved as an Author URI at any time ... if it has already been approved elsewhere then it will need to be addressed in those themes as well.

#17 @themetracbot
3 years ago

  • Summary changed from THEME: BirdFIELD - 1.02 to THEME: BirdFIELD - 1.03

BirdFIELD - 1.03

BirdFIELD is a responsive web design theme. Feature fullscreen and parallax custom image, and fixed header. The homepage displays with tagged news and the grid posts. You can choose the text color, link color, header background color by theme options.

Theme URL - http://www.sysbird.jp/birdfield/
Author URL - https://profiles.wordpress.org/sysbird/

SVN - https://themes.svn.wordpress.org/birdfield/1.03
ZIP - https://wordpress.org/themes/download/birdfield.1.03.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/birdfield/1.02&new_path=/birdfield/1.03

History:

Ticket Summary Status Resolution Owner
#20116 THEME: BirdFIELD - 1.07 closed live tareiking

(this ticket)

#29741 THEME: BirdFIELD – 1.08 closed live greenshady
#31461 THEME: BirdFIELD – 1.09 closed live themetracbot


https://themes.svn.wordpress.org/birdfield/1.03/screenshot.png

#18 @tareiking
3 years ago

Hi Sysbird,

Thanks for the changes and my apologies for not noticing the author link pointed out by Cais earlier.

I'm not sure whether you have updated the Author URI anywhere else as mentioned, but to save issues down the line with theme updates, I'd recommend doing so on your other themes.

I'll ask one of the senior team members to review my approval once more. Thanks again.

#19 @sysbird
3 years ago

Hi tareiking.

It's my blog url for tips on Wordpress.
What is the problem?

http://www.sysbird.jp/wptips/

#20 follow-up: @emiluzelac
3 years ago

Ticket status please?

#21 in reply to: ↑ 20 @tareiking
3 years ago

  • Status changed from reviewing to approved

Replying to emiluzelac:

Ticket status please?

Hi Sysbird,

Thank you for your theme review. I would like to to set the status to approved pending admin approval.

Last edited 3 years ago by tareiking (previous) (diff)

#22 @tskk
3 years ago

  • Status changed from approved to reopened

Theme URL can't be merely a demo of the theme.
You can leave both author and theme url empty if you don't have appropriate url's.


Readme.txt
https://themes.svn.wordpress.org/birdfield/1.03/readme.txt

Need both copyright and license for bundled resources i.e. html5.js etc


footer.php
https://themes.svn.wordpress.org/birdfield/1.03/footer.php

Any reason respond.min.js can't be added in header.php?


functions.php

Use core function Paginate_links instead of :

function birdfield_the_pagenation() {

	global $wp_rewrite;
	global $wp_query;
	global $paged;

	$birdfield_paginate_base = get_pagenum_link( 1 );
	if ( strpos($birdfield_paginate_base, '?' ) || ! $wp_rewrite->using_permalinks() ) {
		$birdfield_paginate_format = '';
		$birdfield_paginate_base = add_query_arg( 'paged', '%#%' );
	} else {
		$birdfield_paginate_format = ( substr( $birdfield_paginate_base, -1 ,1 ) == '/' ? '' : '/' ) .
		user_trailingslashit( 'page/%#%/', 'paged' );;
		$birdfield_paginate_base .= '%_%';
	}
	echo paginate_links( array(
		'base'		=> $birdfield_paginate_base,
		'format'	=> $birdfield_paginate_format,
		'total'		=> $wp_query->max_num_pages,
		'mid_size'	=> 3,
		'current'	=> ( $paged ? $paged : 1 ),
	));
}

No need for wp_enqueue_script( 'jquery' ); simply add jquery as dependency for whatever scripts that need jquery.

All settings in customizer need sanitization :

function birdfield_customize($wp_customize) {
 
	$wp_customize->add_section( 'birdfield_customize', array(
		'title'		=> __( 'BirdFIELD Options', 'birdfield' ),
		'priority'	=> 999,
	) );

	// Text Color
	$wp_customize->add_setting( 'birdfield_text_color', array(
		'default' => '#222327',
	) );

	$wp_customize->add_control( new WP_Customize_Color_Control( $wp_customize, 'birdfield_text_color', array(
		'label'		=> __( 'Text Color', 'birdfield' ),
		'section'	=> 'birdfield_customize',
		'settings'	=> 'birdfield_text_color',
	) ) );

	// Link Color
	$wp_customize->add_setting( 'birdfield_link_color', array(
		'default' => '#1c4bbe',
	) );

	$wp_customize->add_control( new WP_Customize_Color_Control( $wp_customize, 'birdfield_link_color', array(
		'label'		=> __( 'Link Color', 'birdfield' ),
		'section'	=> 'birdfield_customize',
		'settings'	=> 'birdfield_link_color',
	) ) );

	// Header, Footer Background Color
	$wp_customize->add_setting( 'birdfield_header_color', array(
		'default' => '#79a596',
	) );

	$wp_customize->add_control( new WP_Customize_Color_Control( $wp_customize, 'birdfield_header_color', array(
		'label'		=> __( 'Header, Footer Background Color', 'birdfield' ),
		'section'	=> 'birdfield_customize',
		'settings'	=> 'birdfield_header_color',
	) ) );

	// Display Copyright
	$wp_customize->add_setting( 'birdfield_copyright', array(
		'default'  => 'true',
		'type'     => 'theme_mod',
	) );

	$wp_customize->add_control( 'birdfield_copyright', array(
		'label'		=> __( 'Display Copyright', 'birdfield' ),
		'section'  => 'birdfield_customize',
		'type'     => 'checkbox',
		'settings' => 'birdfield_copyright',
	) );

	// Display Credit
	$wp_customize->add_setting( 'birdfield_credit', array(
		'default'  => 'true',
		'type'     => 'theme_mod',
	) );

	$wp_customize->add_control( 'birdfield_credit', array(
		'label'		=> __( 'Display Credit', 'birdfield' ),
		'section'  => 'birdfield_customize',
		'type'     => 'checkbox',
		'settings' => 'birdfield_credit',
	) );

}

escape get_theme_mod values in

function birdfield_header_style() {

	//Theme Option
	$birdfield_text_color = get_theme_mod( 'birdfield_text_color', '#222327' );
	$birdfield_link_color = get_theme_mod( 'birdfield_link_color', '#1c4bbe' );
	$birdfield_header_color = get_theme_mod( 'birdfield_header_color', '#79a596' );

?>

Use esc_html


prefix $news_posts in https://themes.svn.wordpress.org/birdfield/1.03/news-content.php


#23 @themetracbot
3 years ago

  • Summary changed from THEME: BirdFIELD - 1.03 to THEME: BirdFIELD - 1.04

BirdFIELD - 1.04

BirdFIELD is a responsive web design theme. Feature fullscreen and parallax custom image, and fixed header. The homepage displays with tagged news and the grid posts. You can choose the text color, link color, header background color by theme options.

Theme URL - http://www.sysbird.jp/birdfield/theme/
Author URL - https://profiles.wordpress.org/sysbird/

SVN - https://themes.svn.wordpress.org/birdfield/1.04
ZIP - https://wordpress.org/themes/download/birdfield.1.04.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/birdfield/1.03&new_path=/birdfield/1.04

History:

Ticket Summary Status Resolution Owner
#20116 THEME: BirdFIELD - 1.07 closed live tareiking

(this ticket)

#29741 THEME: BirdFIELD – 1.08 closed live greenshady
#31461 THEME: BirdFIELD – 1.09 closed live themetracbot


https://themes.svn.wordpress.org/birdfield/1.04/screenshot.png

#24 @emiluzelac
3 years ago

@tareiking how are we doing here?

#25 @tareiking
3 years ago

  • Status changed from reopened to approved

Have looked at the diff vs. requested changes by @tskk ~ sysbird has addressed all the mentioned changes - nice work!

Based on this, status updated!

#26 @karmatosed
3 years ago

  • Status changed from approved to reopened

There are weird characters in files for example functions.php and where you call fonts in birdfield_admin_header_style. Please clean these up before we can look to approve the theme.

#27 @themetracbot
3 years ago

  • Summary changed from THEME: BirdFIELD - 1.04 to THEME: BirdFIELD - 1.05

BirdFIELD - 1.05

BirdFIELD is a responsive web design theme. Feature fullscreen and parallax custom image, and fixed header. The homepage displays with tagged news and the grid posts. You can choose the text color, link color, header background color by theme options.

Theme URL - http://www.sysbird.jp/birdfield/theme/
Author URL - https://profiles.wordpress.org/sysbird/

SVN - https://themes.svn.wordpress.org/birdfield/1.05
ZIP - https://wordpress.org/themes/download/birdfield.1.05.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/birdfield/1.04&new_path=/birdfield/1.05

History:

Ticket Summary Status Resolution Owner
#20116 THEME: BirdFIELD - 1.07 closed live tareiking

(this ticket)

#29741 THEME: BirdFIELD – 1.08 closed live greenshady
#31461 THEME: BirdFIELD – 1.09 closed live themetracbot


https://themes.svn.wordpress.org/birdfield/1.05/screenshot.png

#28 @tareiking
3 years ago

  • Status changed from reopened to approved

Thanks for addressing the character issues @sysbird. Marking as approved.

#29 @karmatosed
3 years ago

  • Status changed from approved to reopened

Hi, unfortunately the following needs sorting before the theme can be approved:


Required

  • There is no need to enqueue jQuery. You can load it into the array of an enqueue to ensure dependency.

If you can please do that changes, we can progress with your review. Once you’ve done the revisions, just re-upload through wordpress.org and it will append to this ticket.

#30 @themetracbot
3 years ago

  • Summary changed from THEME: BirdFIELD - 1.05 to THEME: BirdFIELD - 1.06

BirdFIELD - 1.06

BirdFIELD is a responsive web design theme. Feature fullscreen and parallax custom image, and fixed header. The homepage displays with tagged news and the grid posts. You can choose the text color, link color, header background color by theme options.

Theme URL - http://www.sysbird.jp/birdfield/theme/
Author URL - https://profiles.wordpress.org/sysbird/

SVN - https://themes.svn.wordpress.org/birdfield/1.06
ZIP - https://wordpress.org/themes/download/birdfield.1.06.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/birdfield/1.05&new_path=/birdfield/1.06

History:

Ticket Summary Status Resolution Owner
#20116 THEME: BirdFIELD - 1.07 closed live tareiking

(this ticket)

#29741 THEME: BirdFIELD – 1.08 closed live greenshady
#31461 THEME: BirdFIELD – 1.09 closed live themetracbot


https://themes.svn.wordpress.org/birdfield/1.06/screenshot.png

#31 @sysbird
3 years ago

Thanks your review.
I was fixed enqueue jQuery problems.
Last time, forgot attached the /css/ja.css, was added.
and fixed character code of searchform.php.

#32 @tareiking
3 years ago

  • Status changed from reopened to approved

Hi Sysbird,

Thanks for the update ~ everything appears in order as requested.

#33 @karmatosed
3 years ago

  • Status changed from approved to reopened

Hi, unfortunately the following needs sorting before the theme can be approved:


Required

  • No minification of scripts or files unless provide original files.

If you can please do that changes, we can progress with your review. Once you’ve done the revisions, just re-upload through wordpress.org and it will append to this ticket.

#34 @themetracbot
3 years ago

  • Summary changed from THEME: BirdFIELD - 1.06 to THEME: BirdFIELD - 1.07

BirdFIELD - 1.07

BirdFIELD is a responsive web design theme. Feature fullscreen and parallax custom image, and fixed header. The homepage displays with tagged news and the grid posts. You can choose the text color, link color, header background color by theme options.

Theme URL - http://www.sysbird.jp/birdfield/theme/
Author URL - https://profiles.wordpress.org/sysbird/

SVN - https://themes.svn.wordpress.org/birdfield/1.07
ZIP - https://wordpress.org/themes/download/birdfield.1.07.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/birdfield/1.06&new_path=/birdfield/1.07

History:

Ticket Summary Status Resolution Owner
#20116 THEME: BirdFIELD - 1.07 closed live tareiking

(this ticket)

#29741 THEME: BirdFIELD – 1.08 closed live greenshady
#31461 THEME: BirdFIELD – 1.09 closed live themetracbot


https://themes.svn.wordpress.org/birdfield/1.07/screenshot.png

#35 @sysbird
3 years ago

Sorry, I fixed.
No minification of scripts or files unless provide original files.

#36 @emiluzelac
2 years ago

  • Status changed from reopened to reviewing

#37 @emiluzelac
2 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

#38 @sysbird
2 years ago

Thanks!!

Note: See TracTickets for help on using tickets.