WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#20161 closed theme (live)

THEME: Eventbrite Event - 1.2.1

Reported by: smccafferty Owned by: emiluzelac
Priority: new theme Keywords: theme-eventbrite-event
Cc: seanmcc@…, emiluzelac

Description

Eventbrite Event - 1.0

Eventbrite theme for promoting single events

Theme URL -
Author URL - http://voceplatforms.com

SVN - https://themes.svn.wordpress.org/eventbrite-event/1.0
ZIP - https://wordpress.org/themes/download/eventbrite-event.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20161 THEME: Eventbrite Event - 1.2.1 closed live emiluzelac

(this ticket)

#21369 THEME: Eventbrite Event - 1.2.2 closed live downstairsdev
#23603 THEME: Eventbrite Event – 1.3.0 closed live jcastaneda


https://themes.svn.wordpress.org/eventbrite-event/1.0/screenshot.png


Change History (28)

#1 @sittestaccount
3 years ago

Eventbrite is a registered trademark.

I don't think you can place a theme by the company name. Its same like someone posts a theme by the name of Facebook.

#2 @smccafferty
3 years ago

Both the Eventbrite Event and Venue themes were created for Eventbrite, working in conjunction with Automattic, these iterations are just the publicly released version of the themes.

#3 @sakinshrestha
3 years ago

  • Cc emiluzelac added

@emiluzelac: Can you check this ticket? Looks like trademark issues.

#4 @emiluzelac
3 years ago

If EB is behind you would need to add a trademark notice

#5 follow-up: @emiluzelac
3 years ago

What's the status guys?

#6 in reply to: ↑ 5 @sakinshrestha
3 years ago

Replying to emiluzelac:

What's the status guys?

  • Not in my hand. You mentioned that the author need to add a trademark notice and I was waiting for that. I think you need to take this ticket.

#7 @emiluzelac
3 years ago

  • Owner set to emiluzelac
  • Status changed from new to reviewing

#8 @emiluzelac
3 years ago

Not a problem, just assigned both tickets to myself.


Before we can start, can you please clarify that this theme is indeed for Eventbrite and that we are not going against their trademark policy: https://www.eventbrite.com/tos/

The name has a registered trademark and if this theme is not being released by Eventbrite itself, we are not going to able to start the review with Eventbrite as the prefix.


Also please go over our guidelines just to make sure that all items are in place: http://codex.wordpress.org/Theme_Review I've noticed two credit links in footer.php while you can have one and also no ref links are allowed within the URL as well, there might be more :)

#9 @smccafferty
3 years ago

I have reached out to Min ( Automattic ) to confirm the use of the Eventbrite branding within the themes.

As far as the credit links in the footer, this was to give credit where credit is due, as this was an Eventbrite driven project. Is there a more appropriate place for this credit within the theme?

#10 @emiluzelac
3 years ago

Sure, you can use readme.txt or similar. We allow only one credit link in footer.php and that is why I noted before.

#11 @smccafferty
3 years ago

Ok we can shift the credit links around; moving one of them.

We can confirm these themes were for Eventbrite, this blog post ( http://en.blog.wordpress.com/2013/09/16/eventbrite-themes-widgets/ ) highlights the partnership with Automattic, Eventbrite and Voce. Our contact at Eventbrite is @mitchellcolleran.

Would this be sufficient clarification the themes are for Eventbrite or is there further information needed?

#12 @emiluzelac
3 years ago

You didn't have to go that far, verbal confirmation is enough for me. Please note this in readme.txt as well.

#13 @emiluzelac
3 years ago

Preliminary Review:


All parts of the theme, including the screenshot needs to be compatible with GPL.

header.php


JS files must not be hardcoded and need to be properly enqueued via functions:

<!--[if lt IE 9]>
<script src="<?php echo get_template_directory_uri(); ?>/js/libs/selectivizr.min.js"></script>
<![endif]-->

functions.php


There is no need to call jQuery for all scripts, one that gets loaded at all times is more than enough, assuming this one:

wp_enqueue_script( 'eventbrite-event-main', get_template_directory_uri() . '/js/script.js', array( 'jquery' ), '20130915', true );

The rest is overkill:

		wp_enqueue_script( 'eventbrite-event-carousel', get_template_directory_uri() . '/js/bootstrap/bootstrap-carousel.js', array( 'jquery' ), '20130915', true );
		wp_enqueue_script( 'eventbrite-event-collapse', get_template_directory_uri() . '/js/bootstrap/bootstrap-collapse.js', array( 'jquery' ), '20130915', true );
		wp_enqueue_script( 'eventbrite-event-tooltip', get_template_directory_uri() . '/js/bootstrap/bootstrap-tooltip.js', array( 'jquery' ), '20130915', true );
		wp_enqueue_script( 'eventbrite-event-popover', get_template_directory_uri() . '/js/bootstrap/bootstrap-popover.js', array( 'jquery' ), '20130915', true );

#14 @emiluzelac
3 years ago

any news?

#15 @smccafferty
3 years ago

My apologies, we haven't had the time to make the updates yet, although I will get them out this week.

#16 @smccafferty
3 years ago

@emiluzelac I am having issues committing to the SVN repo, I am using my .org credentials although I am getting a permissions error...

svn: E175013: Commit failed (details follow):
svn: E175013: Access to '/!svn/me' forbidden

#17 @emiluzelac
3 years ago

Please https://wordpress.org/themes/upload/ instead. WPORG does not work with SVN's.

#18 @themetracbot
3 years ago

  • Summary changed from THEME: Eventbrite Event - 1.0 to THEME: Eventbrite Event - 1.1

#19 @emiluzelac
3 years ago

Can we fast-forward please?

#20 @themetracbot
3 years ago

  • Summary changed from THEME: Eventbrite Event - 1.1 to THEME: Eventbrite Event - 1.2

#21 @emiluzelac
3 years ago

I am sorry, but we need an explicit license for images used in your screenshot and note from Eventbrite is not included.

#22 @smccafferty
3 years ago

It may be easier to just swap out the images as these screenshots were taken over a year ago. I just want to note the screenshots are in use on WP.com. Also there was no mention earlier in the review process of a note being needed from Eventbrite (only the verbal clarification), we will reach out to our contact at Eventbrite. To simplify this process, what is expected in the note from them?

#23 follow-up: @emiluzelac
3 years ago

Image swap works!

WPCOM and WPORG don't have the same review guidelines, that is probably why they were not mentioned before.

Here at TRT we require GPL-Compatibility with all parts of the theme and that is why we need to address them.

We need a note from Eventbrite stating that this theme was build for them or with them and that will do the trick.

Licensing and trademark is the only hold-up :)

#24 in reply to: ↑ 23 @kwight
3 years ago

Replying to emiluzelac:

We need a note from Eventbrite stating that this theme was build for them or with them and that will do the trick.

Hey Emil! What form and to whom does the note from Eventbrite go? An email somewhere? Just let me know and I'll take care of it with our rep from Eventbrite.

#25 @emiluzelac
3 years ago

Any form works which we can include in readme.txt for example and that will clarify the trademark obstacle.

#26 @kwight
3 years ago

My contact Mitch Colleran at Eventbrite and myself came up with this text:

The Eventbrite Venue and Eventbrite Event themes were developed by Voce Communications in collaboration with Eventbrite, Inc. and Automattic, Inc. The "Eventbrite" name is used with the permission of Eventbrite, Inc. For any concerns, please contact Eventbrite's API team (email: api@…).

So that can just go into the readme.txt?

#27 @themetracbot
3 years ago

  • Summary changed from THEME: Eventbrite Event - 1.2 to THEME: Eventbrite Event - 1.2.1

#28 @emiluzelac
3 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

Thank you all for your help and for being patient during the review process.

Note: See TracTickets for help on using tickets.