WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#20162 closed theme (live)

THEME: Eventbrite Venue - 1.2.1

Reported by: smccafferty Owned by: emiluzelac
Priority: new theme Keywords: theme-eventbrite-venue
Cc: seanmcc@…

Description

Eventbrite Venue - 1.0

Eventbrite theme for venues to promote their events calendar.

Theme URL -
Author URL - http://voceplatforms.com

SVN - https://themes.svn.wordpress.org/eventbrite-venue/1.0
ZIP - https://wordpress.org/themes/download/eventbrite-venue.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20162 THEME: Eventbrite Venue - 1.2.1 closed live emiluzelac

(this ticket)

#21370 THEME: Eventbrite Venue - 1.2.2 closed live downstairsdev
#23604 THEME: Eventbrite Venue – 1.3.0 closed live jcastaneda


https://themes.svn.wordpress.org/eventbrite-venue/1.0/screenshot.png


Change History (14)

#1 @emiluzelac
3 years ago

  • Owner set to emiluzelac
  • Status changed from new to reviewing

#2 @emiluzelac
3 years ago

Preliminary Review:


All parts of the theme, including the screenshot needs to be compatible with GPL.

header.php


JS files must not be hardcoded and need to be properly enqueued via functions:

<!--[if lt IE 9]>
<script src="<?php echo get_template_directory_uri(); ?>/js/libs/selectivizr.min.js"></script>
<![endif]-->

functions.php


There is no need to call jQuery for all scripts, one that gets loaded at all times is more than enough, assuming this one:

wp_enqueue_script( 'eventbrite-venue-main', get_template_directory_uri() . '/js/script.js',                       array( 'jquery' ), '20130915', true );

there is also huge white space between the URL and array.

The rest is overkill:

		// Bootstrap scripts
		wp_enqueue_script( 'eventbrite-venue-carousel', get_template_directory_uri() . '/js/bootstrap/bootstrap-carousel.js', array( 'jquery' ), '20130915', true );
		wp_enqueue_script( 'eventbrite-venue-collapse', get_template_directory_uri() . '/js/bootstrap/bootstrap-collapse.js', array( 'jquery' ), '20130915', true );
		wp_enqueue_script( 'eventbrite-venue-tooltip', get_template_directory_uri() . '/js/bootstrap/bootstrap-tooltip.js', array( 'jquery' ), '20130915', true );
		wp_enqueue_script( 'eventbrite-venue-popover', get_template_directory_uri() . '/js/bootstrap/bootstrap-popover.js', array( 'jquery' ), '20130915', true );

#3 @themetracbot
3 years ago

  • Summary changed from THEME: Eventbrite Venue - 1.0 to THEME: Eventbrite Venue - 1.1

#4 @emiluzelac
3 years ago

License (note) in readme is still missing and as noted images must be GPL-Compatible as well.

#5 @smccafferty
3 years ago

Can you expand on what is meant by a GPL Compatible screenshot? Are you referencing the use of Dumbo in the screenshot. My apologies, I did not see where you mentioned a note of the license in the readme.

#6 @smccafferty
3 years ago

Just wanted to follow up on the response to the above question.

Last edited 3 years ago by smccafferty (previous) (diff)

#7 @emiluzelac
3 years ago

Correct, that would be it. Any part of the screenshot should be under the GPL-Compatible license.

#8 @emiluzelac
3 years ago

As soon as you can add this, we can approve your theme :)

#9 @themetracbot
3 years ago

  • Summary changed from THEME: Eventbrite Venue - 1.1 to THEME: Eventbrite Venue - 1.2

#10 @emiluzelac
3 years ago

I am sorry, but we need an explicit license for images used in your screenshot and note from Eventbrite is not included.

#11 @kwight
3 years ago

My contact Mitch Colleran at Eventbrite and myself came up with this text:

The Eventbrite Venue and Eventbrite Event themes were developed by Voce Communications in collaboration with Eventbrite, Inc. and Automattic, Inc. The "Eventbrite" name is used with the permission of Eventbrite, Inc. For any concerns, please contact Eventbrite's API team (email: api@…).

So that can just go into the readme.txt?

#12 @emiluzelac
3 years ago

Yes please :)

#13 @themetracbot
3 years ago

  • Summary changed from THEME: Eventbrite Venue - 1.2 to THEME: Eventbrite Venue - 1.2.1

#14 @emiluzelac
3 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

Thank you all for your help and for being patient during the review process.


For future release only: please add a license to your screenshot image ;)

Note: See TracTickets for help on using tickets.