WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20225 closed theme (not-approved)

THEME: Mace - 1.0

Reported by: thehosts Owned by: jameskoster
Priority: new theme Keywords: theme-mace
Cc: admin@…

Description

Mace - 1.0

Mace is a fully responsive WordPress theme designed for restaurants, cafes and food bloggers. It has a warm color scheme consisting of a brown background and an elegant orange navigation bar. It comes with a built-in slider, two sidebar positions, social icons and tons of customization options. If you want to setup a food related website quickly and effortlessly then Mace is the theme that you have been looking for.

Theme URL - http://the-hosts.com/mace-wordpress-theme/
Author URL - http://the-hosts.com/

SVN - https://themes.svn.wordpress.org/mace/1.0
ZIP - https://wordpress.org/themes/download/mace.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20225 THEME: Mace - 1.0 closed not-approved jameskoster

(this ticket)

#20936 THEME: Mace - 1.1 closed not-approved jameskoster
#21008 THEME: Mace - 1.23 closed live jameskoster


https://themes.svn.wordpress.org/mace/1.0/screenshot.png


Change History (9)

#1 @khaxan
2 years ago

Hi. Could someone please review the theme?

#2 @emiluzelac
2 years ago

It takes between 4-5 weeks, please be patient. For the time being go to http://codex.wordpress.org/Theme_Review and make sure that your site follow the latest guidelines, that will speed up the process.

#3 @emiluzelac
2 years ago

  • Owner set to jameskoster
  • Status changed from new to reviewing

Trainee assigned ticket

#4 @jameskoster
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hey,

A few things:

Your edit post link in content-single.php - you're running html through a localisation function which isn't recommended. Consider using sprintf(). You can see an example of how to do this in your search.php file. Please check all other edit post links for this behaviour.

Please update your screenshot size to 880x660

In your header.php template file you hard code html5.js. Instead, please include it in your mace_scripts function. You can use the global is_IE var to check the browser. http://codex.wordpress.org/Global_Variables

In your settings you're adding several arrays to the database mace_footer_settings, mace_general_settings, mace_home_settings etc. One setting array is preferred. You may also want to consider sanitizing these settings before output (escape urls etc). http://codex.wordpress.org/Data_Validation

Upon saving the theme settings I get the following errors:

Warning: Missing argument 2 for wp_kses(), called in /wp-content/themes/mace/inc/options-panel.php on line 244 and defined in /Applications/MAMP/htdocs/wp-theme-review/wp-includes/kses.php on line 486

Warning: Invalid argument supplied for foreach() in /wp-content/themes/mace/inc/options-panel.php on line 254

Please activate the theme on a fresh install (with wp_debug enabled) and save the settings to replicate and fix the issue. http://codex.wordpress.org/WP_DEBUG

Your "Show Excerpts" setting doesn't seem to work? I unchecked the setting and added a <!-- more --> tag, the excerpt still displayed. Perhaps this is for specific excerpts? You may want to adjust the description of this setting if so.

Your "Hide Credit Link" setting has one issue: If you set it to display only on the homepage then navigate to the second page of posts it still displays. Technically this is no longer the homepage. You can use is_paged() to check this. http://codex.wordpress.org/Function_Reference/is_paged

If no menu is assigned to your "Mobile Menu" location you just get an unstyled home link on handheld devices: http://cl.ly/image/1F2p1M3g1r3y

There are quite a few validation errors relating to your mobile navigation solution. Please check this out by running a page through http://validator.w3.org/

Coding standards - not a major issue, but you might want to check your code formatting, in particular spacing. Have a look: http://codex.wordpress.org/WordPress_Coding_Standards

#5 @thehosts
2 years ago

Hi. Thank you so much for taking the time to provide such detailed feedback. I will fix these issues and re-upload the theme right away. However I have a few questions. Firstly, is it necessary to fix the validation errors in the mobile navigation solution or is it optional? Secondly, when I add a new version will this thread get re-opened or will have to wait for several weeks again. Please let me know. Thanks.

#6 @jameskoster
2 years ago

Hey,

It is not essential, but I would recommend it as it looked quite a simple fix I think. It will help ensure browser compatibility as well, which can be tricky to test for handheld devices unless you're using BrowserStack or some such service.

If you upload a new version (with bumped version number) this ticket will get re-opened. You won't have to wait as long for the second review.

Cheers!

#7 @thehosts
2 years ago

Hi. I submitted a new version but this thread didn't get reopened. Instead a new one has been created here: https://themes.trac.wordpress.org/ticket/20936

#8 @jameskoster
2 years ago

Hey, sorry about that, this is actually my first review, I believed this ticket would be re-opened. Don't worry, the new ticket has a higher priority and I've requested it be assigned to me ASAP.

#9 @thehosts
2 years ago

No problem. Thanks :)

Note: See TracTickets for help on using tickets.