WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#20361 closed theme (not-approved)

THEME: Geekery - 1.0.1

Reported by: Magnigenie Owned by: basantakumar
Priority: new theme Keywords: theme-geekery
Cc: info@…

Description

Geekery - 1.0

Geekery is a clean elegant theme specialized for Blog, News, Magazine websites.It's 100% responsive theme which adapts to any device.It comes with 10 predefined color schemes to choose from which would change the complete look and feel of your website in just one click.It has a powerful admin theme options to manage different aspects of the sites. The theme supports all post formats and has its own custom fields to make the blog posting much more easier. It is also optimized for SEO, has localization support, social links widget and much more. Check the theme demo @ http://magnigenie.com/geekery-clean-responsive-wordpress-blog-theme and for support check our support forum @ http://magnigenie.com/support

Theme URL - http://www.magnigenie.com/geekery-clean-responsive-wordpress-blog-theme
Author URL - http://www.magnigenie.com

SVN - https://themes.svn.wordpress.org/geekery/1.0
ZIP - https://wordpress.org/themes/download/geekery.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20361 THEME: Geekery - 1.0.1 closed not-approved basantakumar

(this ticket)

#21488 THEME: Geekery - 1.1.2 closed live gregrickaby
#30370 THEME: Geekery115 – 1.1.5 closed not-approved emiluzelac


https://themes.svn.wordpress.org/geekery/1.0/screenshot.png


Change History (8)

#1 @basantakumar
2 years ago

  • Owner set to basantakumar
  • Status changed from new to reviewing

#2 @basantakumar
2 years ago

Hi Magnigenie,

I checked your theme and it seems like there are couple of issues on the theme.

  • There are 46 Errors, 42 warning(s) when validated HTML of the theme.
  • Some of the css files are missing and that's why the font icons are not rendering.

http://s28.postimg.org/ae2q4lj7h/9_8_2014_1_47_06_PM.png

#3 @themetracbot
2 years ago

  • Summary changed from THEME: Geekery - 1.0 to THEME: Geekery - 1.0.1

Geekery - 1.0.1

Geekery is a clean elegant theme specialized for Blog, News, Magazine websites.It's 100% responsive theme which adapts to any device.It comes with 10 predefined color schemes to choose from which would change the complete look and feel of your website in just one click.It has a powerful admin theme options to manage different aspects of the sites. The theme supports all post formats and has its own custom fields to make the blog posting much more easier. It is also optimized for SEO, has localization support, social links widget and much more. Check the theme demo @ http://magnigenie.com/geekery-clean-responsive-wordpress-blog-theme and for support check our support forum @ http://magnigenie.com/support

Theme URL - http://www.magnigenie.com/geekery-clean-responsive-wordpress-blog-theme
Author URL - http://www.magnigenie.com

SVN - https://themes.svn.wordpress.org/geekery/1.0.1
ZIP - https://wordpress.org/themes/download/geekery.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/geekery/1.0&new_path=/geekery/1.0.1

History:

Ticket Summary Status Resolution Owner
#20361 THEME: Geekery - 1.0.1 closed not-approved basantakumar

(this ticket)

#21488 THEME: Geekery - 1.1.2 closed live gregrickaby
#30370 THEME: Geekery115 – 1.1.5 closed not-approved emiluzelac


https://themes.svn.wordpress.org/geekery/1.0.1/screenshot.png

#4 @Magnigenie
2 years ago

Hi basantakumar,

Thanks for reviewing my theme. I have done the necessary changes as per your review.

Regards
-Magnigenie

#5 @basantakumar
2 years ago

  • Status changed from reviewing to approved

#6 @greenshady
2 years ago

  • Status changed from approved to reopened

#7 @greenshady
2 years ago

  • Status changed from reopened to reviewing

This is only a cursory review of the theme's code. It needs to undergo a complete and thorough review before it can be approved. This means looking over each line of code to make sure that it both works and passes our guidelines. The things below are major items that I was able to find in a few minutes looking through the theme code. It is not a full look over the code. At a certain point, I just had to stop.

@basantakumar - Can I get you to re-review this theme? There's a lot that I'm sure I missed because I didn't look through each file. There's also a lot of ground to cover that I mention below.

Screenshot

The original screenshot for this theme was OK. I'm not sure why the reviewer said otherwise.

functions.php

comment_count() function needs to be prefixed.

This line of code should be removed since WP already handles this:

add_post_type_support( 'post', 'post-formats' );

comments.php

Trackbacks and pingbacks must be shown.

Internationalization

You must use a text string for textdomains. You cannot use variables or constants. MG_CURRENT_THEME should be 'geekery'.

Footer Credit

The current footer credit text is not allowed: "Copyrights © 2014 Geekery. All Rights Reserved." This text says that Geekery (theme name) is the copyright holder for the site the theme is being used on, which is not true.

Use of the_title()

The use of the_title() within link attributes breaks when a title has markup in it. It needs to be properly escaped by use of the_title_attribute(). This is in several theme files. It looks like this code:

<a href="<?php the_permalink(); ?>" title="<?php echo __( 'Permanent Link to', MG_CURRENT_THEME );?> <?php the_title(); ?>">

Custom post format meta

The use of the custom post format meta boxes and related metadata is not allowed. This is plugin territory and cannot be added to the theme. All code related to this must be removed.

Page title and subtitle functionality

This functionality is plugin territory and should be removed from the theme.

Limiting number of tags

The functionality to limit the number of tags the user has chosen to display is plugin territory and should be removed from the theme.

Widget security

The widget options for the MG_SocialNetworksWidget widget class are not properly validated and/or sanitized before being saved to the database via the update() method.

Scripts/styles in admin

The theme's admin scripts/styles are loaded on every page in the admin. They should only be loaded on pages that are relevant to the theme.

Theme Options

Theme options must not be saved to the database without the user explicitly saving them. Saving default options to the database is not allowed.

Use sane defaults: https://make.wordpress.org/themes/2014/07/09/using-sane-defaults-in-themes/

header.php

The <title> tag can only have the wp_title() function within it. If you want to do something custom, you need to filter the wp_title hook.

Custom Post Type

The theme uses register_post_type() to register a custom post type. This is plugin territory and not allowed.

#8 @jcastaneda
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing due to inactivity in over a week.

Note: See TracTickets for help on using tickets.