WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#20394 closed theme (closed-newer-version-uploaded)

THEME: OMG - 2.0

Reported by: wpdevshed Owned by: Pawel Wawrzyniak
Priority: new theme Keywords: theme-omg
Cc: charles@…, grapplerulrich

Description

OMG - 1.0

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.0
ZIP - https://wordpress.org/themes/download/omg.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.0/screenshot.png


Change History (36)

#1 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.0 to THEME: OMG - 1.01

OMG - 1.01

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.01
ZIP - https://wordpress.org/themes/download/omg.1.01.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.0&new_path=/omg/1.01

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.01/screenshot.png

#2 @karmatosed
3 years ago

  • Owner set to Pawel Wawrzyniak
  • Status changed from new to reviewing

#3 @karmatosed
3 years ago

  • Cc grapplerulrich added

This is just a note for the reviewer, you have been assigned a mentor to take you through your first reviews. Congratulations, you get grapplerulrich as your mentor!

#4 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.01 to THEME: OMG - 1.2

OMG - 1.2

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.2
ZIP - https://wordpress.org/themes/download/omg.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.01&new_path=/omg/1.2

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.2/screenshot.png

#5 @wpdevshed
3 years ago

Hi Pawel, new version in time I hope to pre-empt some issues I think you would have found with the older version.

#6 @Pawel Wawrzyniak
3 years ago

Hi,

Thank you for the new version with fixes.

I'm sorry for the delay, I'm working on the review and it will be available very soon.

#7 @wpdevshed
3 years ago

Hi Pawel, I've got a newer version which fixes a few things I recently learnt from other theme under review. Do you want me to submit the update now, or happy to wait for your review output and then combine that feedback in next version. Let me know your preference.

#8 @Pawel Wawrzyniak
3 years ago

Hi,

Great to hear that you are working on improvements.
I think that you can upload the latest version and I will update my notes.

Thank you.

#9 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.2 to THEME: OMG - 1.2.1

OMG - 1.2.1

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.2.1
ZIP - https://wordpress.org/themes/download/omg.1.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.2&new_path=/omg/1.2.1

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.2.1/screenshot.png

#10 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.2.1 to THEME: OMG - 1.3

OMG - 1.3

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.3
ZIP - https://wordpress.org/themes/download/omg.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.2.1&new_path=/omg/1.3

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.3/screenshot.png

#11 @wpdevshed
3 years ago

Oops, bit of a version update fail there. Please ignore 1.2.1, we'll go with 1.3. Looking forward to your feedback.

#12 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.3 to THEME: OMG - 1.4

OMG - 1.4

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.4
ZIP - https://wordpress.org/themes/download/omg.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.3&new_path=/omg/1.4

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.4/screenshot.png

#13 @wpdevshed
3 years ago

Hi Pawel, I think this latest version should be pretty good to go. Look forward to any feedback you have. Thanks.

#14 @wpdevshed
3 years ago

Hi Pawel, standing by for your feedback :)

#15 @Pawel Wawrzyniak
3 years ago

Hi,

I'm sorry for the delay.
Here is first part of guidelines.

Required

1
Please use wp_enqueue_style instead of wp_print_styles when loading Google Fonts in omgtheme_fonts function (more info here)

2
You don't need to use wp_register_style you can directly use wp_enqueue_style

3
The title tag in header.php can only contain wp_title() (please remove ' ' )

4
wp_head() should be added immediately before </head>

5
To select character set for meta in header please use bloginfo( ‘charset’ )

6
Please prefix all of the functions with the themes slug. Following function names are not unique (missing omtheme_ prefix):

wp-content/themes/omg/functions.php:587
function remove_br_gallery($output)

wp-content/themes/omg/library/omg.php:38
function rw_title( $title, $sep, $seplocation )

wp-content/themes/omg/library/admin.php:6
function disable_default_dashboard_widgets()

7
Themes are required to support following WordPress classes:

.aligncenter
.alignleft
.alignright
.wp-caption-text

Please prepare CSS for above classes without addtional selectors

Wrong:
.entry-content .aligncenter{}
Ok:
.aligncenter{}

8
screen_icon() found in the file library/class/class-tgm-plugin-activation.php. Deprecated since version 3.8.
Line 381: screen_icon( apply_filters( 'tgmpa_default_screen_icon', 'themes' ) );
Line 1584: screen_icon( apply_filters( 'tgmpa_default_screen_icon', 'themes' ) );

1
Hidding errors with @ is considered as a bad development practice
wp-content/themes/omg/functions.php:568
'base' => @add_query_arg('page','%#%'),

2
$tag_arr variable was never initialized which could generate PHP notices

wp-content/themes/omg/library/omg.php:223
$tag_arr .= $tag->slug . ',';

3
'menus' parameter is read only, and should only be used in the context of current_theme_supports()

wp-content/themes/omg/library/omg.php:200
add_theme_support( 'menus' );

4
There is not editor-style.css
wp-content/themes/omg/library/omg.php:164
add_editor_style()

Optional

1
Some variables in the code are never used. You can remove them.

wp-content/themes/omg/functions.php:595
$name_of_author = get_the_author();

wp-content/themes/omg/functions.php:653
wp-content/themes/omg/functions.php:675

$title = get_post_field('post_title', $id);
$meta = get_post_field('post_excerpt', $id);
$link = wp_get_attachment_url( $id );
Last edited 3 years ago by Pawel Wawrzyniak (previous) (diff)

#16 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.4 to THEME: OMG - 1.5

OMG - 1.5

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.5
ZIP - https://wordpress.org/themes/download/omg.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.4&new_path=/omg/1.5

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.5/screenshot.png

#17 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.5 to THEME: OMG - 1.6

OMG - 1.6

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.6
ZIP - https://wordpress.org/themes/download/omg.1.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.5&new_path=/omg/1.6

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.6/screenshot.png

#18 @wpdevshed
3 years ago

Hi Pawel, added editor-style.css as recommended. Standing by for feedback.

#19 @Pawel Wawrzyniak
3 years ago

Hi,

Thank you very much for the latest changes. Everything looks great :)
Below you can find latest guidelines.

Required

1
wp-content/themes/omg/library/omg.php:197
Please remove current_theme_supports( 'menus' ) from omg.php:197.
current_theme_supports checks a theme's support for a given theme feature and doesn't make sense to use it here. Please, just remove that line and will be fine.

2
You’re required to set the global value of $content_width inside a theme setup function hooked to after_setup_theme. This is important as it allows child themes to overwrite this and add their own $content_width value.

So please move your code from functions.php:55:

if ( ! isset( $content_width ) ) {
  $content_width = 640;
}

to omgtheme_ahoy function.

1
Themes are must spell “WordPress” correctly in all public facing text: all one word, with both an uppercase W and P. I've found at least few places where you are using wrong WordPress name:

  • readme.txt:13
  • comments in source code (header.php:27, functions.php:39)

2
Theme should not support backward compatibility for more than one prior major WordPress version. In readme.txt we can find info that theme is compatibile with version 3.4. Please change this to at least 3.8.

Thanks

#20 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.6 to THEME: OMG - 1.7

OMG - 1.7

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.7
ZIP - https://wordpress.org/themes/download/omg.1.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.6&new_path=/omg/1.7

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.7/screenshot.png

#21 @wpdevshed
3 years ago

Hi Pawel, I have addressed these issues in 1.7. Standing by for any further feedback. Thanks.

#22 @Pawel Wawrzyniak
3 years ago

Hi,

Thank you very much for the latest changes.
I've checked whole theme again and unfortunately found a few new things that needs to be fixed.

Required

1 Internationalization

  • You are using at least three differnet text domains:
    • OMG (example: functions.php line 200 and below),
    • omgtheme (example: functions.php line 97)
    • dbt (example: library/omg.php line 60)
  • Some texts are not internationalized at all (header.php line 118, functions.php line 432 and line 596, footer.php line 58, format.php line 58, format-audio.php line 54, the other files in the post-formats folder and the files in home-post-format )
  • I would highly recommend that the text domain should be changed to 'omg' which is the theme slug. This will be useful when the WordPress.org respository adds better support for translations in the future.

2 Image sizes
The image size handles should be prefixed in functions.php line 69-70 so not to cause conflicts.

3
Please remove http: in functions.php line 148 and 178 so that there is no issue on https sites and replace it with protocol relative link. How to do that you can find here: http://wptavern.com/wordpress-tip-how-to-load-google-fonts-over-ssl-and-non-ssl

4 Removing dashboard widgets

  • Please do not remove default dashboard widgets (omgtheme_disable_default_dashboard_widgets() in library/admin.php) This is not allowed.
  • Adding new dashbord widget with rss feed to wpcandy (omgtheme_rss_dashboard_widget() in library/admin.php) is questionable.

5 WordPress core features
In library/omg.php and in functions.php the code is removing core features (for instance wp_head links and WordPress version, rss version). This is not allowed.

6
In functions.php you have following two lines:
35: add_theme_support( 'custom-header' );
36: remove_theme_support( 'custom-header' );

7
In functions.php:58 the code is removing menu position. This is not allowed.

add_action( 'admin_menu', 'omgtheme_nav_menu', 999 );
function omgtheme_nav_menu() {
  $page = remove_submenu_page( 'themes.php', 'nav-menus.php' );
}

Thanks

#23 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.7 to THEME: OMG - 1.8

OMG - 1.8

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.8
ZIP - https://wordpress.org/themes/download/omg.1.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.7&new_path=/omg/1.8

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.8/screenshot.png

#24 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.8 to THEME: OMG - 1.9

OMG - 1.9

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/1.9
ZIP - https://wordpress.org/themes/download/omg.1.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.8&new_path=/omg/1.9

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/1.9/screenshot.png

#25 @wpdevshed
3 years ago

Hi Pawel, 1.9 adds support for some more elements that needed internationlization. Standing by for more feedback.

#26 @wpdevshed
3 years ago

Hi Pawel, looking forward to your feedback :)

#27 @Pawel Wawrzyniak
3 years ago

Hi,

Thank you very much for the latest changes. Once again I've checked the whole theme and there are still some issues that needs to be fixed.

Required

1
In functions.php:56 the code is removing menu position. This is not allowed.

add_action( 'admin_menu', 'omgtheme_nav_menu', 999 );
function omgtheme_nav_menu() {
  $page = remove_submenu_page( 'themes.php', 'nav-menus.php' );
}

2
There are still some not internationalized texts in:

  • functions.php (in omg_custom_image_sizes function),
  • omg.php (field and group names for ACF).

3
There are still wrong text domains in some places

  • index.php (please look for 'simplyread' string),
  • in omg_register_required_plugins function, text domain is tgmpa. Please use omg instead.

4
If you want to disable the gallery css please do something like this

add_filter( 'use_default_gallery_style', '__return_false' ); 

instead of

add_filter( 'gallery_style', 'omg_gallery_style' );

5
The handler in omg_fonts function should be prefixed. Please use omg_google_fonts instead or similar instead of googleFonts.

1
Please remove omg.mo file. It is not necessary.

2
Please remove empty line at the end of omg.php file (after ?>) or just remove ?>. It could generate "Header alread send..." error messages.

Thanks

#28 @themetracbot
3 years ago

  • Summary changed from THEME: OMG - 1.9 to THEME: OMG - 2.0

OMG - 2.0

OMG is a modern full width, fully responsive theme especially suited to bloggers who want to feature bold images on their home page and archive pages. It also offers easy customization options for the logo, favicon, color scheme, social media icons, slider behaviour, and optional author bios and related posts display.

Theme URL - http://wpdevshed.com/themes/omg-theme/
Author URL - http://wpdevshed.com/

SVN - https://themes.svn.wordpress.org/omg/2.0
ZIP - https://wordpress.org/themes/download/omg.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/omg/1.9&new_path=/omg/2.0

History:

Ticket Summary Status Resolution Owner
#20394 THEME: OMG - 2.0 closed closed-newer-version-uploaded Pawel Wawrzyniak

(this ticket)

#22008 THEME: OMG - 2.6 closed live chemiker
#22990 THEME: OMG - 2.8 closed live emiluzelac
#24332 THEME: omgilove – 1.5 closed not-approved aiooxx
#26894 THEME: OMG – 2.9 closed live jcastaneda
#27204 THEME: OMG – 3.0 closed live jcastaneda


https://themes.svn.wordpress.org/omg/2.0/screenshot.png

#29 @Pawel Wawrzyniak
3 years ago

  • Status changed from reviewing to approved

Hi,

Thank you very much for the latest changes.

There are still some not internationalized texts in functions.php:65 (omg_custom_image_sizes function)

function omg_custom_image_sizes( $sizes ) {
    return array_merge( $sizes, array(
        'omg-thumb-600' => '600px by 150px',
        'omg-thumb-300' => '300px by 100px',
        'omg-slider-image' => '1280px by 500px'
    ) );
}

But I think that you can fix this in the next theme update.

Thank you for the all fixes and hard work. From my point of view everything looks fine right now.

#30 @wpdevshed
3 years ago

Thanks Pawel, really appreciate your feedback and patience with this. I will definitely address this in the next version.

#31 follow-up: @karmatosed
3 years ago

  • Status changed from approved to reopened

Hi, unfortunately the following needs sorting before the theme can be approved:


Required

  • Don’t output CSS directly to the header.php file such as you have before wp_head
  • If you provide a minified file you have to provide an un-minified one. Modernizr has only minified version.

Recommendations

  • You really should indent and code format better. This helps both users and reviewers, along with yourself for updating.
  • Adding comments to your templates will really help.

If you can please do that changes, we can progress with your review. Once you’ve done the revisions, just re-upload through wordpress.org and it will append to this ticket.

#32 in reply to: ↑ 31 @wpdevshed
3 years ago

Hi @karmatosed, I uploaded the new version and it created a new ticket:

https://themes.trac.wordpress.org/ticket/22008

Did I do something wrong?

#33 @wpdevshed
3 years ago

Hi folks, grateful for an update on this one. Thanks.

This ticket was mentioned in Slack in #themereview by chemiker. View the logs.


3 years ago

#35 @emiluzelac
3 years ago

  • Status changed from reopened to reviewing

#36 @emiluzelac
3 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.